From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67E6ECCA481 for ; Tue, 19 Jul 2022 10:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235583AbiGSKWa (ORCPT ); Tue, 19 Jul 2022 06:22:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232165AbiGSKW3 (ORCPT ); Tue, 19 Jul 2022 06:22:29 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [5.144.164.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B94313F1E for ; Tue, 19 Jul 2022 03:22:27 -0700 (PDT) Received: from [192.168.1.101] (abxj77.neoplus.adsl.tpnet.pl [83.9.3.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 773B93F79E; Tue, 19 Jul 2022 12:22:25 +0200 (CEST) Message-ID: Date: Tue, 19 Jul 2022 12:22:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] ARM: dts: qcom: ipq8064: reorganize node order and sort them Content-Language: en-US To: Krzysztof Kozlowski , Dmitry Baryshkov Cc: Christian Marangi , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220718153815.29414-1-ansuelsmth@gmail.com> <7f2a4f21-5e07-9320-8f7b-573ccc562f43@linaro.org> <78230095-6b45-4536-f41d-12bb23308d34@linaro.org> From: Konrad Dybcio In-Reply-To: <78230095-6b45-4536-f41d-12bb23308d34@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19.07.2022 12:16, Krzysztof Kozlowski wrote: > On 19/07/2022 11:59, Dmitry Baryshkov wrote: >> On Tue, 19 Jul 2022 at 12:56, Krzysztof Kozlowski >> wrote: >>> >>> On 18/07/2022 17:38, Christian Marangi wrote: >>>> Reorganize node order and sort them by address. >>>> >>>> Signed-off-by: Christian Marangi >>>> --- >>>> >>>> This was picked from for-next qcom branch [1]. Reorganize dtsi as requested. >>>> >>>> [1] https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/?h=for-next >>> >>> If this is picked by qcom branch, no need to resend it. >>> >>> I don't see value in such reshuffle. Reviewing is not possible and you >>> did not mention tests (results should be equal). >> >> The value is usual for all the cleanups: make it follow the >> established practice. > > Are you sure this is established practice? Yes. New DTSI files (see SC8280XP, > sm8450 although sc7280 looked ordered) do not always follow it, so why > imposing it for existing code? Perhaps it slipped through review.. Partially my bad. Such reshuffle can cause conflicts thus > stops parallel development. Review is close to impossible... Almost any addition or removal also causes conflicts, because git is not as smart as we would like it to be. If the commit is structured properly (i.e. it *only* changes the order and nothing else), decompiling the dtbs before and after applying it and using a tool like meld that can find similar chunks of text at different offsets review is definitely possible, though not very pleasant (you can't just diff them, as order is preserved & phandles change due to that) as you have to look at it manually and can't tell much by just taking a look at the email. Konrad > > Best regards, > Krzysztof