From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61DDDEB64DA for ; Fri, 16 Jun 2023 17:00:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345937AbjFPRAu (ORCPT ); Fri, 16 Jun 2023 13:00:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346360AbjFPRAW (ORCPT ); Fri, 16 Jun 2023 13:00:22 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F163B49E7 for ; Fri, 16 Jun 2023 09:59:20 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5196a728d90so1265795a12.0 for ; Fri, 16 Jun 2023 09:59:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=oRadAW9LWnD262uK2pxmP5H40mzdqIIoSFwtmKhwYhURgjOAF1K+nhkRzojy3cLt3O ZV9QVOCWHeJ70snod2xzhMr++SyUkZCkk52zXtnAV9eYqu5w/I8o0JVQeplagrkNdgJq StAIQKvXLx3Iqb86k6ALjzMlY5FpwqSjSSM+hOHM1S6V3TcahlOrPrRguCogeZBKgCJ/ 67xBYPJv5Yjl78YG54OHJ6mwjHVMoyPzLS71qbAB0F/stMl3MMABgtRk/d69jycvF3Br PP7u6318cEznzU1ynPTb8tVDvPraT22NIWhpZu2VAdPjt7n4DgvnaU8k1IfASnNwG6RH +8Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686934759; x=1689526759; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mx45Gb+XOJkrBIEOQGfyEEPJszl2aIrpIEmyleHuzAA=; b=W2ZIiPsV1awhgW5Ngd0EomnGm643NlTlE27yBY4I4JHnjk7kGoOR/9ItPEnKiJCLh0 u6aPpemovwNMbGYOf2UFvBs5FhHkEuG1aWkhUHZRmpbjHttLBUtgv5B6dj1AZ4N7ovFI DXao/aio0KvLTL0kFVdWPPQxUSK+8YOdlQ/2SMgz2Z8mRgkQJZM0gJ8/M/1azuiNZDSl eMYSpty2ycc0/PWHRSryPmAtxrn75HwqH/3naHEufMdsgQc5Awiw+peIG7dt0XovfVqv S2ttj20HIqLqy56nHAwp0XB8/zI1jwnKY5u9G21NFejJTdUBoel4U0nQ0D59SC0aMxjF nwMw== X-Gm-Message-State: AC+VfDx4t6cA1HrYQZIPi5rYs6yaH8bhCheoUXNnmNqZX61dTmP3cBEo 4qgu23mcFmz43YfH2L79n5F8QKJIY0nygL6OPac= X-Google-Smtp-Source: ACHHUZ7wllev2biqWgYIidoYvTlpr/fZdLupzoU9AbrYoM7SCIfM4LPZ/0xDi5+7EbQ0/3tuQN2dQg== X-Received: by 2002:aa7:c851:0:b0:514:a685:aa3b with SMTP id g17-20020aa7c851000000b00514a685aa3bmr1432750edt.41.1686934759403; Fri, 16 Jun 2023 09:59:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id g25-20020a50ee19000000b0050bfeb15049sm9980703eds.60.2023.06.16.09.59.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 09:59:18 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 18:59:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/3] dt-bindings: arm: Add SolidRun LX2162A SoM & Clearfog Board Content-Language: en-US To: Josua Mayer , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Li Yang , Marek Vasut , Fabio Estevam , Stefan Wahren , Frieder Schrempf , Marcel Ziswiler , Andreas Kemnade References: <20230616110610.32173-1-josua@solid-run.com> <20230616110610.32173-3-josua@solid-run.com> <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> From: Krzysztof Kozlowski In-Reply-To: <5139b72e-cccb-43b3-ba37-35f0011e4a2b@solid-run.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16/06/2023 15:32, Josua Mayer wrote: > HI Krzysztof, > > Am 16.06.23 um 14:36 schrieb Krzysztof Kozlowski: >> On 16/06/2023 13:06, Josua Mayer wrote: >>> Add DT compatible for SolidRun LX2162A SoM and Clearfog board. >>> >>> Signed-off-by: Josua Mayer >>> --- >>> Documentation/devicetree/bindings/arm/fsl.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 15d411084065..438a4ece8157 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -1373,9 +1373,11 @@ properties: >>> - description: SolidRun LX2160A based Boards >>> items: >>> - enum: >>> + - solidrun,clearfog >>> - solidrun,clearfog-cx >>> - solidrun,honeycomb >>> - const: solidrun,lx2160a-cex7 >>> + - const: solidrun,lx2162a-som >>> - const: fsl,lx2160a >> You change existing entries, breaking boards and changing the meaning, >> without any explanation in commit msg. That's not how it is done. Please >> provide rationale in commit msg. > > I'm sorry. Given your comment I think I did not understand how these > entries are supposed to work. > So perhaps you can provide some guidance based on my explanation?: > > - NXP LX2162 is a smaller physical package of the same LX2160 SoC, with > reduced IOs and some silicon blocks disabled. > - SolidRun LX2162 SoM is essentially a different form factor of LX2160 CEX > - SolidRun LX2162 Clearfog is the reference platform for the SoM. > Despite it's naming similarity to clearfog-cx, it has a different > feature set more similar to SolidRun Armada 388 Clearfog Pro > > So I believed I could just add to the existing entry "SolidRun LX2160A > based Boards" also the new LX2162 Board & SoM. But you added much more, didn't you? > I see now that adding a fourth const messes upthe existing 3-part > compatible for those already existing boards. > > Please can you confirm if it would have been more correct to replace > "const: solidrun,lx2160a-cex7" with an enum?: > enum: >   - solidrun,lx2160a-cex7 >   - solidrun,lx2162a-som > > Finally, is it okay to add a "solidrun,clearfog" given my explanation > above, or should it be more specific "solidrun,lx2162a-clearfog"? > Test the binding and test DTS against it: Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ It might point you to answer. Why do you make solidrun,honeycomb compatible with cex7 and som? Best regards, Krzysztof