From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: zhuyinbo <zhuyinbo@loongson.cn>, Rob Herring <robh@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
Mark Brown <broonie@kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
loongson-kernel@lists.loongnix.cn, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: spi: add loongson spi
Date: Wed, 29 Mar 2023 13:37:36 +0200 [thread overview]
Message-ID: <f62c07d4-cda8-9873-8890-3411cd2f3b03@linaro.org> (raw)
In-Reply-To: <8336d5ba-1150-81ca-bd5a-7862bd10ef58@loongson.cn>
On 29/03/2023 12:39, zhuyinbo wrote:
>
>
> 在 2023/3/28 下午8:57, Rob Herring 写道:
>>
>> On Tue, 28 Mar 2023 19:22:09 +0800, Yinbo Zhu wrote:
>>> Add the Loongson platform spi binding with DT schema format using
>>> json-schema.
>>>
>>> Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn>
>>> ---
>>> .../bindings/spi/loongson,ls-spi.yaml | 43 +++++++++++++++++++
>>> MAINTAINERS | 6 +++
>>> 2 files changed, 49 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/spi/loongson,ls-spi.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> Error: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dts:22.28-29 syntax error
>> FATAL ERROR: Unable to parse input tree
>> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/spi/loongson,ls-spi.example.dtb] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> make: *** [Makefile:1512: dt_binding_check] Error 2
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230328112210.23089-2-zhuyinbo@loongson.cn
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
> Hi Rob,
>
> I'm sorry, actually, I don't know what the specific operation I should
> do when I received the check warning
> from your bot. Does it means that I should add dependency note into this
> patch's changelog ?
Yes, this is explicitly mentioned in the sentence you quoted.
> or something else, I really
> don't know. Actually, I'm always bothered by these things that how to
> resolve the dependency issue for two
> dependent patches that do not belong to the same series.
Another approach, as Rob suggested last time, would be to just get rid
of the dependency and open-code the clock IDs...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-29 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 11:22 [PATCH v4 0/2] spi: loongson: add bus driver for the loongson spi Yinbo Zhu
2023-03-28 11:22 ` [PATCH v4 1/2] dt-bindings: spi: add " Yinbo Zhu
2023-03-28 11:30 ` zhuyinbo
2023-03-28 12:57 ` Rob Herring
2023-03-29 1:12 ` zhuyinbo
2023-03-29 8:05 ` Krzysztof Kozlowski
2023-03-29 10:32 ` zhuyinbo
2023-03-29 10:39 ` zhuyinbo
2023-03-29 11:37 ` Krzysztof Kozlowski [this message]
2023-03-30 3:00 ` zhuyinbo
2023-03-29 8:06 ` Krzysztof Kozlowski
2023-03-29 10:30 ` zhuyinbo
2023-03-28 11:22 ` [PATCH v4 2/2] spi: loongson: add bus driver for the loongson spi controller Yinbo Zhu
2023-03-28 11:35 ` [PATCH v4 0/2] spi: loongson: add bus driver for the loongson spi Andi Shyti
2023-03-28 11:53 ` zhuyinbo
2023-03-29 8:07 ` Krzysztof Kozlowski
2023-03-30 3:46 ` zhuyinbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f62c07d4-cda8-9873-8890-3411cd2f3b03@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=liupeibao@loongson.cn \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=wanghongliang@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).