Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs

From: Bu Tao <butao@huawei.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Eric Anholt <eric@anholt.net>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
	Wei Xu <xuwei5@hisilicon.com>,
	Thierry Reding <treding@nvidia.com>,
	devicetree@vger.kernel.org, suzhuangluan@hisilicon.com,
	kongfei@hisilicon.com, Rob Herring <robh+dt@kernel.org>,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Guodong Xu <guodong.xu@linaro.org>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Riku Voipio <riku.voipio@linaro.org>Linux
Subject: Re: [PATCH v2 2/5] dt-bindings: scsi: ufs: add document for hi3660-ufs
Date: Thu, 22 Jun 2017 20:23:33 +0800	[thread overview]
Message-ID: <f63c5e13-74d2-280c-af80-22ee55d71282@huawei.com> (raw)
In-Reply-To: <CAK8P3a1MRx5zRp5-7iDY32+6PGsyHFaOom-bkWmftpLUS=8gBA@mail.gmail.com>

在 2017/6/22 20:15, Arnd Bergmann 写道:
> On Thu, Jun 22, 2017 at 1:58 PM, Bu Tao <butao@huawei.com> wrote:
>> 在 2017/6/22 19:51, Arnd Bergmann 写道:
>>> On Thu, Jun 22, 2017 at 1:44 PM, Bu Tao <butao@huawei.com> wrote:
>>>> 在 2017/6/17 5:51, Arnd Bergmann 写道:
>>>>> On Fri, Jun 16, 2017 at 8:51 AM, Bu Tao <butao@hisilicon.com> wrote:
>>>>
>>>> I do not know wheher other SoC need to use the optional properties as
>>>> abover. So here the name of the optional properties has "hi3660".
>>>
>>>
>>> They should not have "hi3660" in their names either way, independent
>>> of where they are used.
>>
>>
>> Oh, change the "hi3660" to "hisilicon"?
>> e.g. ufs-hi3660-use-rate-B  -->  ufs-hisilicon-use-rate-B
>
> No, just 'use-rate-B', no prefix for this.
>
>>>>> (note: this is different from the value of the "compatible" property
>>>>> that
>>>>> is meant to be as specific as possible".
>>>>>
>>>>> Also, please clarify how your binding relates to the ufshcd binding
>>>>> in Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt: does
>>>>> hi3660 implement any registers that are shared with ufshcd, or does
>>>>> it use the same physical interface with a different register set?
>>>>
>>>>
>>>> No, only show how to use the dt-binding for hi3660 SoC
>>>
>>>
>>> My question was about the hardware: does hi3660 implement ufshcd
>>> or not?
>>
>>
>> YES
>
> Ok, then the properties should be documented as optional in the
> Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt file for anything
> that has a proper interpretation in the context of the generic ufshcd
> driver.
>
>       Arnd
>

OK I will modify this and update the patch soon.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel