From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F42C4727F for ; Sun, 27 Sep 2020 06:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D80E239D4 for ; Sun, 27 Sep 2020 06:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730330AbgI0Gt0 (ORCPT ); Sun, 27 Sep 2020 02:49:26 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:14240 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730224AbgI0Gt0 (ORCPT ); Sun, 27 Sep 2020 02:49:26 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 41C6E69F3BB150381954; Sun, 27 Sep 2020 14:49:23 +0800 (CST) Received: from [127.0.0.1] (10.174.177.253) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Sun, 27 Sep 2020 14:49:14 +0800 Subject: Re: [PATCH v6 0/6] irqchip: dw-apb-ictl: support hierarchy irq domain To: Marc Zyngier , Vineet Gupta , "Rob Herring" , Alexey Brodkin , linux-snps-arc , devicetree , linux-kernel , Jason Cooper , Thomas Gleixner CC: Kefeng Wang , Haoyu Lv , Sebastian Hesselbarth , Libin References: <20200924071754.4509-1-thunder.leizhen@huawei.com> <160104911402.38543.3098076840902954515.b4-ty@kernel.org> From: "Leizhen (ThunderTown)" Message-ID: Date: Sun, 27 Sep 2020 14:49:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <160104911402.38543.3098076840902954515.b4-ty@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.253] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020/9/25 23:54, Marc Zyngier wrote: > On Thu, 24 Sep 2020 15:17:48 +0800, Zhen Lei wrote: >> v5 --> v6: >> 1. add Reviewed-by: Rob Herring for Patch 4. >> 2. Some modifications are made to Patch 5: >> 1) add " |" for each "description:" property if its content exceeds one line, >> to tell the yaml keep the "newline" character. >> 2) add "..." to mark the end of the yaml file. >> 3) Change the name list of maintainers to the author of "snps,dw-apb-ictl.txt" >> maintainers: >> - - Marc Zyngier >> + - Sebastian Hesselbarth >> 4) add "maxItems: 1" for property "reg". >> 5) for property "interrupts": >> interrupts: >> - minItems: 1 >> - maxItems: 65 >> + maxItems: 1 >> 6) move below descriptions under the top level property "description:" >> description: | >> Synopsys DesignWare provides interrupt controller IP for APB known as >> dw_apb_ictl. The IP is used as secondary interrupt controller in some SoCs >> with APB bus, e.g. Marvell Armada 1500. It can also be used as primary >> interrupt controller in some SoCs, e.g. Hisilicon SD5203. >> >> [...] > > Applied to irq/irqchip-next, thanks! Thank you very much. You have provided a lot of valuable review of this patch series. > > [1/6] genirq: Add stub for set_handle_irq() when !GENERIC_IRQ_MULTI_HANDLER > commit: ea0c80d1764449acf2f70fdb25aec33800cd0348 > [2/6] irqchip/dw-apb-ictl: Refactor priot to introducing hierarchical irq domains > commit: d59f7d159891466361808522b63cf3548ea3ecb0 > [3/6] irqchip/dw-apb-ictl: Add primary interrupt controller support > commit: 54a38440b84f8933b555c23273deca6a396f6708 > [4/6] dt-bindings: dw-apb-ictl: Update binding to describe use as primary interrupt controller > commit: 8156b80fd4885d0ca9748e736441cc37f4eb476a > > I have dropped patch 5 as it doesn't have Rob's Ack yet (and is not that > critical) as well as patch 6 which is better routed via the ARC tree. OK. I will continue talking to Rob about patch 5. Rob suggested me to remove below allOf, but I have not done it. If the allOf should be removed, the 6/6 will be discarded. +allOf: + - $ref: /schemas/interrupt-controller.yaml# > > Cheers, > > M. >