devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org,
	Shawn Guo <shawnguo@kernel.org>, Li Yang <leoyang.li@nxp.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too
Date: Thu, 18 Aug 2022 16:44:28 +0200	[thread overview]
Message-ID: <f646670f8ebc64cf1a3080330d54d733@walle.cc> (raw)
In-Reply-To: <20220818140519.2767771-3-vladimir.oltean@nxp.com>

Am 2022-08-18 16:05, schrieb Vladimir Oltean:
> The LS1028A switch has 2 internal links to the ENETC controller.
> 
> With DSA's ability to support multiple CPU ports, we should mark both
> ENETC ports as DSA masters.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 3da105119d82..455778936899 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -1170,6 +1170,7 @@ mscc_felix_port5: port@5 {
>  						reg = <5>;
>  						phy-mode = "internal";
>  						status = "disabled";
> +						ethernet = <&enetc_port3>;

status should be the last property, no?

-michael

  reply	other threads:[~2022-08-18 14:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 14:05 [PATCH devicetree 0/3] NXP LS1028A DT changes for multiple switch CPU ports Vladimir Oltean
2022-08-18 14:05 ` [PATCH devicetree 1/3] arm64: dts: ls1028a: move DSA CPU port property to the common SoC dtsi Vladimir Oltean
2022-08-18 14:45   ` Michael Walle
2022-08-18 14:05 ` [PATCH devicetree 2/3] arm64: dts: ls1028a: mark enetc port 3 as a DSA master too Vladimir Oltean
2022-08-18 14:44   ` Michael Walle [this message]
2022-08-18 14:45     ` Vladimir Oltean
2022-08-18 15:08       ` Michael Walle
2022-08-22  3:53         ` Shawn Guo
2022-08-18 14:05 ` [PATCH devicetree 3/3] arm64: dts: ls1028a: enable swp5 and eno3 for all boards Vladimir Oltean
2022-08-18 15:06   ` Michael Walle
2022-08-18 14:49 ` [PATCH devicetree 0/3] NXP LS1028A DT changes for multiple switch CPU ports Michael Walle
2022-08-18 14:55   ` Vladimir Oltean
2022-08-18 15:05     ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f646670f8ebc64cf1a3080330d54d733@walle.cc \
    --to=michael@walle.cc \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).