devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 4/7] arm64: dts: imx93: add blk ctrl node
Date: Fri, 12 Aug 2022 13:08:27 +0300	[thread overview]
Message-ID: <f64a1e5e-d2be-68d7-9bca-de03de6ddbfa@linaro.org> (raw)
In-Reply-To: <20220812074609.53131-5-peng.fan@oss.nxp.com>

On 12/08/2022 10:46, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add i.MX93 BLK CTRL MIX node
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
> index dd76472ced46..55f396723adb 100644
> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
> @@ -112,6 +112,11 @@ aips1: bus@44000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			anomix_ns_gpr: blk-ctrl-ns-anomix@44210000 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> +				compatible = "syscon";

No, syscon alone is not allowed.

> +				reg = <0x44210000 0x1000>;
> +			};
> +
>  			mu1: mailbox@44230000 {
>  				compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu";
>  				reg = <0x44230000 0x10000>;
> @@ -174,6 +179,11 @@ aips2: bus@42000000 {
>  			#size-cells = <1>;
>  			ranges;
>  
> +			wakeupmix_gpr: blk-ctrl-wakeupmix@42420000 {
> +				compatible = "syscon";

Ditto


Best regards,
Krzysztof

  reply	other threads:[~2022-08-12 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12  7:46 [PATCH 0/7] arm64: dts: imx93: add several nodes Peng Fan (OSS)
2022-08-12  7:46 ` [PATCH 1/7] arm64: dts: imx93: correct SDHC clk entry Peng Fan (OSS)
2022-08-12  7:46 ` [PATCH 2/7] arm64: dts: imx93: add gpio clk Peng Fan (OSS)
2022-08-12  7:46 ` [PATCH 3/7] arm64: dts: imx93: add s4 mu node Peng Fan (OSS)
2022-08-12 10:07   ` Krzysztof Kozlowski
2022-08-12  7:46 ` [PATCH 4/7] arm64: dts: imx93: add blk ctrl node Peng Fan (OSS)
2022-08-12 10:08   ` Krzysztof Kozlowski [this message]
2022-08-12  7:46 ` [PATCH 5/7] arm64: dts: imx93: add a55 pmu Peng Fan (OSS)
2022-08-12  7:46 ` [PATCH 6/7] arm64: dts: imx93: add lpi2c nodes Peng Fan (OSS)
2022-08-12 10:09   ` Krzysztof Kozlowski
2022-08-12  7:46 ` [PATCH 7/7] arm64: dts: imx93: add lpspi nodes Peng Fan (OSS)
2022-08-12 10:10   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f64a1e5e-d2be-68d7-9bca-de03de6ddbfa@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).