From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 924DCC00140 for ; Fri, 12 Aug 2022 10:08:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237207AbiHLKIf (ORCPT ); Fri, 12 Aug 2022 06:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232800AbiHLKIf (ORCPT ); Fri, 12 Aug 2022 06:08:35 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8161DA6C05 for ; Fri, 12 Aug 2022 03:08:33 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id c17so713846lfb.3 for ; Fri, 12 Aug 2022 03:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=XiuPovkOS+97bdIezfgaSELX7apRbPfn23zXTyCPRYk=; b=WK+XalqL9DhlZk4XXCNjIasm1v6PShzJ0j1k6NNDg2OA/sTrwKqxKyOeR30qVU8KSm oB6RcyAI+rgp/qomDS50vXsRvpgGMU8hYFCIKZ3rfvns7CeJy2kHl5nUhkq1YWlyvy27 cvJnc0yE450p5CX/WPDXWB4MfItwVfRLOwl3ssTIJXwq977JkU3V7JMXU4eLy/Ci12Qz r+M3dyeG4GbLhWugWVKe+0EYYXQUNTT8CrLnzFgZwYk0ZEaw2xK4AxdnaXwoNqV/KM3o i62cojAHPISkcXI02zlCcfMeFmW2uytivQyJBlzVmi+Lc29iczuX09DG6ucdy0IJXNf8 Bvcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=XiuPovkOS+97bdIezfgaSELX7apRbPfn23zXTyCPRYk=; b=bKUc1I54pT7xM9fO3mx7oSWJ+aFx52f5dalMeFbPL4HHHdWKYbg0FzujIpzdGMaiV+ e0bcMTsCJn3dU5vv1XFHtvSBxX9OYn06PjOuaCFDLOKcVuwh/28xKZWTyMg2VPBkzWFG BgLjGT3N7IMi0ixNHcry9PoBz7Knq13c9owxrVuPiPNm5Wzi+i0tQNrZrJoWSiCYgWWl dKhsk4VgmMWb9bh7/xrUJ1ax6ohK0u7fsjfHWNT+gczCIyRyose6wqAHpZEdsdHyVBh2 XBncbJ+xCot8o7l6q+YvVHvhG4m8FkpMXy+RWPObMFl4UKnXrkL3DNHMOLW9ZP0sFlX5 F6MQ== X-Gm-Message-State: ACgBeo244L7J9+1pCsymWat1bw5/JqyUAetttdK0MdYDWbRAKXrttuSh hBAq5RPQEEIKZ7fpC7m3VC0vs2TQMBEFddiS X-Google-Smtp-Source: AA6agR4LZIMe34S+FTwy2eQTrI+Qal/bV+LtzQk8TenlMIk3y8r8aBndkPCQ4cyu0M3CJBKoNOY/ZA== X-Received: by 2002:a05:6512:3e07:b0:48b:131:616 with SMTP id i7-20020a0565123e0700b0048b01310616mr1154422lfv.475.1660298911903; Fri, 12 Aug 2022 03:08:31 -0700 (PDT) Received: from [192.168.1.39] ([83.146.140.105]) by smtp.gmail.com with ESMTPSA id z19-20020a05651c11d300b0025dfd2f66d6sm303951ljo.95.2022.08.12.03.08.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Aug 2022 03:08:31 -0700 (PDT) Message-ID: Date: Fri, 12 Aug 2022 13:08:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/7] arm64: dts: imx93: add blk ctrl node Content-Language: en-US To: "Peng Fan (OSS)" , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan References: <20220812074609.53131-1-peng.fan@oss.nxp.com> <20220812074609.53131-5-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220812074609.53131-5-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/08/2022 10:46, Peng Fan (OSS) wrote: > From: Peng Fan > > Add i.MX93 BLK CTRL MIX node > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi > index dd76472ced46..55f396723adb 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -112,6 +112,11 @@ aips1: bus@44000000 { > #size-cells = <1>; > ranges; > > + anomix_ns_gpr: blk-ctrl-ns-anomix@44210000 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "syscon"; No, syscon alone is not allowed. > + reg = <0x44210000 0x1000>; > + }; > + > mu1: mailbox@44230000 { > compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu"; > reg = <0x44230000 0x10000>; > @@ -174,6 +179,11 @@ aips2: bus@42000000 { > #size-cells = <1>; > ranges; > > + wakeupmix_gpr: blk-ctrl-wakeupmix@42420000 { > + compatible = "syscon"; Ditto Best regards, Krzysztof