From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Todor Tomov <todor.too@gmail.com>,
	Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com,
	tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
	yijie.yang@oss.qualcomm.com,
	Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Atiya Kailany <atiya.kailany@oss.qualcomm.com>
Subject: Re: [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080
Date: Thu, 16 Oct 2025 10:12:31 +0100	[thread overview]
Message-ID: <f64bc46b-9c21-49a8-b5d8-3e21614b6695@linaro.org> (raw)
In-Reply-To: <20251014-add-support-for-camss-on-kaanapali-v2-5-f5745ba2dff9@oss.qualcomm.com>
On 15/10/2025 03:56, Hangxiang Ma wrote:
> +	for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++)
> +		if (csid->phy.en_vc & BIT(i)) {
> +			val = readl(csid->base + CSID_CSI2_RDIN_IRQ_STATUS(i));
> +			writel(val, csid->base + CSID_CSI2_RDIN_IRQ_CLEAR(i));
> +
> +			if (buf_done_val & BIT(BUF_DONE_IRQ_STATUS_RDI_OFFSET + i)) {
> +				/*
> +				 * buf done and RUP IRQ have been moved to CSID from VFE.
> +				 * Once CSID received buf done, need notify VFE of this
> +				 * event and trigger VFE to handle buf done process.
> +				 */
> +				camss_buf_done(csid->camss, csid->id, i);
> +			}
> +		}
> +
A multi-liner like this should be
for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS_1080; i++) {
	/* etc */
}
in fact csid_reset_1080() does the right thing, please replicate.
next prev parent reply	other threads:[~2025-10-16  9:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15  2:56 [PATCH v2 0/6] media: qcom: camss: Add Kaanapali support Hangxiang Ma
2025-10-15  2:56 ` [PATCH v2 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible Hangxiang Ma
2025-10-15 19:30   ` Vladimir Zapolskiy
2025-10-16  1:56     ` Hangxiang Ma
2025-10-16  7:54       ` Vladimir Zapolskiy
2025-10-16  7:56       ` Konrad Dybcio
2025-10-20  4:13         ` Hangxiang Ma
2025-10-20 18:38           ` Vijay Kumar Tumati
2025-10-16 10:40       ` Krzysztof Kozlowski
2025-10-15  2:56 ` [PATCH v2 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding Hangxiang Ma
2025-10-15  4:37   ` Rob Herring (Arm)
2025-10-16  5:51     ` Krzysztof Kozlowski
2025-10-15 19:45   ` Vladimir Zapolskiy
2025-10-15 21:43     ` Bryan O'Donoghue
2025-10-15 23:32       ` Vladimir Zapolskiy
2025-10-16  3:46         ` Vijay Kumar Tumati
2025-10-16  8:03           ` Vladimir Zapolskiy
2025-10-16  5:50     ` Krzysztof Kozlowski
2025-10-16 23:53     ` Vijay Kumar Tumati
2025-10-17  0:27       ` Vladimir Zapolskiy
2025-10-23  4:52         ` Vijay Kumar Tumati
2025-10-23 11:13           ` Vladimir Zapolskiy
2025-10-23 18:06             ` Vijay Kumar Tumati
2025-10-24  8:49               ` Bryan O'Donoghue
2025-10-16  5:52   ` Krzysztof Kozlowski
2025-10-15  2:56 ` [PATCH v2 3/6] media: qcom: camss: Add Kaanapali compatible camss driver Hangxiang Ma
2025-10-16  8:55   ` Bryan O'Donoghue
2025-10-20  6:45     ` Hangxiang Ma
2025-10-20 13:38       ` Vijay Kumar Tumati
2025-10-20 18:18         ` Bryan O'Donoghue
2025-10-15  2:56 ` [PATCH v2 4/6] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY Hangxiang Ma
2025-10-16  8:59   ` Bryan O'Donoghue
2025-10-16 23:10     ` Vijay Kumar Tumati
2025-10-17 10:55       ` Bryan O'Donoghue
2025-10-15  2:56 ` [PATCH v2 5/6] media: qcom: camss: csid: Add support for CSID 1080 Hangxiang Ma
2025-10-16  9:12   ` Bryan O'Donoghue [this message]
2025-10-20  5:59     ` Hangxiang Ma
2025-10-16 10:04   ` Bryan O'Donoghue
2025-10-16 10:18     ` Bryan O'Donoghue
2025-10-16 22:03       ` Vijay Kumar Tumati
2025-10-16 22:55     ` Vijay Kumar Tumati
2025-10-15  2:56 ` [PATCH v2 6/6] media: qcom: camss: vfe: Add support for VFE 1080 Hangxiang Ma
2025-10-16 10:09   ` Bryan O'Donoghue
2025-10-16 10:33     ` Hangxiang Ma
2025-10-16 10:54       ` Bryan O'Donoghue
2025-10-16 23:28         ` Vijay Kumar Tumati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=f64bc46b-9c21-49a8-b5d8-3e21614b6695@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andi.shyti@kernel.org \
    --cc=atiya.kailany@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hangxiang.ma@oss.qualcomm.com \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=todor.too@gmail.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=vladimir.zapolskiy@linaro.org \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).