devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>,
	Vabhav Sharma <vabhav.sharma@nxp.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Franck Lenormand <franck.lenormand@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Varun Sethi <V.Sethi@nxp.com>,
	Silvano Di Ninno <silvano.dininno@nxp.com>,
	Pankaj Gupta <pankaj.gupta@nxp.com>, Frank Li <frank.li@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree bindings
Date: Sun, 16 Jun 2024 09:33:58 +0200	[thread overview]
Message-ID: <f6515498-ffc4-45b0-a19c-82204e4c83c0@kernel.org> (raw)
In-Reply-To: <DU0PR04MB9299FB3B70920CF85CA2FB6B80C12@DU0PR04MB9299.eurprd04.prod.outlook.com>

On 13/06/2024 10:48, Aisheng Dong wrote:
> Hi Krzysztof, 
> 
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 2024年6月13日 14:14
>>
>> On 12/06/2024 09:20, Aisheng Dong wrote:
>>> Hi Krzysztof
>>>
>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>> Sent: 2024年6月7日 15:08
>>>>
>>>> On 07/06/2024 06:58, Vabhav Sharma wrote:
>>>>>>
>>>>>> Missing SoC compatibles.
>>>>> Ok, I will use fsl,imx8dxl-sc-secvio
>>>>>>
>>>>>> So no, that's just abuse of DT to instantiate driver.
>>>>>>
>>>>>> NAK. Drop the binding.
>>>>> I will detail the dt binding to describe the real hardware
>>>>
>>>> Still looks like way just to instantiate driver. Why it cannot be
>>>> part of existing firmware SCU node?
>>>>
>>>
>>> Technically yes. But SCU case is a little bit complicated as there're
>>> many functions and all of them are already added as sub nodes in SCU
>>> node for consistency and handling platform difference.
>>>
>>> I guess some of them, e.g. rtc, could be part of SCU node (reuse)
>>> while some couldn't. e.g. pinctrl Do you want us to only make secvio
>>> reuse existing SCU node?
>>
>> Yes
>>
> 
> Digging a bit more on the implementation. It seems there will be a
> 'parent depends on child' issue when reusing the parent SCU node for secvio.
> Considering the defer probe support and ocotop could be modules, I'm still thinking
> If any solution. Do you have a good suggestion?

I don't see any problem there. You will have even worse if making it
children and using populate - unpredictable order.

Best regards,
Krzysztof


  reply	other threads:[~2024-06-16  7:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-09  0:45 [PATCH 0/4] soc: imx: secvio: Add secvio support Vabhav Sharma
2024-05-09  0:45 ` [PATCH 1/4] dt-bindings: firmware: secvio: Add device tree bindings Vabhav Sharma
2024-05-09  3:06   ` Frank Li
2024-05-09  5:54     ` Krzysztof Kozlowski
2024-06-07  5:00       ` [EXT] " Vabhav Sharma
2024-06-07  5:08     ` Vabhav Sharma
2024-05-09  5:53   ` Krzysztof Kozlowski
2024-06-07  4:58     ` [EXT] " Vabhav Sharma
2024-06-07  7:07       ` Krzysztof Kozlowski
2024-06-12  7:20         ` Aisheng Dong
2024-06-13  6:13           ` Krzysztof Kozlowski
2024-06-13  8:48             ` Aisheng Dong
2024-06-16  7:33               ` Krzysztof Kozlowski [this message]
2024-06-17 10:11                 ` Aisheng Dong
2024-06-17 12:11                   ` Krzysztof Kozlowski
2024-05-09  0:45 ` [PATCH 2/4] firmware: imx: Add SC APIs required for secvio module Vabhav Sharma
2024-05-09  0:45 ` [PATCH 3/4] soc: imx: secvio: Add support for SNVS secvio and tamper via SCFW Vabhav Sharma
2024-05-09  0:45 ` [PATCH 4/4] arm64: dts: imx8q: Add node for Security Violation Vabhav Sharma
2024-05-09  5:51 ` [PATCH 0/4] soc: imx: secvio: Add secvio support Krzysztof Kozlowski
2024-06-07  4:52   ` [EXT] " Vabhav Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6515498-ffc4-45b0-a19c-82204e4c83c0@kernel.org \
    --to=krzk@kernel.org \
    --cc=V.Sethi@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=franck.lenormand@nxp.com \
    --cc=frank.li@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pankaj.gupta@nxp.com \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=silvano.dininno@nxp.com \
    --cc=vabhav.sharma@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).