From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Li Chen <lchen@ambarella.com>, Li Chen <me@linux.beauty>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: "moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:MEMORY TECHNOLOGY DEVICES (MTD)"
<linux-mtd@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 11/15] dt-bindings: mtd: Add binding for Ambarella
Date: Mon, 23 Jan 2023 09:13:00 +0100 [thread overview]
Message-ID: <f6545c08-3be2-523e-db21-81b2b9233743@linaro.org> (raw)
In-Reply-To: <20230123073305.149940-12-lchen@ambarella.com>
On 23/01/2023 08:32, Li Chen wrote:
> Ambarella SoC contains nand flash controller.
> Add compatible for it.
>
> Signed-off-by: Li Chen <lchen@ambarella.com>
> Change-Id: I4108699a0678ba45e5d4347cbd860bc552dd91dd
> ---
> .../bindings/mtd/ambarella,nand.yaml | 77 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 78 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/ambarella,nand.yaml
>
> diff --git a/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml
> new file mode 100644
> index 000000000000..7c2e7c2ebc7b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/ambarella,nand.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Ambarella NAND Controller
> +
> +maintainers:
> + - Li Chen <lchen@ambarella.com>
> +
> +properties:
> + compatible:
> + - const: ambarella,nand
> +
> + reg:
> + minItems: 1
> + maxItems: 1
All your patches are weirder and weirder. Do you see such syntax in any
patches before?
Drop minItems.
> +
> + interrupts:
> + minItems: 1
> + maxItems: 1
Drop both.
> + items:
> + - description: fio irq
> +
> + clocks:
> + maxItems: 1
> + description: reference to the clock for the NAND controller
> +
> + nand-on-flash-bbt:
OK, so this was for sure not tested.
Do not send untested patches.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-23 8:13 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 7:32 [PATCH 00/15] Ambarella S6LM SoC bring-up Li Chen
2023-01-23 7:32 ` [PATCH 02/15] dt-bindings: vendor-prefixes: add Ambarella prefix Li Chen
2023-01-23 8:02 ` Krzysztof Kozlowski
[not found] ` <20230123073305.149940-4-lchen@ambarella.com>
2023-01-23 8:03 ` [PATCH 03/15] dt-bindings: arm: ambarella: Add binding for Ambarella ARM platforms Krzysztof Kozlowski
2023-01-23 13:58 ` Li Chen
[not found] ` <20230123073305.149940-5-lchen@ambarella.com>
2023-01-23 8:07 ` [PATCH 04/15] dt-bindings: arm: add support for Ambarella SoC Krzysztof Kozlowski
2023-01-23 15:09 ` Li Chen
2023-01-23 15:52 ` Krzysztof Kozlowski
[not found] ` <20230123073305.149940-8-lchen@ambarella.com>
2023-01-23 8:11 ` [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings Krzysztof Kozlowski
2023-01-25 9:28 ` Li Chen
2023-01-25 9:55 ` Krzysztof Kozlowski
2023-01-25 12:06 ` Li Chen
2023-01-25 12:14 ` Krzysztof Kozlowski
2023-01-25 13:40 ` Li Chen
2023-01-26 11:29 ` Krzysztof Kozlowski
2023-01-27 14:48 ` Li Chen
2023-01-27 15:08 ` Krzysztof Kozlowski
2023-01-28 9:42 ` Li Chen
2023-01-28 10:08 ` Krzysztof Kozlowski
2023-01-28 10:11 ` Li Chen
2023-02-06 11:28 ` Li Chen
2023-02-06 13:41 ` Krzysztof Kozlowski
2023-02-06 14:57 ` Li Chen
2023-02-08 10:27 ` Krzysztof Kozlowski
2023-01-27 15:11 ` Krzysztof Kozlowski
2023-01-28 9:45 ` Li Chen
[not found] ` <20230123073305.149940-10-lchen@ambarella.com>
2023-01-23 8:11 ` [PATCH 09/15] dt-bindings: serial: add support for Ambarella Krzysztof Kozlowski
2023-01-25 9:54 ` Li Chen
2023-01-25 9:56 ` Krzysztof Kozlowski
2023-01-28 9:22 ` Li Chen
[not found] ` <20230123073305.149940-12-lchen@ambarella.com>
2023-01-23 8:13 ` Krzysztof Kozlowski [this message]
[not found] ` <20230123073305.149940-14-lchen@ambarella.com>
2023-01-23 8:13 ` [PATCH 13/15] dt-bindings: pinctrl: " Krzysztof Kozlowski
2023-01-23 12:32 ` Linus Walleij
2023-01-28 10:05 ` Li Chen
[not found] ` <20230123073305.149940-16-lchen@ambarella.com>
2023-01-23 8:20 ` [PATCH 15/15] arm64: dts: ambarella: introduce Ambarella s6lm SoC Krzysztof Kozlowski
2023-01-23 8:39 ` [PATCH 00/15] Ambarella S6LM SoC bring-up Arnd Bergmann
2023-01-24 2:08 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6545c08-3be2-523e-db21-81b2b9233743@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lchen@ambarella.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=me@linux.beauty \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).