From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8C8C05027 for ; Mon, 23 Jan 2023 08:13:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231268AbjAWINF (ORCPT ); Mon, 23 Jan 2023 03:13:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230129AbjAWINF (ORCPT ); Mon, 23 Jan 2023 03:13:05 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9C4317CE3 for ; Mon, 23 Jan 2023 00:13:03 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id bk16so9941445wrb.11 for ; Mon, 23 Jan 2023 00:13:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/vmftNUH4lJM4o0fNkA/Mo2hyPMGER9tgtwQaLax718=; b=CEmcLOfj2uvDlsYOFfECG5QQo4JiI2GmtU0n2XxyqOL1bKFVNhfJ1/+xG9c7Gdn9LR 5WwlQ7E8XLdqIc9GgYHkGSOFz5wBs2OMXwVD82N7gP7gQj04Ivlt99ERv5AUh/UZDsNR g3dOMhaO/2LOy8qXRrQPLe0HcSFLVLis05909Xe0Agfyn5QqxRzxc6ofRoeYgjaX0XJh fq7tNfnzb7n891YjupRGBvu4HUgA4zVFs7BwZsFnNZMTAPLZcOwzetuKwbGqGM/cFXTh flK1UERpj2Z+YpqtvJwleYtcFX9c2NWvvDSuVUBwZ0797nRn4xn7RvPt9YZdGxuAfQkZ ykvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/vmftNUH4lJM4o0fNkA/Mo2hyPMGER9tgtwQaLax718=; b=QRbC4j2tPvlriw3vJE2w6QzKPw7pfCxCQF1P+pW0OnZf6EUeoFnLjaIMJyO0iGk9JF jAR3Yd+JaCkPnzZyAHjd9I/Wx81RKo1c6bJkGw/759u2lJt7VxH4oT4GVCTC3imd8LJ5 27ku7RlpXY9eWxztriMq0tsFyrklhd/srIfJbouMsAZY/qgw4QiEnyOp/7SVQmynq6Za UOGRsyZKu8tXMSkhDSxU/Gx3wTt3mPqTEjwqObKyi+2epz34z4D3q84HIZwSmWx/Zx0H 0MNLUudf1iqZt5knIy641glY/JjD0PhfyZ5C2Suc7QXB/LdkI5EMXR8nrMD/I31F1h2q ojjQ== X-Gm-Message-State: AFqh2kp1ve5iAdn9RHI/vaViX3qKqEW5zLC1fqIehXQcZktwp56ACEcv YUOKI9N7P/JsCTUlt3MWTIzWsg== X-Google-Smtp-Source: AMrXdXuwG3DQj4QQEJp6l1ReLzlEPBchCHBIwvu+r6Zfs2PgFt87jgzGiZo4ZgAND9u0Z90u0jypyA== X-Received: by 2002:a05:6000:1b83:b0:2be:34f5:ac05 with SMTP id r3-20020a0560001b8300b002be34f5ac05mr14935369wru.0.1674461582432; Mon, 23 Jan 2023 00:13:02 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id c24-20020adfa318000000b002366e3f1497sm4719097wrb.6.2023.01.23.00.13.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jan 2023 00:13:02 -0800 (PST) Message-ID: Date: Mon, 23 Jan 2023 09:13:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 11/15] dt-bindings: mtd: Add binding for Ambarella Content-Language: en-US To: Li Chen , Li Chen , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski Cc: "moderated list:ARM/Ambarella SoC support" , "open list:MEMORY TECHNOLOGY DEVICES (MTD)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-12-lchen@ambarella.com> From: Krzysztof Kozlowski In-Reply-To: <20230123073305.149940-12-lchen@ambarella.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/01/2023 08:32, Li Chen wrote: > Ambarella SoC contains nand flash controller. > Add compatible for it. > > Signed-off-by: Li Chen > Change-Id: I4108699a0678ba45e5d4347cbd860bc552dd91dd > --- > .../bindings/mtd/ambarella,nand.yaml | 77 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > new file mode 100644 > index 000000000000..7c2e7c2ebc7b > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/ambarella,nand.yaml > @@ -0,0 +1,77 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/ambarella,nand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Ambarella NAND Controller > + > +maintainers: > + - Li Chen > + > +properties: > + compatible: > + - const: ambarella,nand > + > + reg: > + minItems: 1 > + maxItems: 1 All your patches are weirder and weirder. Do you see such syntax in any patches before? Drop minItems. > + > + interrupts: > + minItems: 1 > + maxItems: 1 Drop both. > + items: > + - description: fio irq > + > + clocks: > + maxItems: 1 > + description: reference to the clock for the NAND controller > + > + nand-on-flash-bbt: OK, so this was for sure not tested. Do not send untested patches. Best regards, Krzysztof