* Re: [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568
2025-02-27 11:08 [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568 Kever Yang
@ 2025-02-28 20:09 ` Rob Herring (Arm)
2025-03-07 17:22 ` Srinivas Kandagatla
2025-03-17 0:00 ` Jonas Karlman
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2025-02-28 20:09 UTC (permalink / raw)
To: Kever Yang
Cc: Conor Dooley, linux-kernel, Srinivas Kandagatla, heiko,
linux-rockchip, Krzysztof Kozlowski, devicetree, linux-arm-kernel
On Thu, 27 Feb 2025 19:08:02 +0800, Kever Yang wrote:
> Add compatible entry for the otp controller in rk3562 and rk3568, add schema
> for different clock names for new entry.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2:
> - Update the commit message and add maxItems in schema.
>
> .../bindings/nvmem/rockchip,otp.yaml | 53 ++++++++++++++++---
> 1 file changed, 46 insertions(+), 7 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568
2025-02-27 11:08 [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568 Kever Yang
2025-02-28 20:09 ` Rob Herring (Arm)
@ 2025-03-07 17:22 ` Srinivas Kandagatla
2025-03-17 0:00 ` Jonas Karlman
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2025-03-07 17:22 UTC (permalink / raw)
To: Kever Yang, heiko
Cc: linux-rockchip, devicetree, Conor Dooley, Rob Herring,
linux-kernel, Krzysztof Kozlowski, linux-arm-kernel
Hi Kever,
On 27/02/2025 11:08, Kever Yang wrote:
> Add compatible entry for the otp controller in rk3562 and rk3568, add schema
> for different clock names for new entry.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
Am unable to apply this patch, Could you rebase it on top of linux-next
or
https://web.git.kernel.org/pub/scm/linux/kernel/git/srini/nvmem.git/log/?h=for-next
--srini
>
> Changes in v2:
> - Update the commit message and add maxItems in schema.
>
> .../bindings/nvmem/rockchip,otp.yaml | 53 ++++++++++++++++---
> 1 file changed, 46 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> index a44d44b32809..7572f4a1d73b 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> @@ -14,6 +14,8 @@ properties:
> enum:
> - rockchip,px30-otp
> - rockchip,rk3308-otp
> + - rockchip,rk3562-otp
> + - rockchip,rk3568-otp
> - rockchip,rk3588-otp
>
> reg:
> @@ -25,19 +27,15 @@ properties:
>
> clock-names:
> minItems: 3
> - items:
> - - const: otp
> - - const: apb_pclk
> - - const: phy
> - - const: arb
> + maxItems: 4
>
> resets:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
>
> reset-names:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
>
> required:
> - compatible
> @@ -62,12 +60,45 @@ allOf:
> properties:
> clocks:
> maxItems: 3
> + clock-names:
> + items:
> + - const: otp
> + - const: apb_pclk
> + - const: phy
> resets:
> maxItems: 1
> reset-names:
> items:
> - const: phy
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3562-otp
> + - rockchip,rk3568-otp
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: usr
> + - const: sbpi
> + - const: apb_pclk
> + - const: phy
> + resets:
> + minItems: 4
> + maxItems: 4
> + reset-names:
> + items:
> + - const: usr
> + - const: sbpi
> + - const: apb
> + - const: phy
> +
> - if:
> properties:
> compatible:
> @@ -78,8 +109,16 @@ allOf:
> properties:
> clocks:
> minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: otp
> + - const: apb_pclk
> + - const: phy
> + - const: arb
> resets:
> minItems: 3
> + maxItems: 3
> reset-names:
> items:
> - const: otp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568
2025-02-27 11:08 [PATCH v2 1/3] dt-bindings: nvmem: rockchip,otp: Add support for rk3562 and rk3568 Kever Yang
2025-02-28 20:09 ` Rob Herring (Arm)
2025-03-07 17:22 ` Srinivas Kandagatla
@ 2025-03-17 0:00 ` Jonas Karlman
2 siblings, 0 replies; 4+ messages in thread
From: Jonas Karlman @ 2025-03-17 0:00 UTC (permalink / raw)
To: Kever Yang
Cc: heiko, linux-rockchip, devicetree, Conor Dooley, Rob Herring,
Srinivas Kandagatla, linux-kernel, Krzysztof Kozlowski,
linux-arm-kernel
Hi Kever,
On 2025-02-27 12:08, Kever Yang wrote:
> Add compatible entry for the otp controller in rk3562 and rk3568, add schema
> for different clock names for new entry.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
> Changes in v2:
> - Update the commit message and add maxItems in schema.
>
> .../bindings/nvmem/rockchip,otp.yaml | 53 ++++++++++++++++---
> 1 file changed, 46 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> index a44d44b32809..7572f4a1d73b 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip,otp.yaml
> @@ -14,6 +14,8 @@ properties:
> enum:
> - rockchip,px30-otp
> - rockchip,rk3308-otp
> + - rockchip,rk3562-otp
> + - rockchip,rk3568-otp
> - rockchip,rk3588-otp
>
> reg:
> @@ -25,19 +27,15 @@ properties:
>
> clock-names:
> minItems: 3
> - items:
> - - const: otp
> - - const: apb_pclk
> - - const: phy
> - - const: arb
> + maxItems: 4
>
> resets:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
>
> reset-names:
> minItems: 1
> - maxItems: 3
> + maxItems: 4
For clock-names above and reset-names we could possible skip the
min/max-items, e.g. something like:
clock-names: true
reset-names: true
and then only keep the items prop in the different conditions below.
>
> required:
> - compatible
> @@ -62,12 +60,45 @@ allOf:
> properties:
> clocks:
> maxItems: 3
> + clock-names:
> + items:
> + - const: otp
> + - const: apb_pclk
> + - const: phy
> resets:
> maxItems: 1
> reset-names:
> items:
> - const: phy
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - rockchip,rk3562-otp
> + - rockchip,rk3568-otp
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: usr
Why do we not use the name "otp" here ? For px30 and rk3308 the clock is
named clk_otp_usr and we still use the "otp" name.
> + - const: sbpi
> + - const: apb_pclk
> + - const: phy
> + resets:
> + minItems: 4
> + maxItems: 4
> + reset-names:
> + items:
> + - const: usr
Same here.
This needs to be rebased to also include rk3576 clock-names.
I prepared a FIXUP commit at [1] with the suggested changes, feel free
to squash any changes you agree with in a v3.
I am planing to send out a OTP series for RK3528, and that will depend
on next revision of this series :-)
[1] https://github.com/Kwiboo/linux-rockchip/commits/next-20250314-rk3528/
Regards,
Jonas
> + - const: sbpi
> + - const: apb
> + - const: phy
> +
> - if:
> properties:
> compatible:
> @@ -78,8 +109,16 @@ allOf:
> properties:
> clocks:
> minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: otp
> + - const: apb_pclk
> + - const: phy
> + - const: arb
> resets:
> minItems: 3
> + maxItems: 3
> reset-names:
> items:
> - const: otp
^ permalink raw reply [flat|nested] 4+ messages in thread