Devicetree
 help / color / mirror / Atom feed
From: "Maíra Canal" <mcanal@igalia.com>
To: Melissa Wen <mwen@igalia.com>, Iago Toral <itoral@igalia.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Stefan Wahren <wahrenst@gmx.net>,
	Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Phil Elwell <phil@raspberrypi.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	kernel-dev@igalia.com,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Emma Anholt <emma@anholt.net>,
	"Rob Herring (Arm)" <robh@kernel.org>
Subject: Re: [PATCH v6 0/5] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5
Date: Sun, 23 Mar 2025 11:45:12 -0300	[thread overview]
Message-ID: <f66fe250-8452-423f-aa0f-6f589e566e16@igalia.com> (raw)
In-Reply-To: <20250317-v3d-gpu-reset-fixes-v6-0-f3ee7717ed17@igalia.com>

On 17/03/25 22:01, Maíra Canal wrote:
> This series addresses GPU reset issues reported in [1], where running a
> long compute job would trigger repeated GPU resets, leading to a UI
> freeze.
> 
> The patches that prevent the same faulty job from being resubmitted in a
> loop were merged in drm-misc/drm-misc-fixes in v4.
> 
> However, those patches don't solve the issue entirely. Even with a single
> GPU reset, the UI still freezes on the Raspberry Pi 5, indicating a GPU
> hang. Patches #1, #3, and #5 address this by properly configuring the
> V3D_SMS registers, which are required for power management and resets
> in V3D 7.1.
> 
> Patches #2 and #4 are associated changes related to the robustness
> of the DT bindings. Patch #3 added a new register bank to the DT binding
> and during the reviewing process, we identified points that could to be
> improved in the DT binding.
> 
> Patch #2 started by adding per-compatible register restrictions to ensure
> that the DTB accurately reflects the hardware design and #5 updates the DT
> maintainership, replacing Emma with the current v3d driver maintainer.
> 
> [1] https://github.com/raspberrypi/linux/issues/6660
> 
> Best Regards,
> - Maíra
> 

[...]

Applied to misc/kernel.git (drm-misc-next). Before applying PATCH 1/5, I
fixed the W=1 warning reported by the kernel test robot with the
following diff:

-       gen = (enum v3d_gen)of_device_get_match_data(dev);
+       gen = (uintptr_t)of_device_get_match_data(dev);

Thanks for all involved in the reviewing process!

Best Regards,
- Maíra

> ---
> Maíra Canal (5):
>        drm/v3d: Associate a V3D tech revision to all supported devices
>        dt-bindings: gpu: v3d: Add per-compatible register restrictions
>        dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible
>        dt-bindings: gpu: v3d: Add V3D driver maintainer as DT maintainer
>        drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x
> 
>   .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml      |  90 ++++++++++++---
>   drivers/gpu/drm/v3d/v3d_debugfs.c                  | 126 ++++++++++-----------
>   drivers/gpu/drm/v3d/v3d_drv.c                      |  62 +++++++++-
>   drivers/gpu/drm/v3d/v3d_drv.h                      |  22 +++-
>   drivers/gpu/drm/v3d/v3d_gem.c                      |  27 ++++-
>   drivers/gpu/drm/v3d/v3d_irq.c                      |   6 +-
>   drivers/gpu/drm/v3d/v3d_perfmon.c                  |   4 +-
>   drivers/gpu/drm/v3d/v3d_regs.h                     |  26 +++++
>   drivers/gpu/drm/v3d/v3d_sched.c                    |   6 +-
>   9 files changed, 271 insertions(+), 98 deletions(-)
> ---
> base-commit: 83a0237859bc5a9e0a716e1db8e7fd3cafd63259
> change-id: 20250224-v3d-gpu-reset-fixes-2d21fc70711d
> 


      parent reply	other threads:[~2025-03-23 14:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  1:01 [PATCH v6 0/5] drm/v3d: Fix GPU reset issues on the Raspberry Pi 5 Maíra Canal
2025-03-18  1:01 ` [PATCH v6 1/5] drm/v3d: Associate a V3D tech revision to all supported devices Maíra Canal
2025-03-18 16:44   ` Stefan Wahren
2025-03-18 20:03   ` kernel test robot
2025-03-18  1:01 ` [PATCH v6 2/5] dt-bindings: gpu: v3d: Add per-compatible register restrictions Maíra Canal
2025-03-18  8:03   ` Krzysztof Kozlowski
2025-03-18  1:01 ` [PATCH v6 3/5] dt-bindings: gpu: v3d: Add SMS register to BCM2712 compatible Maíra Canal
2025-03-19 11:07   ` Stefan Wahren
2025-03-18  1:01 ` [PATCH v6 4/5] dt-bindings: gpu: v3d: Add V3D driver maintainer as DT maintainer Maíra Canal
2025-03-18  1:01 ` [PATCH v6 5/5] drm/v3d: Use V3D_SMS registers for power on/off and reset on V3D 7.x Maíra Canal
2025-03-27 10:57   ` Stefan Wahren
2025-03-27 13:52     ` Maíra Canal
2025-03-27 15:19       ` Stefan Wahren
2025-03-23 14:45 ` Maíra Canal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f66fe250-8452-423f-aa0f-6f589e566e16@igalia.com \
    --to=mcanal@igalia.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emma@anholt.net \
    --cc=florian.fainelli@broadcom.com \
    --cc=itoral@igalia.com \
    --cc=kernel-dev@igalia.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=mwen@igalia.com \
    --cc=nsaenz@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox