From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C2E8C05027 for ; Wed, 1 Feb 2023 07:25:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231804AbjBAHZi (ORCPT ); Wed, 1 Feb 2023 02:25:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231600AbjBAHZh (ORCPT ); Wed, 1 Feb 2023 02:25:37 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59B006EAE for ; Tue, 31 Jan 2023 23:25:36 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id h16so16327610wrz.12 for ; Tue, 31 Jan 2023 23:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BPo/q9D5ac3uSvDlctkYDl419CKsFo9D1tuwF0xBQlM=; b=fy0dKzPqaB8hOEpanX1S5Gbg3Ip9oWiLfNZbjZIZeSvomNGiBtB1E5o5ouFodKSw54 pghlzI6+1roiTNyQsG/cTRHAe/TeSAcUUbBjALLR9njBpZgdabNMtAEI5vIYy4cqJfC4 8SeKCr+ppc/G5NmQXFmRbA3mA1OgxDwJMbPbPExqWTNGfs/hR/8Tj98nyrl0LS4Tqa0i liBeBJ7iTtVUCCJkvtp9bYhxoOKxCdznnX8OWX7iDe40mWAqi/xL+z7DvEnAb9vWyrHx VZTs1XPf3SKsxTYLz4/DYW7Ufr5Yk4EzwsnU+ebRk76Hez0PA7dbUFBYfRBNu5OcMZDH fA4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BPo/q9D5ac3uSvDlctkYDl419CKsFo9D1tuwF0xBQlM=; b=5vKh/nZ/vX6kHRF+2PPkM5CO6Md+Rr80eLmwN93R0j8ZAc9NJ0609pQNYhgUdisAVm mgFdrnlOUeWs6Bq5wAZEQ/HJJWGpaINDxqp2cH6+ybj64Sd53sK6O6+skworngW9DD8p 6uyd44e0hBwvuvgOhRpEQUJihhg+PTBaP784rpS3QdE60ISh9Hxm37k2KBQPJEQ6uEyU +gbE+KkVj2qX+77II+mDNSTQTR3GDmr3QKeCnuIQyAjgiFfLorbf/BuMYJIYz82OAD57 FhOPnHbk66wUxt2JHJCkHHIzuXGisruyh5CCEmTGIl0wbzHyiC6J5yllj0KIhGV4RjHV wdSw== X-Gm-Message-State: AO0yUKUk0GTuOAqcq8lq6/+1dq92ubqqzJAngM3L2gIhzYgYqfziXV9e Z65NRcDiXcksntEk+wTd8d+RSw== X-Google-Smtp-Source: AK7set+prGSYrdiu8oqIfF4ozlr1/98VvmogLktJ4xqgfQoviK77oZcGC9yxgETNqDXONBvvoaJTSQ== X-Received: by 2002:a5d:4b4e:0:b0:242:eb5:254f with SMTP id w14-20020a5d4b4e000000b002420eb5254fmr636375wrs.48.1675236334808; Tue, 31 Jan 2023 23:25:34 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id m15-20020a056000024f00b002bfae16ee2fsm17168542wrz.111.2023.01.31.23.25.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 23:25:34 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 08:25:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 2/5] dt-bindings: mfd: Add ADI MAX77541/MAX77540 Content-Language: en-US To: "Sahin, Okan" Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jonathan Cameron , Lars-Peter Clausen , Andy Shevchenko , Caleb Connolly , Marcus Folkesson , "Bolboaca, Ramona" , William Breathitt Gray , ChiYuan Huang , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-iio@vger.kernel.org" References: <20230118063822.14521-1-okan.sahin@analog.com> <20230118063822.14521-3-okan.sahin@analog.com> <04ac07ef-ee4b-abb8-9fb2-114e3a646a2f@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/01/2023 22:28, Sahin, Okan wrote: > On Tue, 31 Jan 2023 7:44 PM > Krzysztof Kozlowski wrote: > >> On 31/01/2023 13:02, Sahin, Okan wrote: >>>>> + regulators: >>>>> + $ref: /schemas/regulator/adi,max77541-regulator.yaml# >>>> >>>> No improvements regarding bisectability - this patch fails. If you >>>> tested this patch, you would see it. >>>> >>>> Instead of ignoring comments, either implement them or ask for clarification. >>>> >>>> >>> Sorry for misunderstanding, I checked patchset as a whole not one by one this is >> why I did not get failure after "make dt_binding_check " . Right now, I understand >> why you are saying this patch fails, but what is your suggestion? what is the >> correct order for this patchset? I sent adi,max77541-regulator.yaml in path 4/5. >> In the light of discussion, should I remove all the parts related to regulator in >> patch 2/5, then add adi,max77541-regulator.yaml and update >> adi,max77541.yaml in patch 4/5? or should I add new patch to update >> adi,max77541.yaml? >> >> Regulator binding patch should be first in the series (bindings are before usage), >> then the MFD binding should come. Your cover letter should clearly at the top >> mention the dependency. You can also mention dependency in MFD patch after -- >> -, because many of us do not really read cover letters... >> >> >> Best regards, >> Krzysztof > Hi Krzysztof, > > Thank you for your feedback. I tried to explain in cover letter .However, I understand that it was not clear enough. I do not want to take your time, but let me ask one thing to understand the case completely. Right now, my order is like below > [cover letter]->[mfd driver]->[mfd binding]->[regulator driver]->[regulator binding]->[adc]. > Should I completely change the ordering e.g. starting with regulator ending with mfd or is it sufficient to just get the regulator binding just before the mfd bindings? "bindings are before usage" - what's unclear? How can you use binding before defining it? Best regards, Krzysztof