[PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
@ 2024-08-27  7:27 Jie Gan
  2024-08-27  7:27 ` [PATCH v1 1/1] arm64: dts: qcom: Add coresight nodes " Jie Gan
                   ` (2 more replies)
  0 siblings, 3 replies; 12+ messages in thread
From: Jie Gan @ 2024-08-27  7:27 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

Add coresight components for x1e80100. This change includes CTI,
dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.

Change in V1:
Check the dtb with dtbs_check W=1, and fix the warnings for
the change.

Jie Gan (1):
  arm64: dts: qcom: Add coresight nodes for x1e80100

 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1514 ++++++++++++++++++++++++
 1 file changed, 1514 insertions(+)

-- 
2.34.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v1 1/1] arm64: dts: qcom: Add coresight nodes for x1e80100
  2024-08-27  7:27 [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100 Jie Gan
@ 2024-08-27  7:27 ` Jie Gan
  2024-08-27  8:02 ` [PATCH v1 0/1] arm64: dts: qcom: Add coresight components " Krzysztof Kozlowski
  2024-09-02 15:27 ` Konrad Dybcio
  2 siblings, 0 replies; 12+ messages in thread
From: Jie Gan @ 2024-08-27  7:27 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

Add following coresight components for x1e80100 platform.
It includes CTI, dummy sink, dynamic Funnel, Replicator, STM,
TPDM, TPDA and TMC ETF.

Signed-off-by: Jie Gan <quic_jiegan@quicinc.com>
Tested-by: Yushan Li <quic_yushli@quicinc.com>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1514 ++++++++++++++++++++++++
 1 file changed, 1514 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 74b694e74705..cd211576dcb8 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -305,6 +305,19 @@ CLUSTER_CL5: cluster-sleep-1 {
 		};
 	};
 
+	dummy-sink {
+		compatible = "arm,coresight-dummy-sink";
+
+		in-ports {
+			port {
+				eud_in: endpoint {
+					remote-endpoint =
+					<&swao_rep_out1>;
+				};
+			};
+		};
+	};
+
 	firmware {
 		scm: scm {
 			compatible = "qcom,scm-x1e80100", "qcom,scm";
@@ -5398,6 +5411,1507 @@ qup_uart21_default: qup-uart21-default-state {
 			};
 		};
 
+		stm@10002000 {
+			compatible = "arm,coresight-stm", "arm,primecell";
+			reg = <0x0 0x10002000 0x0 0x1000>,
+			      <0x0 0x16280000 0x0 0x180000>;
+			reg-names = "stm-base", "stm-stimulus-base";
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					stm_out: endpoint {
+						remote-endpoint =
+						<&funnel0_in7>;
+					};
+				};
+			};
+		};
+
+		tpdm@10003000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10003000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					dcc_tpdm_out: endpoint {
+						remote-endpoint =
+						<&qdss_tpda_in0>;
+					};
+				};
+			};
+		};
+
+		tpda@10004000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10004000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					qdss_tpda_out: endpoint {
+						remote-endpoint =
+						<&funnel0_in6>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					qdss_tpda_in0: endpoint {
+						remote-endpoint =
+						<&dcc_tpdm_out>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+					qdss_tpda_in1: endpoint {
+						remote-endpoint =
+						<&qdss_tpdm_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@1000f000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x1000f000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					qdss_tpdm_out: endpoint {
+						remote-endpoint =
+						<&qdss_tpda_in1>;
+					};
+				};
+			};
+		};
+
+		funnel@10041000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10041000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					funnel0_out: endpoint {
+						remote-endpoint =
+						<&qdss_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@6 {
+					reg = <6>;
+					funnel0_in6: endpoint {
+						remote-endpoint =
+						<&qdss_tpda_out>;
+					};
+				};
+
+				port@7 {
+					reg = <7>;
+					funnel0_in7: endpoint {
+						remote-endpoint =
+						<&stm_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10042000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10042000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					funnel1_out: endpoint {
+						remote-endpoint =
+						<&qdss_funnel_in1>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@2 {
+					reg = <2>;
+					funnel1_in2: endpoint {
+						remote-endpoint =
+						<&tmess_funnel_out>;
+					};
+				};
+
+				port@5 {
+					reg = <5>;
+					funnel1_in5: endpoint {
+						remote-endpoint =
+						<&dlst_funnel_out>;
+					};
+				};
+
+				port@6 {
+					reg = <6>;
+					funnel1_in6: endpoint {
+						remote-endpoint =
+						<&dlct1_funnel_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10045000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10045000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					qdss_funnel_out: endpoint {
+						remote-endpoint =
+						<&aoss_funnel_in7>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					qdss_funnel_in0: endpoint {
+						remote-endpoint =
+						<&funnel0_out>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+					qdss_funnel_in1: endpoint {
+						remote-endpoint =
+						<&funnel1_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10800000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10800000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					mxa_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct2_tpda_in15>;
+					};
+				};
+			};
+		};
+
+		tpdm@1082c000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x1082c000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					gcc_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in21>;
+					};
+				};
+			};
+		};
+
+		tpdm@10841000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10841000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					prng_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in19>;
+					};
+				};
+			};
+		};
+
+		tpdm@10844000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10844000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					lpass_cx_tpdm_out: endpoint {
+						remote-endpoint =
+						<&lpass_cx_funnel_in0>;
+					};
+				};
+			};
+		};
+
+		funnel@10846000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10846000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					lpass_cx_funnel_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in4>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					lpass_cx_funnel_in0: endpoint {
+						remote-endpoint =
+						<&lpass_cx_tpdm_out>;
+					};
+				};
+			};
+		};
+
+		cti@1098b000 {
+			compatible = "arm,coresight-cti", "arm,primecell";
+			reg = <0x0 0x1098b000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+		};
+
+		tpdm@109d0000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x109d0000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+			status = "disabled";
+
+			out-ports {
+				port {
+					qm_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in20>;
+					};
+				};
+			};
+		};
+
+		tpdm@10ac0000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10ac0000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+			status = "disabled";
+
+			out-ports {
+				port {
+					dlst_tpdm0_out: endpoint {
+						remote-endpoint =
+						<&dlst_tpda_in8>;
+					};
+				};
+			};
+		};
+
+		tpdm@10ac1000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10ac1000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					dlst_tpdm1_out: endpoint {
+						remote-endpoint =
+						<&dlst_tpda_in9>;
+					};
+				};
+			};
+		};
+
+		tpda@10ac4000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10ac4000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlst_tpda_out: endpoint {
+						remote-endpoint =
+						<&dlst_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@8 {
+					reg = <8>;
+					dlst_tpda_in8: endpoint {
+						remote-endpoint =
+						<&dlst_tpdm0_out>;
+					};
+				};
+
+				port@9 {
+					reg = <9>;
+					dlst_tpda_in9: endpoint {
+						remote-endpoint =
+						<&dlst_tpdm1_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10ac5000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10ac5000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlst_funnel_out: endpoint {
+						remote-endpoint =
+						<&funnel1_in5>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					dlst_funnel_in0: endpoint {
+						remote-endpoint =
+						<&dlst_tpda_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10b04000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10b04000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					aoss_funnel_out: endpoint {
+						remote-endpoint =
+						<&etf0_in>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@3 {
+					reg = <3>;
+					aoss_funnel_in3: endpoint {
+						remote-endpoint =
+						<&ddr_lpi_funnel_out>;
+					};
+				};
+
+				port@6 {
+					reg = <6>;
+					aoss_funnel_in6: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_out>;
+					};
+				};
+
+				port@7 {
+					reg = <7>;
+					aoss_funnel_in7: endpoint {
+						remote-endpoint =
+						<&qdss_funnel_out>;
+					};
+				};
+			};
+		};
+
+		etf0: tmc@10b05000 {
+			compatible = "arm,coresight-tmc", "arm,primecell";
+			reg = <0x0 0x10b05000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					etf0_out: endpoint {
+						remote-endpoint =
+						<&swao_rep_in>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					etf0_in: endpoint {
+						remote-endpoint =
+						<&aoss_funnel_out>;
+					};
+				};
+			};
+		};
+
+		replicator@10b06000 {
+			compatible = "arm,coresight-dynamic-replicator", "arm,primecell";
+			reg = <0x0 0x10b06000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					swao_rep_out1: endpoint {
+						remote-endpoint =
+						<&eud_in>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					swao_rep_in: endpoint {
+						remote-endpoint =
+						<&etf0_out>;
+					};
+				};
+			};
+		};
+
+		tpda@10b08000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10b08000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					aoss_tpda_out: endpoint {
+						remote-endpoint =
+						<&aoss_funnel_in6>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					aoss_tpda_in0: endpoint {
+						remote-endpoint =
+						<&aoss_tpdm0_out>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+					aoss_tpda_in1: endpoint {
+						remote-endpoint =
+						<&aoss_tpdm1_out>;
+					};
+				};
+
+				port@2 {
+					reg = <2>;
+					aoss_tpda_in2: endpoint {
+						remote-endpoint =
+						<&aoss_tpdm2_out>;
+					};
+				};
+
+				port@3 {
+					reg = <3>;
+					aoss_tpda_in3: endpoint {
+						remote-endpoint =
+						<&aoss_tpdm3_out>;
+					};
+				};
+
+				port@4 {
+					reg = <4>;
+					aoss_tpda_in4: endpoint {
+						remote-endpoint =
+						<&aoss_tpdm4_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b09000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b09000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					aoss_tpdm0_out: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_in0>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b0a000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b0a000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					aoss_tpdm1_out: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_in1>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b0b000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b0b000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					aoss_tpdm2_out: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_in2>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b0c000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b0c000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					aoss_tpdm3_out: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_in3>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b0d000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b0d000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					aoss_tpdm4_out: endpoint {
+						remote-endpoint =
+						<&aoss_tpda_in4>;
+					};
+				};
+			};
+		};
+
+		tpdm@10b20000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10b20000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+			status = "disabled";
+
+			out-ports {
+				port {
+					lpicc_tpdm_out: endpoint {
+						remote-endpoint =
+						<&ddr_lpi_tpda_in>;
+					};
+				};
+			};
+		};
+
+		tpda@10b23000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10b23000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+			status = "disabled";
+
+			out-ports {
+				port {
+					ddr_lpi_tpda_out: endpoint {
+						remote-endpoint =
+						<&ddr_lpi_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					ddr_lpi_tpda_in: endpoint {
+						remote-endpoint =
+						<&lpicc_tpdm_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10b24000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10b24000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+			status = "disabled";
+
+			out-ports {
+				port {
+					ddr_lpi_funnel_out: endpoint {
+						remote-endpoint =
+						<&aoss_funnel_in3>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					ddr_lpi_funnel_in0: endpoint {
+						remote-endpoint =
+						<&ddr_lpi_tpda_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10c08000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10c08000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					mm_tpdm_out: endpoint {
+						remote-endpoint =
+						<&mm_funnel_in4>;
+					};
+				};
+			};
+		};
+
+		funnel@10c0b000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10c0b000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					mm_funnel_out: endpoint {
+						remote-endpoint =
+						<&dlct2_tpda_in4>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@4 {
+					reg = <4>;
+					mm_funnel_in4: endpoint {
+						remote-endpoint =
+						<&mm_tpdm_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10c28000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10c28000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					dlct1_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in26>;
+					};
+				};
+			};
+		};
+
+		tpdm@10c29000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10c29000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					ipcc_tpdm_out: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_in27>;
+					};
+				};
+			};
+		};
+
+		tpda@10c2b000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10c2b000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlct1_tpda_out: endpoint {
+						remote-endpoint =
+						<&dlct1_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@4 {
+					reg = <4>;
+					dlct1_tpda_in4: endpoint {
+						remote-endpoint =
+						<&lpass_cx_funnel_out>;
+					};
+				};
+
+				port@13 {
+					reg = <19>;
+					dlct1_tpda_in19: endpoint {
+						remote-endpoint =
+						<&prng_tpdm_out>;
+					};
+				};
+
+				port@14 {
+					reg = <20>;
+					dlct1_tpda_in20: endpoint {
+						remote-endpoint =
+						<&qm_tpdm_out>;
+					};
+				};
+
+				port@15 {
+					reg = <21>;
+					dlct1_tpda_in21: endpoint {
+						remote-endpoint =
+						<&gcc_tpdm_out>;
+					};
+				};
+
+				port@1a {
+					reg = <26>;
+					dlct1_tpda_in26: endpoint {
+						remote-endpoint =
+						<&dlct1_tpdm_out>;
+					};
+				};
+
+				port@1b {
+					reg = <27>;
+					dlct1_tpda_in27: endpoint {
+						remote-endpoint =
+						<&ipcc_tpdm_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10c2c000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10c2c000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlct1_funnel_out: endpoint {
+						remote-endpoint =
+						<&funnel1_in6>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					dlct1_funnel_in0: endpoint {
+						remote-endpoint =
+						<&dlct1_tpda_out>;
+					};
+				};
+
+				port@4 {
+					reg = <4>;
+					dlct1_funnel_in4: endpoint {
+						remote-endpoint =
+						<&dlct2_funnel_out>;
+					};
+				};
+
+				port@5 {
+					reg = <5>;
+					dlct1_funnel_in5: endpoint {
+						remote-endpoint =
+						<&ddr_funnel0_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10c38000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10c38000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					dlct2_tpdm0_out: endpoint {
+						remote-endpoint =
+						<&dlct2_tpda_in16>;
+					};
+				};
+			};
+		};
+
+		tpdm@10c39000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10c39000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					dlct2_tpdm1_out: endpoint {
+						remote-endpoint =
+						<&dlct2_tpda_in17>;
+					};
+				};
+			};
+		};
+
+		tpda@10c3c000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10c3c000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlct2_tpda_out: endpoint {
+						remote-endpoint =
+						<&dlct2_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@4 {
+					reg = <4>;
+					dlct2_tpda_in4: endpoint {
+						remote-endpoint =
+						<&mm_funnel_out>;
+					};
+				};
+
+				port@f {
+					reg = <15>;
+					dlct2_tpda_in15: endpoint {
+						remote-endpoint =
+						<&mxa_tpdm_out>;
+					};
+				};
+
+				port@10 {
+					reg = <16>;
+					dlct2_tpda_in16: endpoint {
+						remote-endpoint =
+						<&dlct2_tpdm0_out>;
+					};
+				};
+
+				port@11 {
+					reg = <17>;
+					dlct2_tpda_in17: endpoint {
+						remote-endpoint =
+						<&dlct2_tpdm1_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10c3d000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10c3d000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					dlct2_funnel_out: endpoint {
+					remote-endpoint =
+						<&dlct1_funnel_in4>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					dlct2_funnel_in0: endpoint {
+						remote-endpoint =
+						<&dlct2_tpda_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10cc1000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10cc1000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <64>;
+			qcom,cmb-msrs-num = <32>;
+			qcom,dsb-element-bits = <32>;
+			qcom,dsb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					tmess_tpdm1_out: endpoint {
+						remote-endpoint =
+						<&tmess_tpda_in2>;
+					};
+				};
+			};
+		};
+
+		tpda@10cc4000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10cc4000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					tmess_tpda_out: endpoint {
+						remote-endpoint =
+						<&tmess_funnel_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@2 {
+					reg = <2>;
+					tmess_tpda_in2: endpoint {
+						remote-endpoint =
+						<&tmess_tpdm1_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10cc5000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10cc5000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					tmess_funnel_out: endpoint {
+						remote-endpoint =
+						<&funnel1_in2>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					tmess_funnel_in0: endpoint {
+						remote-endpoint =
+						<&tmess_tpda_out>;
+					};
+				};
+			};
+		};
+
+		funnel@10d04000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10d04000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					ddr_funnel0_out: endpoint {
+						remote-endpoint =
+						<&dlct1_funnel_in5>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@6 {
+					reg = <6>;
+					ddr_funnel0_in6: endpoint {
+						remote-endpoint =
+						<&ddr_funnel1_out>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d08000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d08000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc0_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in0>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d09000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d09000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc1_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in1>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0a000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0a000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc2_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in2>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0b000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0b000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc3_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in3>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0c000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0c000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc4_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in4>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0d000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0d000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc5_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in5>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0e000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0e000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc6_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in6>;
+					};
+				};
+			};
+		};
+
+		tpdm@10d0f000 {
+			compatible = "qcom,coresight-tpdm", "arm,primecell";
+			reg = <0x0 0x10d0f000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			qcom,cmb-element-bits = <32>;
+			qcom,cmb-msrs-num = <32>;
+
+			out-ports {
+				port {
+					llcc7_tpdm_out: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_in7>;
+					};
+				};
+			};
+		};
+
+		tpda@10d12000 {
+			compatible = "qcom,coresight-tpda", "arm,primecell";
+			reg = <0x0 0x10d12000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					llcc_tpda_out: endpoint {
+						remote-endpoint =
+						<&ddr_funnel1_in0>;
+					};
+				};
+			};
+
+			in-ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					llcc_tpda_in0: endpoint {
+						remote-endpoint =
+						<&llcc0_tpdm_out>;
+					};
+				};
+
+				port@1 {
+					reg = <1>;
+					llcc_tpda_in1: endpoint {
+						remote-endpoint =
+						<&llcc1_tpdm_out>;
+					};
+				};
+
+				port@2 {
+					reg = <2>;
+					llcc_tpda_in2: endpoint {
+						remote-endpoint =
+						<&llcc2_tpdm_out>;
+					};
+				};
+
+				port@3 {
+					reg = <3>;
+					llcc_tpda_in3: endpoint {
+						remote-endpoint =
+						<&llcc3_tpdm_out>;
+					};
+				};
+
+				port@4 {
+					reg = <4>;
+					llcc_tpda_in4: endpoint {
+						remote-endpoint =
+						<&llcc4_tpdm_out>;
+					};
+				};
+
+				port@5 {
+					reg = <5>;
+					llcc_tpda_in5: endpoint {
+						remote-endpoint =
+						<&llcc5_tpdm_out>;
+					};
+				};
+
+				port@6 {
+					reg = <6>;
+					llcc_tpda_in6: endpoint {
+						remote-endpoint =
+						<&llcc6_tpdm_out>;
+					};
+				};
+
+				port@7 {
+					reg = <7>;
+					llcc_tpda_in7: endpoint {
+						remote-endpoint =
+						<&llcc7_tpdm_out>;
+					};
+				};
+			};
+		};
+
+
+		funnel@10d13000 {
+			compatible = "arm,coresight-dynamic-funnel", "arm,primecell";
+			reg = <0x0 0x10d13000 0x0 0x1000>;
+
+			clocks = <&aoss_qmp>;
+			clock-names = "apb_pclk";
+
+			out-ports {
+				port {
+					ddr_funnel1_out: endpoint {
+						remote-endpoint =
+						<&ddr_funnel0_in6>;
+					};
+				};
+			};
+
+			in-ports {
+				port {
+					ddr_funnel1_in0: endpoint {
+						remote-endpoint =
+						<&llcc_tpda_out>;
+					};
+				};
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,x1e80100-smmu-500", "qcom,smmu-500", "arm,mmu-500";
 			reg = <0 0x15000000 0 0x100000>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-08-27  7:27 [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100 Jie Gan
  2024-08-27  7:27 ` [PATCH v1 1/1] arm64: dts: qcom: Add coresight nodes " Jie Gan
@ 2024-08-27  8:02 ` Krzysztof Kozlowski
  2024-08-27  8:06   ` JieGan
  2024-09-02 15:27 ` Konrad Dybcio
  2 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-27  8:02 UTC (permalink / raw)
  To: Jie Gan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On 27/08/2024 09:27, Jie Gan wrote:
> Add coresight components for x1e80100. This change includes CTI,
> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> 
> Change in V1:
> Check the dtb with dtbs_check W=1, and fix the warnings for
> the change.

So this is v2, not v1.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-08-27  8:02 ` [PATCH v1 0/1] arm64: dts: qcom: Add coresight components " Krzysztof Kozlowski
@ 2024-08-27  8:06   ` JieGan
  2024-08-27  9:01     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 12+ messages in thread
From: JieGan @ 2024-08-27  8:06 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Tingwei Zhang, Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai,
	Yushan Li

On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
> On 27/08/2024 09:27, Jie Gan wrote:
> > Add coresight components for x1e80100. This change includes CTI,
> > dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> > 
> > Change in V1:
> > Check the dtb with dtbs_check W=1, and fix the warnings for
> > the change.
> 
> So this is v2, not v1.
> 
Appologize for the mistake of the version number.
Do I need to re-send the patch with V2?

Thanks,
Jie

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-08-27  8:06   ` JieGan
@ 2024-08-27  9:01     ` Krzysztof Kozlowski
  2024-08-27  9:12       ` JieGan
  0 siblings, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-27  9:01 UTC (permalink / raw)
  To: JieGan
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Tingwei Zhang, Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai,
	Yushan Li

On 27/08/2024 10:06, JieGan wrote:
> On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
>> On 27/08/2024 09:27, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>
>> So this is v2, not v1.
>>
> Appologize for the mistake of the version number.
> Do I need to re-send the patch with V2?

Dunno, maybe Bjorn tools will handle this, maybe not.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-08-27  9:01     ` Krzysztof Kozlowski
@ 2024-08-27  9:12       ` JieGan
  0 siblings, 0 replies; 12+ messages in thread
From: JieGan @ 2024-08-27  9:12 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Tingwei Zhang, Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai,
	Yushan Li

On Tue, Aug 27, 2024 at 11:01:15AM +0200, Krzysztof Kozlowski wrote:
> On 27/08/2024 10:06, JieGan wrote:
> > On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
> >> On 27/08/2024 09:27, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>
> >> So this is v2, not v1.
> >>
> > Appologize for the mistake of the version number.
> > Do I need to re-send the patch with V2?
> 
> Dunno, maybe Bjorn tools will handle this, maybe not.
> 
Thanks for checking.
I think it's better to wait other feedbacks.
I will send the patch with new version number in a few days if necessary.

Thanks,
Jie 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-08-27  7:27 [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100 Jie Gan
  2024-08-27  7:27 ` [PATCH v1 1/1] arm64: dts: qcom: Add coresight nodes " Jie Gan
  2024-08-27  8:02 ` [PATCH v1 0/1] arm64: dts: qcom: Add coresight components " Krzysztof Kozlowski
@ 2024-09-02 15:27 ` Konrad Dybcio
  2024-09-03  1:30   ` JieGan
  2 siblings, 1 reply; 12+ messages in thread
From: Konrad Dybcio @ 2024-09-02 15:27 UTC (permalink / raw)
  To: Jie Gan, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On 27.08.2024 9:27 AM, Jie Gan wrote:
> Add coresight components for x1e80100. This change includes CTI,
> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> 
> Change in V1:
> Check the dtb with dtbs_check W=1, and fix the warnings for
> the change.
> 

Applying this series and enabling CORESIGHT=m (along with all the options
in menuconfig) breaks booting on my X1E Surface Laptop 7

Konrad

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-09-02 15:27 ` Konrad Dybcio
@ 2024-09-03  1:30   ` JieGan
  2024-09-04 10:08     ` Krzysztof Kozlowski
  2024-09-04 10:24     ` Konrad Dybcio
  0 siblings, 2 replies; 12+ messages in thread
From: JieGan @ 2024-09-03  1:30 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> On 27.08.2024 9:27 AM, Jie Gan wrote:
> > Add coresight components for x1e80100. This change includes CTI,
> > dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> > 
> > Change in V1:
> > Check the dtb with dtbs_check W=1, and fix the warnings for
> > the change.
> > 
> 
> Applying this series and enabling CORESIGHT=m (along with all the options
> in menuconfig) breaks booting on my X1E Surface Laptop 7
> 
> Konrad

Did not observe any booting issues with our devices. Any relevant log to share?
This patch also tested by my colleague.

Can you successfully boot without the patch?

Thanks,
Jie

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-09-03  1:30   ` JieGan
@ 2024-09-04 10:08     ` Krzysztof Kozlowski
  2024-09-05  3:37       ` JieGan
  2024-09-04 10:24     ` Konrad Dybcio
  1 sibling, 1 reply; 12+ messages in thread
From: Krzysztof Kozlowski @ 2024-09-04 10:08 UTC (permalink / raw)
  To: JieGan, Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On 03/09/2024 03:30, JieGan wrote:
> On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
>> On 27.08.2024 9:27 AM, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>>
>>
>> Applying this series and enabling CORESIGHT=m (along with all the options
>> in menuconfig) breaks booting on my X1E Surface Laptop 7
>>
>> Konrad
> 
> Did not observe any booting issues with our devices. Any relevant log to share?
> This patch also tested by my colleague.
> 
> Can you successfully boot without the patch?

I think that's the definition of "breaks booting"...

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-09-04 10:08     ` Krzysztof Kozlowski
@ 2024-09-05  3:37       ` JieGan
  0 siblings, 0 replies; 12+ messages in thread
From: JieGan @ 2024-09-05  3:37 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Konrad Dybcio, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
	Tingwei Zhang, Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai,
	Yushan Li

On Wed, Sep 04, 2024 at 12:08:51PM +0200, Krzysztof Kozlowski wrote:
> On 03/09/2024 03:30, JieGan wrote:
> > On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> >> On 27.08.2024 9:27 AM, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>>
> >>
> >> Applying this series and enabling CORESIGHT=m (along with all the options
> >> in menuconfig) breaks booting on my X1E Surface Laptop 7
> >>
> >> Konrad
> > 
> > Did not observe any booting issues with our devices. Any relevant log to share?
> > This patch also tested by my colleague.
> > 
> > Can you successfully boot without the patch?
> 
> I think that's the definition of "breaks booting"...
> 
> Best regards,
> Krzysztof
>

You are right. That's a clear expression. what a stupid question for me, lol.

Thanks,
Jie 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-09-03  1:30   ` JieGan
  2024-09-04 10:08     ` Krzysztof Kozlowski
@ 2024-09-04 10:24     ` Konrad Dybcio
  2024-09-05  3:35       ` JieGan
  1 sibling, 1 reply; 12+ messages in thread
From: Konrad Dybcio @ 2024-09-04 10:24 UTC (permalink / raw)
  To: JieGan, Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On 3.09.2024 3:30 AM, JieGan wrote:
> On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
>> On 27.08.2024 9:27 AM, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>>
>>
>> Applying this series and enabling CORESIGHT=m (along with all the options
>> in menuconfig) breaks booting on my X1E Surface Laptop 7
>>
>> Konrad
> 
> Did not observe any booting issues with our devices. Any relevant log to share?
> This patch also tested by my colleague.

Sorry, it crashes too early and my device doesn't seem to have an
easily accessible serial port. Does any of the functionality
described here require an unsecured device?

What tag did you test this patch against?

> 
> Can you successfully boot without the patch?

Yes.

Konrad

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100
  2024-09-04 10:24     ` Konrad Dybcio
@ 2024-09-05  3:35       ` JieGan
  0 siblings, 0 replies; 12+ messages in thread
From: JieGan @ 2024-09-05  3:35 UTC (permalink / raw)
  To: Konrad Dybcio
  Cc: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-arm-msm, devicetree, linux-kernel, Tingwei Zhang,
	Jinlong Mao, Tao Zhang, Yuanfang Zhang, Song Chai, Yushan Li

On Wed, Sep 04, 2024 at 12:24:19PM +0200, Konrad Dybcio wrote:
> On 3.09.2024 3:30 AM, JieGan wrote:
> > On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> >> On 27.08.2024 9:27 AM, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>>
> >>
> >> Applying this series and enabling CORESIGHT=m (along with all the options
> >> in menuconfig) breaks booting on my X1E Surface Laptop 7
> >>
> >> Konrad
> > 
> > Did not observe any booting issues with our devices. Any relevant log to share?
> > This patch also tested by my colleague.
> 
> Sorry, it crashes too early and my device doesn't seem to have an
> easily accessible serial port. Does any of the functionality
> described here require an unsecured device?
> 
I just checked the devices we used to test, they are all unsecured devices.
I also checked the dts, there are two components(known issue internally)
will fail the booting of the secure device.

I will disable those two components in next version. You can test it
with next patch.

Thanks for testing.

> What tag did you test this patch against?

next-20240820

> 
> > 
> > Can you successfully boot without the patch?
> 
> Yes.
> 
> Konrad

Thanks,
Jie

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-09-05  3:37 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27  7:27 [PATCH v1 0/1] arm64: dts: qcom: Add coresight components for x1e80100 Jie Gan
2024-08-27  7:27 ` [PATCH v1 1/1] arm64: dts: qcom: Add coresight nodes " Jie Gan
2024-08-27  8:02 ` [PATCH v1 0/1] arm64: dts: qcom: Add coresight components " Krzysztof Kozlowski
2024-08-27  8:06   ` JieGan
2024-08-27  9:01     ` Krzysztof Kozlowski
2024-08-27  9:12       ` JieGan
2024-09-02 15:27 ` Konrad Dybcio
2024-09-03  1:30   ` JieGan
2024-09-04 10:08     ` Krzysztof Kozlowski
2024-09-05  3:37       ` JieGan
2024-09-04 10:24     ` Konrad Dybcio
2024-09-05  3:35       ` JieGan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).