From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: LABBE Corentin <clabbe@baylibre.com>
Cc: Rob Herring <robh@kernel.org>,
john@metanate.com, heiko@sntech.de, p.zabel@pengutronix.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
didi.debian@cknow.org, herbert@gondor.apana.org.au,
sboyd@kernel.org, mturquette@baylibre.com,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v8 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings
Date: Sun, 10 Jul 2022 17:12:46 +0200 [thread overview]
Message-ID: <f6ab024a-582f-45b0-7d26-94a85858c761@linaro.org> (raw)
In-Reply-To: <YsabXrOyAsCkUUVN@Red>
On 07/07/2022 10:37, LABBE Corentin wrote:
> Le Wed, Jul 06, 2022 at 05:25:21PM +0200, Krzysztof Kozlowski a écrit :
>> On 06/07/2022 16:28, LABBE Corentin wrote:
>>> Le Wed, Jul 06, 2022 at 07:29:04AM -0600, Rob Herring a écrit :
>>>> On Wed, 06 Jul 2022 09:04:04 +0000, Corentin Labbe wrote:
>>>>> The latest addition to the rockchip crypto driver need to update the
>>>>> driver bindings.
>>>>>
>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>>>>> ---
>>>>> .../crypto/rockchip,rk3288-crypto.yaml | 85 +++++++++++++++++--
>>>>> 1 file changed, 77 insertions(+), 8 deletions(-)
>>>>>
>>>>
>>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>>>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>>>
>>>> yamllint warnings/errors:
>>>>
>>>> dtschema/dtc warnings/errors:
>>>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml: allOf:0:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed:
>>>> [{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too long
>>>> [{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too short
>>>> False schema does not allow 4
>>>> 1 was expected
>>>> 4 is greater than the maximum of 2
>>>> 4 is greater than the maximum of 3
>>>
>>> Hello
>>>
>>> I upgraded to dt-schema 2022.07 and fail to reproduce all errors.
>>
>> Visible on older dtschema (2022.6.dev10+gcd64f75fe091), visible on
>> newest (2022.7).
>>
>> Exactly the same error.
>>
>
> Hello
>
> I am sorry, I finally succesfully reproduced it.
> Just doing what the hints gives (removing max/min-items) from "static" list fix the issue.
Not sure what do you mean by "static list". I think you should drop
min/maxItems from clock-names/reset-names in allOf:if:then sections.
> Does I need to remove your Reviewed-by ?
Let's drop, so it will be back to my to-review queue.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-10 15:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 9:03 [PATCH v8 00/33] crypto: rockchip: permit to pass self-tests Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 01/33] crypto: rockchip: use dev_err for error message about interrupt Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 02/33] crypto: rockchip: do not use uninitialized variable Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 03/33] crypto: rockchip: do not do custom power management Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 04/33] crypto: rockchip: fix privete/private typo Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 05/33] crypto: rockchip: do not store mode globally Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 06/33] crypto: rockchip: add fallback for cipher Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 07/33] crypto: rockchip: add fallback for ahash Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 08/33] crypto: rockchip: better handle cipher key Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 09/33] crypto: rockchip: remove non-aligned handling Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 10/33] crypto: rockchip: rework by using crypto_engine Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 11/33] crypto: rockchip: rewrite type Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 12/33] crypto: rockchip: add debugfs Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 13/33] crypto: rockchip: introduce PM Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 14/33] crypto: rockchip: handle reset also in PM Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 15/33] crypto: rockchip: use clk_bulk to simplify clock management Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 16/33] crypto: rockchip: add myself as maintainer Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 17/33] crypto: rockchip: use read_poll_timeout Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 18/33] crypto: rockchip: fix style issue Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 19/33] crypto: rockchip: add support for rk3328 Corentin Labbe
2022-07-06 9:03 ` [PATCH v8 20/33] crypto: rockchip: rename ablk functions to cipher Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 21/33] crypto: rockchip: rework rk_handle_req function Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 22/33] crypto: rockchip: use a rk_crypto_info variable instead of lot of indirection Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 23/33] crypto: rockchip: use the rk_crypto_info given as parameter Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 25/33] dt-bindings: crypto: rockchip: convert to new driver bindings Corentin Labbe
2022-07-06 13:29 ` Rob Herring
2022-07-06 14:28 ` LABBE Corentin
2022-07-06 15:25 ` Krzysztof Kozlowski
2022-07-07 8:37 ` LABBE Corentin
2022-07-10 15:12 ` Krzysztof Kozlowski [this message]
2022-07-12 21:54 ` Rob Herring
2022-07-06 9:04 ` [PATCH v8 26/33] clk: rk3399: use proper crypto0 name Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 27/33] arm64: dts: rockchip: add rk3328 crypto node Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 28/33] arm64: dts: rockchip: rk3399: add " Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 29/33] crypto: rockchip: store crypto_info in request context Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 30/33] crypto: rockchip: Check for clocks numbers and their frequencies Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 31/33] crypto: rockchip: rk_ahash_reg_init use crypto_info from parameter Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 32/33] crypto: rockchip: permit to have more than one reset Corentin Labbe
2022-07-06 9:04 ` [PATCH v8 33/33] crypto: rockchip: Add support for RK3399 Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6ab024a-582f-45b0-7d26-94a85858c761@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=heiko@sntech.de \
--cc=herbert@gondor.apana.org.au \
--cc=john@metanate.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).