From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, daniel.lezcano@linaro.org,
tglx@linutronix.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
mikelley@microsoft.com, ssengar@microsoft.com
Subject: Re: [PATCH 4/4] dt-bindings: hv: Add dt-bindings for VMBus
Date: Fri, 20 Jan 2023 12:43:40 +0100 [thread overview]
Message-ID: <f6b80686-d8bc-9c7b-205c-635d4e681f50@linaro.org> (raw)
In-Reply-To: <20230117155258.GA14857@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On 17/01/2023 16:52, Saurabh Singh Sengar wrote:
> On Tue, Jan 17, 2023 at 04:41:22PM +0100, Krzysztof Kozlowski wrote:
>> On 17/01/2023 16:13, Saurabh Singh Sengar wrote:
>>> On Mon, Jan 16, 2023 at 07:55:13PM +0100, Krzysztof Kozlowski wrote:
>>>> On 16/01/2023 17:48, Saurabh Sengar wrote:
>>>>> Add dt-bindings for Hyper-V VMBus
>>>>>
>>>>> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>>>>> ---
>>>>> .../devicetree/bindings/hv/msft,vmbus.yaml | 34 ++++++++++++++++++++++
>>>>
>>>> Also, there is no "hv" hardware, so that's not correct location. If your
>>>> bindings describe firmware, this should go to firmware. Otherwise, this
>>>> does not look like suitable for DT. We do not describe software stuff in DT.
>>>
>>> VMBus is a virtual device this is simmilar to virtio. I can rename this folder to vmbus.
>>>
>>
>> Then virtio directory. The directories are per subsystems (hardware
>> classes).
>
> Apologies if I was not clear, I meant to say this is a device conceptually
> similar to virtio. But this driver has nothing to do with virtio, we should
Bindings are for hardware, not drivers, so if the device serves the same
purpose, it's driver differences do not matter.
> be creating a new folder for it OR I am fine moving it under bus if that's
> okay.
Since you do not have children here, it's not really a bus to fit under
bus directory...
Probably this should go together with virtio bindings to dedicated
hypervisor interfaces directory. We do not create directories for
specific solutions (implementations) with only one or few bindings.
Directories are for entire classes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-20 11:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 16:48 [PATCH 0/4] Device tree support for Hyper-V VMBus driver Saurabh Sengar
2023-01-16 16:48 ` [PATCH 1/4] drivers/clocksource/hyper-v: non ACPI support in hyperv clock Saurabh Sengar
2023-01-16 16:48 ` [PATCH 2/4] Drivers: hv: allow non ACPI compilation for hv_is_hibernation_supported Saurabh Sengar
2023-01-16 16:48 ` [PATCH 3/4] Drivers: hv: vmbus: Device Tree support Saurabh Sengar
2023-01-16 18:48 ` Krzysztof Kozlowski
2023-01-17 15:32 ` Saurabh Singh Sengar
2023-02-01 9:03 ` Saurabh Singh Sengar
2023-01-17 14:20 ` Rob Herring
2023-01-16 16:48 ` [PATCH 4/4] dt-bindings: hv: Add dt-bindings for VMBus Saurabh Sengar
2023-01-16 18:53 ` Krzysztof Kozlowski
2023-02-01 10:53 ` Saurabh Singh Sengar
2023-01-16 18:55 ` Krzysztof Kozlowski
2023-01-17 15:13 ` Saurabh Singh Sengar
2023-01-17 15:41 ` Krzysztof Kozlowski
2023-01-17 15:52 ` Saurabh Singh Sengar
2023-01-20 11:43 ` Krzysztof Kozlowski [this message]
2023-01-20 12:51 ` Saurabh Singh Sengar
2023-01-21 20:28 ` Krzysztof Kozlowski
2023-01-17 1:17 ` Rob Herring
2023-01-17 14:35 ` [PATCH 0/4] Device tree support for Hyper-V VMBus driver Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6b80686-d8bc-9c7b-205c-635d4e681f50@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=decui@microsoft.com \
--cc=devicetree@vger.kernel.org \
--cc=haiyangz@microsoft.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=robh+dt@kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=ssengar@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).