From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99DD9C04FDE for ; Mon, 12 Dec 2022 09:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231954AbiLLJZN (ORCPT ); Mon, 12 Dec 2022 04:25:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231897AbiLLJYi (ORCPT ); Mon, 12 Dec 2022 04:24:38 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8367F6329 for ; Mon, 12 Dec 2022 01:24:36 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id p36so17502053lfa.12 for ; Mon, 12 Dec 2022 01:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EznmZZW413d4IOuEq8wYFCNmDT9PHojOCYMBYHp2g5E=; b=IBh7ouhLXENe9SRGockZaGE5/s0f44opfNysFmKnHl3Uqq0BVOP27M8fW5se2eFjC7 noCETxHcn5k59zOl1F2mY7QexyrEbKGWC8MW5ZzUX2SGAVBbNvlHE9cXwOlHQxn/ikNK 53UbqzOSs80qESQXB01royoiPdSmTxHbSZsOYd/EhIjk/TCZj3vgA3xcDmrs0XC8wMpQ QOQvnvDXx/XXHYLBROLmANR285Up6VXFVnAQA0oQKD8OUzpKUDqreMVympvF84cPP9qa 42FHAGL4zxVgYLyFamzR7M8gUY5LRi/crda8VgjKTYMQt1uSQdU4e1pvPYjNeyKitUSR IvWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EznmZZW413d4IOuEq8wYFCNmDT9PHojOCYMBYHp2g5E=; b=nqZqJoSexbgjGU/NgZ+Rv13ctHw4hprCw8VrHlYW0/bHNx+4WHFXoJoyrwJ9/cZTzx iNccv/bP7R9e2+CnSiAa8S9YWa+Gmpmb+kTqhGy0UZ768MppDt5Cc8zspk4heFrVIhvh l8XXhB50KV2pk+/d5v1zuViH82g2s5e/qIm45gpT6P0XkHPxXmAU5dy2UoUWlMjm+yGz +106j/gkPNlIjLe+wYXtRucdtrwyYqp3DdiTzLofiGflynj9c9NkNnQ3Ks4yfgbziZtu 0PdQ6AyFEmWTb5LSdObHF4dLBIrY/dqd8hWq44thqdEjp06FP8oersMtgwejuoOJtKy6 eTiA== X-Gm-Message-State: ANoB5pnBePAwsOt05H5Slr8TX4Mh+SYXYMdSjW4JpgDUpqlz8kqEqPfP lbXL9WjxzMaq4uX0/r5GvEftwQ== X-Google-Smtp-Source: AA0mqf4jzGpnGv9kfjsXX4or7HmtRTdueSOnKS/rrmLlRNaoMtcN69rtZq1FrmlYXcUiEgSabdgr4Q== X-Received: by 2002:a05:6512:2613:b0:4b4:e14a:ec80 with SMTP id bt19-20020a056512261300b004b4e14aec80mr5323580lfb.44.1670837074921; Mon, 12 Dec 2022 01:24:34 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e11-20020a05651236cb00b004b5241dc8cfsm1584986lfs.10.2022.12.12.01.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 01:24:34 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 10:24:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Content-Language: en-US To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> <77246ee3-8ff5-1049-6b2a-d8925bc87b33@linaro.org> <4522aa1d-99fd-66ad-70bb-d39d9f5ca878@linaro.org> <2cf2eae9-9f32-05c5-c802-1d8cec9b4802@linaro.org> <6df8fc01-9fa1-d63d-25fb-ffa6683f4cb6@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <6df8fc01-9fa1-d63d-25fb-ffa6683f4cb6@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/12/2022 10:18, Konrad Dybcio wrote: > > > On 12.12.2022 10:17, Krzysztof Kozlowski wrote: >> On 12/12/2022 10:15, Konrad Dybcio wrote: >>>>>> + >>>>>> + qup_opp_table: opp-table-qup { >>>>>> + compatible = "operating-points-v2"; >>>>>> + >>>>>> + opp-75000000 { >>>>>> + opp-hz = /bits/ 64 <75000000>; >>>>>> + required-opps = <&rpmhpd_opp_low_svs>; >>>>>> + }; >>>>>> + >>>>>> + opp-100000000 { >>>>>> + opp-hz = /bits/ 64 <100000000>; >>>>>> + required-opps = <&rpmhpd_opp_svs>; >>>>>> + }; >>>>>> + >>>>>> + opp-128000000 { >>>>>> + opp-hz = /bits/ 64 <128000000>; >>>>>> + required-opps = <&rpmhpd_opp_nom>; >>>>>> + }; >>>>>> + }; >>>>>> + >>>>>> memory@80000000 { >>>>> Sidenote: memory@ should be moved above opp-*, alphabetically >>>>> >>>>> For this: >>>>> >>>>> Reviewed-by: Konrad Dybcio >>>> >>>> You sure? Because before there is already opp for cpu... >>> Which are called opp-table-cpuN and not cpuN-opp-table, 'm' comes >>> before 'o'. >> >> So you want to have broken order? >> opp-table-cpu >> memory >> opp-table-qup >> ? >> >> They are at least all together in my patch. > No, I meant: > > memory > opp-table-cpu > opp-table-qup OK, I'll correct the opp-table-cpu/memory order in separate patch. Best regards, Krzysztof