From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFC62BE65F for ; Mon, 22 Dec 2025 13:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766408811; cv=none; b=GLw1twqezAzZ9nfZJBGUvASvg4Vpep9mnFMkHtMGt5FyrXSTw8Z7P106LLV6DcTjMK08ovWTjhlxFZePURGcU8VGpy/9GGLpd7wUQQ9u/nNWIKr/kTEjM3Gai+EZeV09K3mmzs1Rk6Ehbbnfqnr58dKOCYQtAZ86Dpy38ZYLhiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766408811; c=relaxed/simple; bh=wv23DNsmsWzJoqwPtzDiDiysbtjWgZAM6vtUwbCcQwA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AKqCvN9Wd6Vd9OSIpwc+8gbq20SslbfBasvficRh5huE4utCRBVYQxVT3iVwihJxNWvKfwsE2RXkVLqxeWIPaOMOAG0BwoqyyO2luuF2ewLjEeNKxKsfK7xgN1lpMaLBpxVl5xh44JeXSdUhmofPqTJCB072AeqrmET9e8fOWDE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=g436c2Np; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YvD5N6k5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="g436c2Np"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YvD5N6k5" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BMBKSV81783581 for ; Mon, 22 Dec 2025 13:06:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Rl34VUSIcLKGSTcgfDKK7LNhN6XEgT4eoWUw45WEru4=; b=g436c2Np0AohmjmX W3NF26YkDIeY7QFDA40v2H/XS2cpwspk+DIYDXnNsBE4heNkzwIx8H8Ct6ikcz8Y Ok4RLf/C7vOywr4L2qX3FMQI2GZOXaD3Zyg1FDWfGKhiBmz/ZRhihEpBjymjwYgO ZwC4tbJDcTaOhBcI1Ry+PWtyzMb8dgDA2jkRqrU/ESWapuSQ5MwdK/fxw3aAwlwZ j8OD34SXDYnqeQWPELQUK8GEZ1/xGpn+sRgzcjLsRJ/BEfhMxU6NSU0jVFXkpggD fLx6EjTQTiWTpNwEY35EgmOZKDXFzPByyBf7gkl5cA7NpGcDPu2wQEQ/kJxAd9TK 00vWhw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mtqn2s3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 13:06:47 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0f0c7a06eso77080685ad.2 for ; Mon, 22 Dec 2025 05:06:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766408806; x=1767013606; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rl34VUSIcLKGSTcgfDKK7LNhN6XEgT4eoWUw45WEru4=; b=YvD5N6k55QtlCs1rAjdtuDk9TuX8bpTZCmSSxB2NZTFFMdi6C7rFTCGyd+3wNFd4/L ygmNKmapvXhFUv6VnCavGRlcmfQ7nC6FSD4jRc0VVVDYU+HEanXHBJAFZpytmcxGfrjP ZMiBMNWaYSs/BEhWOP4EgLAegqOkzohU2ZmS/fYczi1cxeoG7FeputQfffb3XMNJOLYD mF4s6qpqEiCB513H0JNQZIdemYhP8vRUI+I8AAgJyuJuhsKOJ934SE9mrNNOezS4/VqT SE7m1291zJbsXluq0djGIeDDAEp5BlJEwqTKI/0KaLvI0YSr92ZziW5bJMauYgtLpe9L xpPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766408806; x=1767013606; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rl34VUSIcLKGSTcgfDKK7LNhN6XEgT4eoWUw45WEru4=; b=tTfdwy2pfj64P4e3uCI+GfXQbHlWK7DiHQ6sTDJA5Irg6RlfB/SUf45aQKPUAwjTGk VRcriBJ7f3rgsfqS1SPoMLpFuQyy/QnwEqcb4dYIWY0wg+kZuR6vvwP3bGYzFhsQ9PMm 0jKsC3ncAp7cu8E2AahlhYQ/i7Qn0fNLVN46SZhe3mmgyJJOhGmGRT2HUo+HzM8EUQyI BnyYb01IzoOqVNDcFIs2LVhTebFmecUz98vuv/+KDOQ4ILEKW4NxyK4+Szvv8BiwTD4H cJMOD10DLyUmfxhy/t9Bjx/F2CDAgf7quFYNInMtqWCaR/KzM9ZvUGmf2R3bOPZXqTU/ AaNw== X-Forwarded-Encrypted: i=1; AJvYcCU1R3QNVcBUpEUlcIWBUO5MFfpWNl4Clo//T5kqlfaVlaF7OhFnhRjhLKns3xL6w354WRKINLFS8IvV@vger.kernel.org X-Gm-Message-State: AOJu0YxO6j/cYqkikcbTXo1mHwW7xagYSZPu/wEva+tDPkGy60cp6cGe 2yFT+ZQXGtF99UO3PXP5VFZm1R7QMFJ6XT0zkk3HH13Vb12phSq0H/eJB0Hlp/QoH0XBuB/twwL hXK+VzwrA6QLB+V/+J69IwaLgyrIYyZAwJP1AT/8yQCwwAnps6r41R4/a3XxEdGi3 X-Gm-Gg: AY/fxX5JfzYHuJUJDRiHALkJS8LV3bLNL5I8sGr9KXunuGFdRioqWBuk3GaTtIFwJ3D OhiNjqQi04WzRdD4x2ErhaQd00hvZP7LSRTA2GjIgy6Mg8CHND4dq6CezyVWn03tSyjePyNCU1C vYvICBYKa4DcyDPEy+xRC1gAmgMw1ZGeUpHiaQIHPUg5/YiGPsEsgMMYJAlU0WcQxwm+ygPcaFb YDzPSkSRtz/wgYXsMeTIG4DywRupsE6xJb44ACHuNtxnaiBBWsYX4Q6UZGXhZsbRukH1dCue+/F toemUPmz7cK3emBaDjCPR6cIje8PncaqeWMl4Avtt69Lc6VYt3HcQv8IYUDeQCgEURsuopIM5R0 JaXz+OpBOQqITnanuw/uOk7kmpXBazvO5qKBfmaNeVg== X-Received: by 2002:a17:902:ccd1:b0:2a2:f465:1273 with SMTP id d9443c01a7336-2a2f4651332mr99434255ad.35.1766408805896; Mon, 22 Dec 2025 05:06:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlbxx3zSYC7hX0CsS0/1ozD2P9MFWi8YNJtWnOe1tHF2S4inDEMsj0XZcm7mX2MOc53RRZRA== X-Received: by 2002:a17:902:ccd1:b0:2a2:f465:1273 with SMTP id d9443c01a7336-2a2f4651332mr99433985ad.35.1766408805432; Mon, 22 Dec 2025 05:06:45 -0800 (PST) Received: from [10.217.217.28] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a2f3d6ec60sm96922405ad.86.2025.12.22.05.06.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 05:06:45 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2025 18:36:39 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] dt-bindings: leds: leds-qcom-lpg: Add support for PMH0101 PWM To: Krzysztof Kozlowski Cc: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Fenglin Wu , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, aiqun.yu@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, jingyi.wang@oss.qualcomm.com References: <20251215-knp-pmic-leds-v3-0-5e583f68b0e5@oss.qualcomm.com> <20251215-knp-pmic-leds-v3-1-5e583f68b0e5@oss.qualcomm.com> <20251217-quiet-wandering-gaur-c9c6fe@quoll> Content-Language: en-US From: Jishnu Prakash In-Reply-To: <20251217-quiet-wandering-gaur-c9c6fe@quoll> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: Z1W0dtBwF_Y2eb8NJWsgc30PYbf99-6g X-Authority-Analysis: v=2.4 cv=dPWrWeZb c=1 sm=1 tr=0 ts=69494267 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=g5AuMlRjdp1IwKd9_dYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: Z1W0dtBwF_Y2eb8NJWsgc30PYbf99-6g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDExOSBTYWx0ZWRfX0hXYlkSJIuhi VWdGKnvdXwdE9qbppv/TgoGSW6+I0HeuLoag9iV1IyVWeYDaq5pirLTr2ouWbK6zLn16jn7sWsk DDj0lIogKQKk5sD8W2dvbF1SjSDyAww/dXsZdEbK/w2CoTyguFcTGf1SrqY7n2wSfSu00n0KD51 wYlP2LFlucxxAme9MSTiLXC24BmqhWMW5pu8ETBCqQw7OpMsCdpPn2EKfC8RXhrNr81GcCpjP6U mLhZXyjySKnZbSt3iNiwNviy9znr1ajYcwA/8DEn8bOiZFbvfAYIBzGFsaEyPrA9oeUQ3bcBXdN +j9oU2TBT6By4bjxRnjHTi2HK/fnsVjgnvQx4HTKXLeSDhval6pwTpYvslv/1JgQR9GBNenKH8h t3tYZ/A609OAOhArWOMD/pfdkzjmw8crWncTHIpjwUvDnV7Tknp5lnMfT+2P046BDktnfx1vBEJ tNHpiLl6an/76rVRhtA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-22_01,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220119 Hi Krzysztof, On 12/17/2025 1:45 PM, Krzysztof Kozlowski wrote: > On Mon, Dec 15, 2025 at 04:41:04PM +0530, Jishnu Prakash wrote: >> Add support for PMH0101 PWM modules which are compatible with the PM8350c >> PWM modules. >> >> Signed-off-by: Jingyi Wang >> Signed-off-by: Jishnu Prakash >> --- >> Documentation/devicetree/bindings/leds/leds-qcom-lpg.yaml | 1 + >> 1 file changed, 1 insertion(+) > > So how many nvmem entries it has? You need to define it in schema. > PMH0101 PWM has 2 nvmem entries, the same as PM8350C. But I see that PM8550 PWM was earlier added under the "if:then" condition for the number of nvmem entries and you made this change which removed that line: https://lore.kernel.org/all/20240226073713.19045-1-krzysztof.kozlowski@linaro.org/ dt-bindings: leds: qcom-lpg: Drop redundant qcom,pm8550-pwm in if:then: "qcom,pm8550-pwm" is compatible with "qcom,pm8350c-pwm" (latter used as fallback), thus it is enough for the "if:then:" clause to check for the presence of the fallback "qcom,pm8350c-pwm". PMH0101 PWM would be the same as it also has PM8350C PWM as fallback. Do you prefer that I add it or not? Thanks, Jishnu > Best regards, > Krzysztof >