From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16230CCA47B for ; Tue, 5 Jul 2022 10:19:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231871AbiGEKTj (ORCPT ); Tue, 5 Jul 2022 06:19:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbiGEKTi (ORCPT ); Tue, 5 Jul 2022 06:19:38 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0161913FB9 for ; Tue, 5 Jul 2022 03:19:37 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id z21so19683332lfb.12 for ; Tue, 05 Jul 2022 03:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7ltLTaBEV4Dndg/PZxmASrNkQw7/tHT8uBCcJkojjNo=; b=sshcdqW44eA9XhkENF4BsPVKcelBUpolYOWfgzC458pv/AsvxQSgJYyMapsgffJtas VutA2/jow5ZMwCG/WJX22xI+iaJOamCPkthvcHYRzzFxS7w3OVnLGSu4BJ7adk9QHIpO YYWiUI85XJyCdpwE7ytHyXrLT6DrS4+IkG8/0czlhbyy98KlZVSKMkoTbT2IsErFfnrW lDfF6ks7GaIQGmmb+/O5C/fqHBTZd2iDq/pUGJ+I04zgRpnV1czETUBhbleR0nJjkvky m13j2Zw+glqkyLvmuYtBni7C52LLIfBzG8o7gISUjCagIKzWRRjO7cPgYM/cGbaA5ULh rq5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7ltLTaBEV4Dndg/PZxmASrNkQw7/tHT8uBCcJkojjNo=; b=NmzOLE8QKwhpSMgB9Xi6BIqW9x7xPcmCjho8Fl01o8JriK/ZdSR0S573/QLGPgWShT d4EyZ2xTsVrvjBEXy+IuOCvUF1zJbpy9RImDM6IduU2UsYNXbcPxX0mG8Rel+Dspmtpw n8UEjf3yIDG7D7BXrFjOhFrOcriyYWpBHH/0BxpQ4oefBX/Qk4lhnYfhavitXEZ3E7j5 6S3AiqAiSF+/N3uLPFjYbJv2mHQiBETCgsu+eeNLADYvE0zNHIOzb/1pU7nzA/ezpE9K MGjz81h4Vjw/MwX0vb+IAx0WEsDlrfK5fnxLZq4LLABXAD+YQ2raiuzQBP5aYT3NeOCY l7rw== X-Gm-Message-State: AJIora/myz3MFnxVbllJIW/tr10cSNhjmNvj782DmOhSBQEg36HY1ktL XES32At45AaZ1FKsCJOwke06BA== X-Google-Smtp-Source: AGRyM1ubhhSgV3Tz/xKqrayJWFA5svm/yrJxl4CpDllXR/27n6qEPxHLci9PU+ox5DFVjkhsy7Jycw== X-Received: by 2002:a05:6512:2207:b0:47f:70b3:52d with SMTP id h7-20020a056512220700b0047f70b3052dmr21424409lfu.174.1657016375352; Tue, 05 Jul 2022 03:19:35 -0700 (PDT) Received: from [192.168.1.52] ([84.20.121.239]) by smtp.gmail.com with ESMTPSA id 17-20020a2eb951000000b00253bc47c202sm5528776ljs.59.2022.07.05.03.19.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 03:19:34 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 12:19:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 20/43] dt-bindings: phy: qcom,qmp: split out UFS PHY binding Content-Language: en-US To: Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705094239.17174-1-johan+linaro@kernel.org> <20220705094239.17174-21-johan+linaro@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220705094239.17174-21-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2022 11:42, Johan Hovold wrote: > The QMP PHY DT schema is getting unwieldy. Break out the UFS PHY > binding in a separate file. > > Signed-off-by: Johan Hovold > --- > .../devicetree/bindings/phy/qcom,qmp-phy.yaml | 65 -------- > .../bindings/phy/qcom,qmp-ufs-phy.yaml | 149 ++++++++++++++++++ > 2 files changed, 149 insertions(+), 65 deletions(-) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > index f416a1a53a3f..04c24f8e4526 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > @@ -19,32 +19,21 @@ properties: > enum: > - qcom,ipq6018-qmp-usb3-phy > - qcom,ipq8074-qmp-usb3-phy > - - qcom,msm8996-qmp-ufs-phy > - qcom,msm8996-qmp-usb3-phy > - - qcom,msm8998-qmp-ufs-phy > - qcom,msm8998-qmp-usb3-phy > - qcom,qcm2290-qmp-usb3-phy > - qcom,sc7180-qmp-usb3-phy > - - qcom,sc8180x-qmp-ufs-phy > - qcom,sc8180x-qmp-usb3-phy > - - qcom,sc8280xp-qmp-ufs-phy > - - qcom,sdm845-qmp-ufs-phy > - qcom,sdm845-qmp-usb3-phy > - qcom,sdm845-qmp-usb3-uni-phy > - qcom,sdx55-qmp-usb3-uni-phy > - qcom,sdx65-qmp-usb3-uni-phy > - - qcom,sm6115-qmp-ufs-phy > - - qcom,sm6350-qmp-ufs-phy > - - qcom,sm8150-qmp-ufs-phy > - qcom,sm8150-qmp-usb3-phy > - qcom,sm8150-qmp-usb3-uni-phy > - - qcom,sm8250-qmp-ufs-phy > - qcom,sm8250-qmp-usb3-phy > - qcom,sm8250-qmp-usb3-uni-phy > - - qcom,sm8350-qmp-ufs-phy > - qcom,sm8350-qmp-usb3-phy > - qcom,sm8350-qmp-usb3-uni-phy > - - qcom,sm8450-qmp-ufs-phy > - qcom,sm8450-qmp-usb3-phy > > reg: > @@ -202,60 +191,6 @@ allOf: > required: > - vdda-phy-supply > - vdda-pll-supply > - - if: > - properties: > - compatible: > - contains: > - enum: > - - qcom,msm8996-qmp-ufs-phy > - then: > - properties: > - clocks: > - items: > - - description: 19.2 MHz ref clock. > - clock-names: > - items: > - - const: ref > - resets: > - items: > - - description: PHY reset in the UFS controller. > - reset-names: > - items: > - - const: ufsphy > - required: > - - vdda-phy-supply > - - vdda-pll-supply > - - if: > - properties: > - compatible: > - contains: > - enum: > - - qcom,msm8998-qmp-ufs-phy > - - qcom,sc8180x-qmp-ufs-phy > - - qcom,sc8280xp-qmp-ufs-phy > - - qcom,sdm845-qmp-ufs-phy > - - qcom,sm6350-qmp-ufs-phy > - - qcom,sm8150-qmp-ufs-phy > - - qcom,sm8250-qmp-ufs-phy > - then: > - properties: > - clocks: > - items: > - - description: 19.2 MHz ref clock. > - - description: PHY reference aux clock. > - clock-names: > - items: > - - const: ref > - - const: ref_aux > - resets: > - items: > - - description: PHY reset in the UFS controller. > - reset-names: > - items: > - - const: ufsphy > - required: > - - vdda-phy-supply > - - vdda-pll-supply > - if: > properties: > compatible: > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml > new file mode 100644 > index 000000000000..4471f1b4fb7a > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-ufs-phy.yaml > @@ -0,0 +1,149 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/qcom,qmp-ufs-phy.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + All previous comments apply. Best regards, Krzysztof