From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Timothy Pearson <tpearson@raptorengineering.com>, robh <robh@kernel.org>
Cc: devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lee Jones <lee@kernel.org>,
Georgy Yakovlev <Georgy.Yakovlev@sony.com>,
Shawn Anastasio <sanastasio@raptorengineering.com>
Subject: Re: [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld
Date: Mon, 20 Oct 2025 17:58:40 +0200 [thread overview]
Message-ID: <f6f9cfc9-b26e-4358-8781-6ce75075d13f@linaro.org> (raw)
In-Reply-To: <924260297.1801829.1760974499327.JavaMail.zimbra@raptorengineeringinc.com>
On 20/10/2025 17:34, Timothy Pearson wrote:
>>> + watchdog:
>>> + type: object
>>> + description: Cronos Platform Watchdog Timer
>>> +
>>> + allOf:
>>> + - $ref: watchdog.yaml#
>>> +
>>> + properties:
>>> + compatible:
>>> + const: sony,cronos-watchdog
>>
>> There's no need for a child node here. 'timeout-sec' can just go in the
>> parent node.
>
> Could you elaborate on this please? As far as I can tell we ref watchdog.yaml and need some kind of compatible string, so why would I break out timeout-sec directly here?
Please look where the comment was placed. Under $ref? No. Under this
compatible. $ref goes to the parent, obviously.
You do not need kind of compatible string. Parent already has one. You
do not need compatible strings at all to instantiate Linux drivers.
That's pretty common pattern for most of MFD-like devices, plenty of
examples in the kernel.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-20 15:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 18:17 [PATCH 1/4] dt-bindings: mfd: Add sony,cronos-cpld Timothy Pearson
2025-09-26 21:39 ` Rob Herring (Arm)
2025-09-29 14:11 ` Rob Herring
2025-10-20 15:34 ` Timothy Pearson
2025-10-20 15:58 ` Krzysztof Kozlowski [this message]
2025-10-20 16:01 ` Timothy Pearson
2025-10-20 16:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6f9cfc9-b26e-4358-8781-6ce75075d13f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Georgy.Yakovlev@sony.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sanastasio@raptorengineering.com \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).