From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F92EC433FE for ; Tue, 29 Nov 2022 08:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230146AbiK2IPH (ORCPT ); Tue, 29 Nov 2022 03:15:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbiK2IPE (ORCPT ); Tue, 29 Nov 2022 03:15:04 -0500 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C80B45A27 for ; Tue, 29 Nov 2022 00:15:03 -0800 (PST) Received: by mail-wr1-x431.google.com with SMTP id q7so19892492wrr.8 for ; Tue, 29 Nov 2022 00:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+tGnGmsd8SAIBQy5l4bYfSlkJXwSsNSEiUXV0JrZ7G4=; b=KTldDQLc2tfmlmwHTPtlzERRJy+/jbYo9EsHIxk7O1mjZbOw9VlAAiNseOhv+Le/EY 4ZiEDc1QvJwrXaMN6eFvxqerNsnilHxvYyrnTSMXoCXQXWCPxQKf25zugw93LCUDO5aa 4y3Nd84D1+RvRWa6FCu8bT7RsBUZ1MNfy19ToCyxmF+kg59jjg4efRoZHY6F+te3aCe1 zs+dBujwbjothGnT2zaJGuKkewhnmrNOePYr5sLSz1BX4weqKuRwLldukQ/T1+wuXGGv ADbztyNZqjIHoGHQtVI6FXqyrZZRqhmc6Azgbd+G2sLa3JZh4glG7ZPJpZRRfwAWYI8t AN/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+tGnGmsd8SAIBQy5l4bYfSlkJXwSsNSEiUXV0JrZ7G4=; b=ItF6QUocMeRQzegcticBpj559oAF/EUJ+zS//kBeMmG/BP4KnEwXBtgC4HTMD3MGKI SvtTjQsPN6gG9ciu91T60aN6UCs/bucWddtFJp7ePvL2/hK9YEppHuGuKrhpBxsG5HMd f2Lpw0yPCi5uoNzJqdcMNUKmh/2gf0jxF7ix2E6IxK/WqmkW3tNvn4azJPjcMQFrXJfW dEpzHpeliui9Fu0s4JFABJzSjmU4SwM4UbviGUvlG0ySW/4X9edBltsV7RGTjWkJWK1D 60GSUJVU23bp6HUp9AUxiEBHnJCqCAvNsb/38Lm5fl8QF3u8feY1BPNrJZC+gnp9zqJn P4Gg== X-Gm-Message-State: ANoB5pmAv6FNiGgXigsfxMOdZXt22waoW8/ZiUhB+dW1J7ubkDBYXD86 tmNE++E/kKTaQ1wDe6opksIrpA== X-Google-Smtp-Source: AA0mqf4cGPQC7b3hpyexGmaRKYiejcRHPv4RznEDcAyvSpiAKZOUZqQXpPilrMkBaqhOfPiP9RWS7w== X-Received: by 2002:a5d:6503:0:b0:22e:35e8:382d with SMTP id x3-20020a5d6503000000b0022e35e8382dmr33962143wru.475.1669709702171; Tue, 29 Nov 2022 00:15:02 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2? ([2a01:e0a:982:cbb0:2f85:a28c:5df7:9cd2]) by smtp.gmail.com with ESMTPSA id n21-20020a05600c3b9500b003b4c979e6bcsm1242431wms.10.2022.11.29.00.15.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:15:01 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 09:15:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property Content-Language: en-US To: Linus Walleij Cc: Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Linux Kernel Mailing List , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, "linux-gpio@vger.kernel.org" References: <20221123152001.694546-1-abel.vesa@linaro.org> <20221123152001.694546-3-abel.vesa@linaro.org> <8602cacd-f552-e843-5c17-681b099069a3@linaro.org> Organization: Linaro Developer Services In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Linus, On 26/11/2022 22:53, Linus Walleij wrote: > On Fri, Nov 25, 2022 at 1:40 PM wrote: > >> As I understood, it enables an "I2C resistor" on the pin, removing the need >> of an external pull-up resistor on the line. >> >> I assume the classical pull-up bias is not strong enough to replace an actual >> resistor on the PCB. > > In that case I think this should be an argument to bias-pull-up like: > > bias-pull-up = <360000>; > > Nominally the pull up is in ohms: > > bias-pull-up: > oneOf: > - type: boolean > - $ref: /schemas/types.yaml#/definitions/uint32 > description: pull up the pin. Takes as optional argument on hardware > supporting it the pull strength in Ohm. > > Then the driver can choose to shunt in this extra I2C resistance > from the resistance passed as argument. So no special property > is needed, provided you can get an idea about the resistance > provided here. I like this alternative, I'll try to figure out if we can find a value to match against. Thanks, Neil > > Yours, > Linus Walleij