* [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks. [not found] <1656062391-14567-1-git-send-email-quic_krichai@quicinc.com> @ 2022-06-24 9:19 ` Krishna chaitanya chundru 2022-06-24 15:23 ` Krzysztof Kozlowski 2022-06-24 16:58 ` Bjorn Helgaas 2022-06-24 9:19 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Krishna chaitanya chundru [not found] ` <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com> 2 siblings, 2 replies; 14+ messages in thread From: Krishna chaitanya chundru @ 2022-06-24 9:19 UTC (permalink / raw) To: helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Krishna chaitanya chundru, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add missing clocks. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 0b69b12..313b981 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -438,6 +438,8 @@ allOf: - const: slave_q2a # Slave Q2A clock - const: tbu # PCIe TBU clock - const: ddrss_sf_tbu # PCIe SF TBU clock + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock + - const: aggre1 # Aggre NoC PCIe1 AXI clock resets: maxItems: 1 reset-names: -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks. 2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru @ 2022-06-24 15:23 ` Krzysztof Kozlowski 2022-06-24 16:58 ` Bjorn Helgaas 1 sibling, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-06-24 15:23 UTC (permalink / raw) To: Krishna chaitanya chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 24/06/2022 11:19, Krishna chaitanya chundru wrote: > Add missing clocks. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12..313b981 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -438,6 +438,8 @@ allOf: > - const: slave_q2a # Slave Q2A clock > - const: tbu # PCIe TBU clock > - const: ddrss_sf_tbu # PCIe SF TBU clock > + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock > + - const: aggre1 # Aggre NoC PCIe1 AXI clock Hi, This won't work. You need to update other entry. If you test it with `make dtbs_check` you will see the errors. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks. 2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru 2022-06-24 15:23 ` Krzysztof Kozlowski @ 2022-06-24 16:58 ` Bjorn Helgaas 2022-06-28 6:43 ` Krishna Chaitanya Chundru 1 sibling, 1 reply; 14+ messages in thread From: Bjorn Helgaas @ 2022-06-24 16:58 UTC (permalink / raw) To: Krishna chaitanya chundru Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On Fri, Jun 24, 2022 at 02:49:50PM +0530, Krishna chaitanya chundru wrote: > Add missing clocks. When you revise this, please make your subject line match the history: dt-bindings: PCI: qcom: Add schema for sc7280 chipset dt-bindings: PCI: qcom: Specify reg-names explicitly dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms dt-bindings: PCI: qcom: Convert to YAML So your subject line should be something like: dt-bindings: PCI: qcom: Add sc7280 aggre0 and aggre1 clocks Please also include the names of the clocks you're adding in the commit log. This will make the commit log history more specific and useful for future readers. This also applies to the other patches. > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12..313b981 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -438,6 +438,8 @@ allOf: > - const: slave_q2a # Slave Q2A clock > - const: tbu # PCIe TBU clock > - const: ddrss_sf_tbu # PCIe SF TBU clock > + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock > + - const: aggre1 # Aggre NoC PCIe1 AXI clock I assume the stuff after "#" is comment and could thus be made consistent: s/PCIE/PCIe/, is "PCIe1" a typo for "PCIe" or different? Seems like weird/inconsistent capitalization in general ("CENTER"), but if you're matching language in a spec, please do that and ignore my comment :) > resets: > maxItems: 1 > reset-names: > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks. 2022-06-24 16:58 ` Bjorn Helgaas @ 2022-06-28 6:43 ` Krishna Chaitanya Chundru 0 siblings, 0 replies; 14+ messages in thread From: Krishna Chaitanya Chundru @ 2022-06-28 6:43 UTC (permalink / raw) To: Bjorn Helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 6/24/2022 10:28 PM, Bjorn Helgaas wrote: > On Fri, Jun 24, 2022 at 02:49:50PM +0530, Krishna chaitanya chundru wrote: >> Add missing clocks. > When you revise this, please make your subject line match the history: > > dt-bindings: PCI: qcom: Add schema for sc7280 chipset > dt-bindings: PCI: qcom: Specify reg-names explicitly > dt-bindings: PCI: qcom: Do not require resets on msm8996 platforms > dt-bindings: PCI: qcom: Convert to YAML > > So your subject line should be something like: > > dt-bindings: PCI: qcom: Add sc7280 aggre0 and aggre1 clocks > > Please also include the names of the clocks you're adding in the > commit log. This will make the commit log history more specific and > useful for future readers. > > This also applies to the other patches. Thanks Bjorn, I will try to incorporate your comments in the next patch. >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 0b69b12..313b981 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -438,6 +438,8 @@ allOf: >> - const: slave_q2a # Slave Q2A clock >> - const: tbu # PCIe TBU clock >> - const: ddrss_sf_tbu # PCIe SF TBU clock >> + - const: aggre0 # Aggre NoC PCIE CENTER SF AXI clock >> + - const: aggre1 # Aggre NoC PCIe1 AXI clock > I assume the stuff after "#" is comment and could thus be made > consistent: s/PCIE/PCIe/, is "PCIe1" a typo for "PCIe" or different? > Seems like weird/inconsistent capitalization in general ("CENTER"), > but if you're matching language in a spec, please do that and ignore > my comment :) > >> resets: >> maxItems: 1 >> reset-names: >> -- >> 2.7.4 >> ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks [not found] <1656062391-14567-1-git-send-email-quic_krichai@quicinc.com> 2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru @ 2022-06-24 9:19 ` Krishna chaitanya chundru 2022-06-24 15:23 ` Krzysztof Kozlowski [not found] ` <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com> 2 siblings, 1 reply; 14+ messages in thread From: Krishna chaitanya chundru @ 2022-06-24 9:19 UTC (permalink / raw) To: helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Krishna chaitanya chundru, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add missing pcie clocks. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index e66fc67..a5ce095 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2043,6 +2043,8 @@ <&gcc GCC_PCIE_1_SLV_AXI_CLK>, <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, <&gcc GCC_DDRSS_PCIE_SF_CLK>; clock-names = "pipe", @@ -2055,6 +2057,8 @@ "bus_slave", "slave_q2a", "tbu", + "aggre0", + "aggre1", "ddrss_sf_tbu"; assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks 2022-06-24 9:19 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Krishna chaitanya chundru @ 2022-06-24 15:23 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-06-24 15:23 UTC (permalink / raw) To: Krishna chaitanya chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 24/06/2022 11:19, Krishna chaitanya chundru wrote: > Add missing pcie clocks. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > Thank you for your patch. There is something to discuss/improve. > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index e66fc67..a5ce095 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2043,6 +2043,8 @@ > <&gcc GCC_PCIE_1_SLV_AXI_CLK>, > <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, > <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, > <&gcc GCC_DDRSS_PCIE_SF_CLK>; > > clock-names = "pipe", > @@ -2055,6 +2057,8 @@ > "bus_slave", > "slave_q2a", > "tbu", > + "aggre0", > + "aggre1", > "ddrss_sf_tbu"; Unfortunately wrong order. Please test your patches with `make dtbs_check`. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com>]
* [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks [not found] ` <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com> @ 2022-07-01 16:11 ` Krishna chaitanya chundru 2022-07-04 8:24 ` Krzysztof Kozlowski 2022-07-01 16:11 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing " Krishna chaitanya chundru 1 sibling, 1 reply; 14+ messages in thread From: Krishna chaitanya chundru @ 2022-07-01 16:11 UTC (permalink / raw) To: helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Krishna chaitanya chundru, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Adding aggre0 and aggre1 clock entries to PCIe node. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 0b69b12..8f29bdd 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -423,8 +423,8 @@ allOf: then: properties: clocks: - minItems: 11 - maxItems: 11 + minItems: 13 + maxItems: 13 clock-names: items: - const: pipe # PIPE clock @@ -437,6 +437,8 @@ allOf: - const: bus_slave # Slave AXI clock - const: slave_q2a # Slave Q2A clock - const: tbu # PCIe TBU clock + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock + - const: aggre1 # Aggre NoC PCIe1 AXI clock - const: ddrss_sf_tbu # PCIe SF TBU clock resets: maxItems: 1 -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks 2022-07-01 16:11 ` [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks Krishna chaitanya chundru @ 2022-07-04 8:24 ` Krzysztof Kozlowski 2022-07-06 11:55 ` Krishna Chaitanya Chundru 0 siblings, 1 reply; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-07-04 8:24 UTC (permalink / raw) To: Krishna chaitanya chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 01/07/2022 18:11, Krishna chaitanya chundru wrote: > Adding aggre0 and aggre1 clock entries to PCIe node. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 0b69b12..8f29bdd 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -423,8 +423,8 @@ allOf: > then: > properties: > clocks: > - minItems: 11 > - maxItems: 11 > + minItems: 13 > + maxItems: 13 > clock-names: > items: > - const: pipe # PIPE clock > @@ -437,6 +437,8 @@ allOf: > - const: bus_slave # Slave AXI clock > - const: slave_q2a # Slave Q2A clock > - const: tbu # PCIe TBU clock > + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock > + - const: aggre1 # Aggre NoC PCIe1 AXI clock You ignored my comments from v1 - please don't. This is not accepted. Also, please do not send new versions of patchset as reply to some other threads. It's extremely confusing to find it under something else. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks 2022-07-04 8:24 ` Krzysztof Kozlowski @ 2022-07-06 11:55 ` Krishna Chaitanya Chundru 2022-07-06 14:59 ` Krzysztof Kozlowski 0 siblings, 1 reply; 14+ messages in thread From: Krishna Chaitanya Chundru @ 2022-07-06 11:55 UTC (permalink / raw) To: Krzysztof Kozlowski, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 7/4/2022 1:54 PM, Krzysztof Kozlowski wrote: > On 01/07/2022 18:11, Krishna chaitanya chundru wrote: >> Adding aggre0 and aggre1 clock entries to PCIe node. >> >> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >> --- >> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> index 0b69b12..8f29bdd 100644 >> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >> @@ -423,8 +423,8 @@ allOf: >> then: >> properties: >> clocks: >> - minItems: 11 >> - maxItems: 11 >> + minItems: 13 >> + maxItems: 13 >> clock-names: >> items: >> - const: pipe # PIPE clock >> @@ -437,6 +437,8 @@ allOf: >> - const: bus_slave # Slave AXI clock >> - const: slave_q2a # Slave Q2A clock >> - const: tbu # PCIe TBU clock >> + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock >> + - const: aggre1 # Aggre NoC PCIe1 AXI clock > You ignored my comments from v1 - please don't. This is not accepted. > > Also, please do not send new versions of patchset as reply to some other > threads. It's extremely confusing to find it under something else. > > Best regards, > Krzysztof Hi Krzysztof, Sorry for confusion created which replying this patch. The only comment I got from v1 from you is to run make dtbs_check. I ran that command I found the errors and fixed them and I ran the make dtbs_check again before on v2 and made sure there are no errors. Can you please tell me is there any steps I missed. Thanks & Regards, Krishna Chaitanya. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks 2022-07-06 11:55 ` Krishna Chaitanya Chundru @ 2022-07-06 14:59 ` Krzysztof Kozlowski 2022-08-29 17:45 ` Krishna Chaitanya Chundru 0 siblings, 1 reply; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-07-06 14:59 UTC (permalink / raw) To: Krishna Chaitanya Chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 06/07/2022 13:55, Krishna Chaitanya Chundru wrote: > > On 7/4/2022 1:54 PM, Krzysztof Kozlowski wrote: >> On 01/07/2022 18:11, Krishna chaitanya chundru wrote: >>> Adding aggre0 and aggre1 clock entries to PCIe node. >>> >>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> index 0b69b12..8f29bdd 100644 >>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>> @@ -423,8 +423,8 @@ allOf: >>> then: >>> properties: >>> clocks: >>> - minItems: 11 >>> - maxItems: 11 >>> + minItems: 13 >>> + maxItems: 13 >>> clock-names: >>> items: >>> - const: pipe # PIPE clock >>> @@ -437,6 +437,8 @@ allOf: >>> - const: bus_slave # Slave AXI clock >>> - const: slave_q2a # Slave Q2A clock >>> - const: tbu # PCIe TBU clock >>> + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock >>> + - const: aggre1 # Aggre NoC PCIe1 AXI clock >> You ignored my comments from v1 - please don't. This is not accepted. >> >> Also, please do not send new versions of patchset as reply to some other >> threads. It's extremely confusing to find it under something else. >> >> Best regards, >> Krzysztof > Hi > > Krzysztof, > > Sorry for confusion created which replying this patch. > > The only comment I got from v1 from you is to run make dtbs_check. > > I ran that command I found the errors and fixed them and I ran the make dtbs_check again > before on v2 and made sure there are no errors. > > Can you please tell me is there any steps I missed. The comment was: "This won't work. You need to update other entry." and then a conditional: "If you test it with `make dtbs_check` you will see the errors." So let's run it together: /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb: pci@1c08000: clocks: [[42, 55], [42, 56], [41, 0], [39, 0], [42, 50], [42, 52], [42, 53], [42, 57], [42, 58], [42, 177], [42, 178], [42, 8], [42, 21]] is too long From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pci/qcom,pcie.yaml /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb: pci@1c08000: clock-names: ['pipe', 'pipe_mux', 'phy_pipe', 'ref', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'tbu', 'aggre0', 'aggre1', 'ddrss_sf_tbu'] is too long clocks and clock-names can be maximum 12 items, as defined by schema in "properties:" section. You cannot extend it in one place to 13 but leave 12 in other, because both constraints are applicable. If you test it, you will see the errors. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks 2022-07-06 14:59 ` Krzysztof Kozlowski @ 2022-08-29 17:45 ` Krishna Chaitanya Chundru 2022-08-30 6:23 ` Krzysztof Kozlowski 0 siblings, 1 reply; 14+ messages in thread From: Krishna Chaitanya Chundru @ 2022-08-29 17:45 UTC (permalink / raw) To: Krzysztof Kozlowski, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 7/6/2022 8:29 PM, Krzysztof Kozlowski wrote: > On 06/07/2022 13:55, Krishna Chaitanya Chundru wrote: >> On 7/4/2022 1:54 PM, Krzysztof Kozlowski wrote: >>> On 01/07/2022 18:11, Krishna chaitanya chundru wrote: >>>> Adding aggre0 and aggre1 clock entries to PCIe node. >>>> >>>> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 6 ++++-- >>>> 1 file changed, 4 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> index 0b69b12..8f29bdd 100644 >>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml >>>> @@ -423,8 +423,8 @@ allOf: >>>> then: >>>> properties: >>>> clocks: >>>> - minItems: 11 >>>> - maxItems: 11 >>>> + minItems: 13 >>>> + maxItems: 13 >>>> clock-names: >>>> items: >>>> - const: pipe # PIPE clock >>>> @@ -437,6 +437,8 @@ allOf: >>>> - const: bus_slave # Slave AXI clock >>>> - const: slave_q2a # Slave Q2A clock >>>> - const: tbu # PCIe TBU clock >>>> + - const: aggre0 # Aggre NoC PCIe CENTER SF AXI clock >>>> + - const: aggre1 # Aggre NoC PCIe1 AXI clock >>> You ignored my comments from v1 - please don't. This is not accepted. >>> >>> Also, please do not send new versions of patchset as reply to some other >>> threads. It's extremely confusing to find it under something else. >>> >>> Best regards, >>> Krzysztof >> Hi >> >> Krzysztof, >> >> Sorry for confusion created which replying this patch. >> >> The only comment I got from v1 from you is to run make dtbs_check. >> >> I ran that command I found the errors and fixed them and I ran the make dtbs_check again >> before on v2 and made sure there are no errors. >> >> Can you please tell me is there any steps I missed. > The comment was: > "This won't work. You need to update other entry." > > and then a conditional: "If you test it with > `make dtbs_check` you will see the errors." > > So let's run it together: > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb: > pci@1c08000: clocks: [[42, 55], [42, 56], [41, 0], [39, 0], [42, 50], > [42, 52], [42, 53], [42, 57], [42, 58], [42, 177], [42, 178], [42, 8], > [42, 21]] is too long > > From schema: > /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > /home/krzk/dev/linux/linux/out/arch/arm64/boot/dts/qcom/sc7280-idp.dtb: > pci@1c08000: clock-names: ['pipe', 'pipe_mux', 'phy_pipe', 'ref', 'aux', > 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'tbu', 'aggre0', > 'aggre1', 'ddrss_sf_tbu'] is too long > > > clocks and clock-names can be maximum 12 items, as defined by schema in > "properties:" section. You cannot extend it in one place to 13 but leave > 12 in other, because both constraints are applicable. > > If you test it, you will see the errors. > > Best regards, > Krzysztof Hi Krzysztof, Sorry for very late reply. If we increase the common definitions of clocks properties to "13" it is sufficient right. diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 92402f1..c9e268d 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -53,11 +53,11 @@ properties: # Platform constraints are described later. clocks: minItems: 3 - maxItems: 12 + maxItems: 13 clock-names: minItems: 3 - maxItems: 12 + maxItems: 13 resets: Thanks & Regards, Krishna Chaitanya. ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks 2022-08-29 17:45 ` Krishna Chaitanya Chundru @ 2022-08-30 6:23 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-08-30 6:23 UTC (permalink / raw) To: Krishna Chaitanya Chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Bjorn Helgaas, Rob Herring, Krzysztof Kozlowski, Stanimir Varbanov, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 29/08/2022 20:45, Krishna Chaitanya Chundru wrote: > Sorry for very late reply. > > If we increase the common definitions of clocks properties to "13" it is > sufficient right. > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index 92402f1..c9e268d 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -53,11 +53,11 @@ properties: > # Platform constraints are described later. > clocks: > minItems: 3 > - maxItems: 12 > + maxItems: 13 > > clock-names: > minItems: 3 > - maxItems: 12 > + maxItems: 13 > Yes. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks [not found] ` <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com> 2022-07-01 16:11 ` [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks Krishna chaitanya chundru @ 2022-07-01 16:11 ` Krishna chaitanya chundru 2022-07-04 8:24 ` Krzysztof Kozlowski 1 sibling, 1 reply; 14+ messages in thread From: Krishna chaitanya chundru @ 2022-07-01 16:11 UTC (permalink / raw) To: helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Krishna chaitanya chundru, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add missing aggre0, aggre1 clocks to pcie node. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index e66fc67..a5ce095 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -2043,6 +2043,8 @@ <&gcc GCC_PCIE_1_SLV_AXI_CLK>, <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, <&gcc GCC_DDRSS_PCIE_SF_CLK>; clock-names = "pipe", @@ -2055,6 +2057,8 @@ "bus_slave", "slave_q2a", "tbu", + "aggre0", + "aggre1", "ddrss_sf_tbu"; assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing aggre0, aggre1 clocks 2022-07-01 16:11 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing " Krishna chaitanya chundru @ 2022-07-04 8:24 ` Krzysztof Kozlowski 0 siblings, 0 replies; 14+ messages in thread From: Krzysztof Kozlowski @ 2022-07-04 8:24 UTC (permalink / raw) To: Krishna chaitanya chundru, helgaas Cc: linux-pci, linux-arm-msm, linux-kernel, mka, quic_vbadigan, quic_hemantk, quic_nitegupt, quic_skananth, quic_ramkri, manivannan.sadhasivam, swboyd, dmitry.baryshkov, Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On 01/07/2022 18:11, Krishna chaitanya chundru wrote: > Add missing aggre0, aggre1 clocks to pcie node. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index e66fc67..a5ce095 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2043,6 +2043,8 @@ > <&gcc GCC_PCIE_1_SLV_AXI_CLK>, > <&gcc GCC_PCIE_1_SLV_Q2A_AXI_CLK>, > <&gcc GCC_AGGRE_NOC_PCIE_TBU_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_CENTER_SF_AXI_CLK>, > + <&gcc GCC_AGGRE_NOC_PCIE_1_AXI_CLK>, > <&gcc GCC_DDRSS_PCIE_SF_CLK>; Still no. Please respond to comments first. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2022-08-30 6:23 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1656062391-14567-1-git-send-email-quic_krichai@quicinc.com>
2022-06-24 9:19 ` [PATCH v1 2/3] dt-bindings: pci: QCOM sc7280 add missing clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
2022-06-24 16:58 ` Bjorn Helgaas
2022-06-28 6:43 ` Krishna Chaitanya Chundru
2022-06-24 9:19 ` [PATCH v1 3/3] arm64: dts: qcom: sc7280: Add missing pcie clocks Krishna chaitanya chundru
2022-06-24 15:23 ` Krzysztof Kozlowski
[not found] ` <1656691899-21315-1-git-send-email-quic_krichai@quicinc.com>
2022-07-01 16:11 ` [PATCH v2 2/3] dt-bindings: pci: QCOM Adding sc7280 aggre0, aggre1 clocks Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
2022-07-06 11:55 ` Krishna Chaitanya Chundru
2022-07-06 14:59 ` Krzysztof Kozlowski
2022-08-29 17:45 ` Krishna Chaitanya Chundru
2022-08-30 6:23 ` Krzysztof Kozlowski
2022-07-01 16:11 ` [PATCH v2 3/3] arm64: dts: qcom: sc7280: Add missing " Krishna chaitanya chundru
2022-07-04 8:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).