From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bhavya Kapoor <b-kapoor@ti.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, nm@ti.com,
piyali_g@ti.com
Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes
Date: Tue, 8 Nov 2022 19:18:17 +0100 [thread overview]
Message-ID: <f70346da-228e-79d2-7284-6c64cda7eda0@linaro.org> (raw)
In-Reply-To: <20221108073231.35008-1-b-kapoor@ti.com>
On 08/11/2022 08:32, Bhavya Kapoor wrote:
> J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes
> for 8 channel ADCs for J721S2.
>
> Enable ADCs present on J721S2 soc.
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++
> .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++
> 2 files changed, 54 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> index b210cc07c539..de9cb40273be 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
> @@ -429,3 +429,17 @@
> &main_mcan17 {
> status = "disabled";
> };
> +
> +&tscadc0 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> +
> +&tscadc1 {
> + status = "okay";
> + adc {
> + ti,adc-channels = <0 1 2 3 4 5 6 7>;
> + };
> +};
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> index 4d1bfabd1313..47a7a6b500c2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi
> @@ -299,4 +299,44 @@
> ti,cpts-periodic-outputs = <2>;
> };
> };
> +
> + tscadc0: tscadc@40200000 {
Node names should be generic, so "adc"
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-08 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 7:32 [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Bhavya Kapoor
2022-11-08 18:18 ` Krzysztof Kozlowski [this message]
2022-11-09 6:47 ` [EXTERNAL] " Bhavya Kapoor
2022-12-20 9:56 ` Bhavya Kapoor
-- strict thread matches above, loose matches on Subject: below --
2022-11-08 7:32 Bhavya Kapoor
2022-11-08 18:18 ` Krzysztof Kozlowski
2022-12-20 10:12 Bhavya Kapoor
2022-12-20 10:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f70346da-228e-79d2-7284-6c64cda7eda0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=b-kapoor@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=piyali_g@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).