From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6309C433FE for ; Tue, 8 Nov 2022 18:19:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234800AbiKHSTY (ORCPT ); Tue, 8 Nov 2022 13:19:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234798AbiKHSTB (ORCPT ); Tue, 8 Nov 2022 13:19:01 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 236C966C9B for ; Tue, 8 Nov 2022 10:18:20 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id bp15so22303615lfb.13 for ; Tue, 08 Nov 2022 10:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HhsyzOd+JiqoQLFaHc8UXEAL2nKXCxT80Po+9P/JnWs=; b=jLg3rx1c+WJF2MMSClc8UhrWlUyz6Cu8cHNu2CRIlGs8LzIqekez4d+V93lxC4zLmF G+R2TmgH5DTzj+TlJC1SJ5q9UEl66HIYNaU/WXpEPIkyZ+nQCRpAXSQZDIgBp8lyGZBg UKR15rwuyiIRG48Ht5jR4avw3/swKdKOkVaCQ1H6a7/q8jy7ofRv7kP71kDcISLn6RQw 6jKmDUHLgmRlSK0nO0OWeP8jAcOyxqSGlBpDylRpcj1r2JvbA2oiO/d/h/Alh46oRz1V mUyroJTwGsPIlgc3dQU5FPIAVB+K8J98+7oSKsWo0phLaYGtD6ZIG6gA3vf5jO1vgXDo 611g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HhsyzOd+JiqoQLFaHc8UXEAL2nKXCxT80Po+9P/JnWs=; b=w0/m9VIIVqElP6eKu/u9CNgOe2bbFBrYjAMLftzO3w2k+JHVIJHfuUX0iYj6FtHCHV pftbYiOTWKZ/TIP9ACJxQK87iarA4UFkXsjKx3uG7aRByLKKGleq+1foMXJXvuoqEtT6 g19IXy/bFAdCMJTmaDwQDgdh04X3SW9TISRHLZKEjm29mAjzucJ9E9s6tZYQxW/sYGl7 mhMYvyddpgEV3oFAhd7XfOA4oJ/EoeS0gjUm9DSS7aLQlyuUnhw9Nf5PudMDWn01++lP I/vFW9zZbynDjw/CoQOja0ZVbP+jykVkeLdk+xEyS7qiMYPCoJS4mYdUaYp7UIWgBpbZ jnPw== X-Gm-Message-State: ANoB5pksf1B/0yR1Ggb+NoEImg3d5OWhrthyt/g71+xzE1Gd4Bw3chXa 4YOucA0uPyHpIN3Te56P9AdWuQ== X-Google-Smtp-Source: AA0mqf7a210R/c0Mt7ePIfbKQJ1ldqSmYIxYuSUvPwKCwf9s8vAPVy8PH18KaP3uUVF3zxtPVTWxyQ== X-Received: by 2002:a19:911a:0:b0:4b4:106d:9666 with SMTP id t26-20020a19911a000000b004b4106d9666mr1402462lfd.471.1667931498512; Tue, 08 Nov 2022 10:18:18 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id o7-20020a05651205c700b00497a0ea92desm1881138lfo.135.2022.11.08.10.18.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Nov 2022 10:18:17 -0800 (PST) Message-ID: Date: Tue, 8 Nov 2022 19:18:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] arm64: dts: ti: k3-j721s2: Add support for ADC nodes Content-Language: en-US To: Bhavya Kapoor , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, nm@ti.com, piyali_g@ti.com References: <20221108073231.35008-1-b-kapoor@ti.com> From: Krzysztof Kozlowski In-Reply-To: <20221108073231.35008-1-b-kapoor@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/11/2022 08:32, Bhavya Kapoor wrote: > J721S2 has two instances of 8 channel ADCs in MCU domain. Add DT nodes > for 8 channel ADCs for J721S2. > > Enable ADCs present on J721S2 soc. > > Signed-off-by: Bhavya Kapoor > --- > .../dts/ti/k3-j721s2-common-proc-board.dts | 14 +++++++ > .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi | 40 +++++++++++++++++++ > 2 files changed, 54 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > index b210cc07c539..de9cb40273be 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts > @@ -429,3 +429,17 @@ > &main_mcan17 { > status = "disabled"; > }; > + > +&tscadc0 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > + > +&tscadc1 { > + status = "okay"; > + adc { > + ti,adc-channels = <0 1 2 3 4 5 6 7>; > + }; > +}; > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > index 4d1bfabd1313..47a7a6b500c2 100644 > --- a/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi > @@ -299,4 +299,44 @@ > ti,cpts-periodic-outputs = <2>; > }; > }; > + > + tscadc0: tscadc@40200000 { Node names should be generic, so "adc" https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof