From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FF45C7EE2E for ; Mon, 8 May 2023 10:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234842AbjEHKex (ORCPT ); Mon, 8 May 2023 06:34:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234742AbjEHKeU (ORCPT ); Mon, 8 May 2023 06:34:20 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A84B27866 for ; Mon, 8 May 2023 03:33:36 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2ac785015d7so48649931fa.1 for ; Mon, 08 May 2023 03:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683542015; x=1686134015; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eMkK5cHocOkySdQ1dvULOQ4jNtQaf1to9XDN1aW8VkM=; b=cnTXZAY/dC1mZhWnJp12bXNBoExNjAwk+0GnUWEDkYavWKThKgPlaw3OWMDOtsO3wf nI+rUpF8DhpoFnT/ucaXQbtXuQOUHkEn/byigFXHp0Nkaqk7HuumTB+qU2DA7jss7SDJ 98cY5IoqOXqf3ApD4dC1BwGBMpaQWgYy6Nc7PYvc/L3LgCpaTEf9FCvxf1HTvwHPJNLp 3wD4LwKrHLxAa3dYgidb5Ap54WWAC4UCXm/S8EzEepcU+QtimXzqb8R7PsZpG9BUzoPl cJxaJ6wFn2ECWWIEtBNvEw9tJl0MoDbExxxvBWs47nOJsM5mFIWJOlgYVRemAkM4znZ9 n0KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683542015; x=1686134015; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eMkK5cHocOkySdQ1dvULOQ4jNtQaf1to9XDN1aW8VkM=; b=I7+PM5AmPBHRp5zTYq6tUVoHJdRhoiq5ieWQ1CC5Jw3f4NCfC/nl3ldrr664vvBC72 k8uZWVICjySkEwF0lGglL3NRVKkVCG7aULKxOttn06HaT75vwXa7o3NhaqFuggbluxEb 90rux19rPB5kC4IZcSGhhDyQW3W+RUGVitna0zkfrcSIqB3l1LiopGxxEIk0HAdi7CWm IeejNTTOOuJnZhzrIcxaZpRzW+yXSZkrQqqNoLeQx5s0kpcjvgMuEisyiBcLEGVoNaMg ELi5OmAtQsfGA8HUoWhlh6OcamIheqIxPbfJMI8ReaevaOCuq11vpEQgysV8b19FjLT2 2l5w== X-Gm-Message-State: AC+VfDyz6mFc2agvPEuILLefODeDpugwc3sUR8wNgcCiZ/dKhGCFWf15 RIiHUq32lAij7pOWsUVnz+D/CQ== X-Google-Smtp-Source: ACHHUZ6c1+OpsDSd4MYi0ZIkjZ8oJNw/uPXhw3lExTrIxEHsqFxKnyHc22rN/ZZOYQHgYm8zrvnpcg== X-Received: by 2002:a2e:9590:0:b0:2ac:77fb:f2b3 with SMTP id w16-20020a2e9590000000b002ac77fbf2b3mr2810640ljh.40.1683542014794; Mon, 08 May 2023 03:33:34 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id z22-20020a2e3516000000b002a77792f2c5sm1109979ljz.62.2023.05.08.03.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:33:34 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 13:33:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 4/4] ARM: dts: qcom: apq8074-dragonboard: enable DSI panel Content-Language: en-GB To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230507190735.2333145-1-dmitry.baryshkov@linaro.org> <20230507190735.2333145-5-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 11:34, Konrad Dybcio wrote: > > > On 7.05.2023 21:07, Dmitry Baryshkov wrote: >> Enable MDSS, GPU and DSI panel output on the APQ8074 dragonboard. >> >> Signed-off-by: Dmitry Baryshkov >> --- >> .../arm/boot/dts/qcom-apq8074-dragonboard.dts | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> index c893afc00eb4..72f7e09a5bbf 100644 >> --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts >> @@ -48,6 +48,57 @@ eeprom: eeprom@52 { >> }; >> }; >> >> +&dsi0 { > old junk could use some mdss_ prefixing to keep the nodes together > > Could you please take care of that? Ack > >> + vdda-supply = <&pm8941_l2>; >> + vdd-supply = <&pm8941_l22>; >> + vddio-supply = <&pm8941_l12>; >> + >> + status = "okay"; >> + >> + panel: panel@0 { >> + compatible = "sharp,ls043t1le01-qhd"; >> + reg = <0>; >> + >> + avdd-supply = <&pm8941_l22>; >> + backlight = <&pm8941_wled>; >> + reset-gpios = <&pm8941_gpios 19 GPIO_ACTIVE_HIGH>; >> + >> + port { >> + panel_in: endpoint { >> + remote-endpoint = <&dsi0_out>; >> + }; >> + }; >> + }; >> +}; >> + >> +&dsi0_out { >> + remote-endpoint = <&panel_in>; >> + data-lanes = <0 1 2 3>; >> +}; >> + >> +&dsi0_phy { >> + status = "okay"; >> + >> + vddio-supply = <&pm8941_l12>; > status last > > Konrad >> +}; >> + >> +&gpu { >> + status = "okay"; >> +}; >> + >> +&mdss { >> + status = "okay"; >> +}; >> + >> +&pm8941_wled { >> + qcom,cs-out; >> + qcom,switching-freq = <3200>; >> + qcom,ovp = <32>; >> + qcom,num-strings = <1>; >> + >> + status = "okay"; >> +}; >> + >> &remoteproc_adsp { >> cx-supply = <&pm8841_s2>; >> -- With best wishes Dmitry