From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jishnu Prakash <quic_jprakash@quicinc.com>,
jic23@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, daniel.lezcano@linaro.org,
dmitry.baryshkov@linaro.org, linus.walleij@linaro.org,
linux-arm-msm@vger.kernel.org, andriy.shevchenko@linux.intel.com,
quic_subbaram@quicinc.com, quic_collinsd@quicinc.com,
quic_amelende@quicinc.com, quic_kamalw@quicinc.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
marijn.suijten@somainline.org
Cc: lars@metafoo.de, luca@z3ntu.xyz, linux-iio@vger.kernel.org,
lee@kernel.org, rafael@kernel.org, rui.zhang@intel.com,
lukasz.luba@arm.com, cros-qcom-dts-watchers@chromium.org,
sboyd@kernel.org, linux-pm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder
Date: Thu, 16 Nov 2023 12:44:15 +0100 [thread overview]
Message-ID: <f7065032-206f-423e-bb03-0b808ff16868@linaro.org> (raw)
In-Reply-To: <20231116032644.753370-2-quic_jprakash@quicinc.com>
On 16/11/2023 04:26, Jishnu Prakash wrote:
> There are several files containing QCOM ADC macros for channel names
> right now in the include/dt-bindings/iio folder. Since all of these
> are specifically for adc, move the files to the
> include/dt-bindings/iio/adc folder.
>
> Also update all affected devicetree and driver files to fix compilation
> errors seen with this move and update documentation files to fix
> dtbinding check errors for the same.
>
> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
> ---
> .../devicetree/bindings/iio/adc/qcom,spmi-vadc.yaml | 4 ++--
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm-hc.yaml | 2 +-
> .../devicetree/bindings/thermal/qcom-spmi-adc-tm5.yaml | 6 +++---
> arch/arm64/boot/dts/qcom/pm2250.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/pm6125.dtsi | 2 +-
NAK, bindings are always separate from the other changes.
Please run scripts/checkpatch.pl and fix reported warnings. Some
warnings can be ignored, but the code here looks like it needs a fix.
Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-16 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 3:26 [PATCH V2 2/3] iio: adc: Add support for QCOM PMIC5 Gen3 ADC Jishnu Prakash
2023-11-16 3:26 ` [PATCH V2 3/3] dt-bindings: iio/adc: Move QCOM ADC bindings to iio/adc folder Jishnu Prakash
2023-11-16 11:44 ` Krzysztof Kozlowski [this message]
2023-11-16 15:27 ` Dmitry Baryshkov
2023-11-25 19:34 ` Jonathan Cameron
2023-11-26 10:40 ` Krzysztof Kozlowski
2023-11-19 15:10 ` Rob Herring
2023-11-27 8:14 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7065032-206f-423e-bb03-0b808ff16868@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jic23@kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=lukasz.luba@arm.com \
--cc=marijn.suijten@somainline.org \
--cc=quic_amelende@quicinc.com \
--cc=quic_collinsd@quicinc.com \
--cc=quic_jprakash@quicinc.com \
--cc=quic_kamalw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).