From: Michael Walle <michael@walle.cc>
To: Rob Herring <robh@kernel.org>
Cc: Xu Liang <lxu@maxlinear.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings
Date: Wed, 28 Dec 2022 16:00:01 +0100 [thread overview]
Message-ID: <f70deb0226581bf4f385a6d55ada3da1@walle.cc> (raw)
In-Reply-To: <20221205212924.GA2638223-robh@kernel.org>
>> +
>> + Affected PHYs (as far as known) are GPY215B and GPY215C.
>> + type: boolean
>> +
>> +dependencies:
>> + maxlinear,use-broken-interrupts: [ interrupts ]
Btw. I'd presume that the tools will also allow interrupts-extended, but
that
doesn't seem to be the case. Do I need some kind of anyOf here?
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + ethernet {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ethernet-phy@0 {
>> + reg = <0>;
>> + interrupts-extended = <&intc 0>;
>> + maxlinear,use-broken-interrupts;
>
> This is never actually checked by be schema because there is nothing to
> match on. If you want custom properties, then you need a compatible.
I can add an unwanted compatible here, or skip the example altogether.
But
what puzzles me is that this schema pulls in the ethernet-phy.yaml. The
latter
then has a custom select statement on the $nodename and even a comment:
# The dt-schema tools will generate a select statement first by using
# the compatible, and second by using the node name if any. In our
# case, the node name is the one we want to match on, while the
# compatible is optional.
Why doesn't that work?
-michael
next prev parent reply other threads:[~2022-12-28 15:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 15:12 [PATCH net-next v1 0/4] net: phy: mxl-gpy: broken interrupt fixes Michael Walle
2022-12-02 15:12 ` [PATCH net-next v1 1/4] net: phy: mxl-gpy: add MDINT workaround Michael Walle
2022-12-02 18:23 ` Andrew Lunn
2022-12-02 22:53 ` Michael Walle
2022-12-02 15:12 ` [PATCH net-next v1 2/4] dt-bindings: vendor-prefixes: add MaxLinear Michael Walle
2022-12-02 15:28 ` Krzysztof Kozlowski
2022-12-02 15:12 ` [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings Michael Walle
2022-12-02 18:31 ` Andrew Lunn
2022-12-02 22:50 ` Michael Walle
2022-12-05 21:29 ` Rob Herring
2022-12-05 21:53 ` Michael Walle
2022-12-06 8:29 ` Michael Walle
2022-12-06 8:38 ` Krzysztof Kozlowski
2022-12-06 9:44 ` Michael Walle
2022-12-16 9:03 ` Michael Walle
2022-12-20 13:21 ` Andrew Lunn
2022-12-28 15:00 ` Michael Walle [this message]
2022-12-02 15:12 ` [PATCH net-next v1 4/4] net: phy: mxl-gpy: disable interrupts on GPY215 by default Michael Walle
2022-12-02 18:42 ` Andrew Lunn
2022-12-02 23:09 ` Michael Walle
2022-12-03 20:36 ` Andrew Lunn
2022-12-16 9:46 ` Michael Walle
2022-12-20 13:33 ` Andrew Lunn
2022-12-20 21:39 ` Michael Walle
2022-12-03 20:41 ` [PATCH net-next v1 0/4] net: phy: mxl-gpy: broken interrupt fixes Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f70deb0226581bf4f385a6d55ada3da1@walle.cc \
--to=michael@walle.cc \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).