From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDB3C3DA7D for ; Wed, 28 Dec 2022 15:00:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233369AbiL1PAL (ORCPT ); Wed, 28 Dec 2022 10:00:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233376AbiL1PAK (ORCPT ); Wed, 28 Dec 2022 10:00:10 -0500 Received: from mail.3ffe.de (0001.3ffe.de [159.69.201.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F71912ADA; Wed, 28 Dec 2022 07:00:04 -0800 (PST) Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 396A61691; Wed, 28 Dec 2022 16:00:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1672239601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G7X5I37Wqlz1lzMJ3mdpNrFggiiHaWpWuH+NMxL853Q=; b=QTJFGZr4N5l37GryGQO0dE0UZSmqDUwyMUsGmGZ868uS8fDZMw7OB7oYvdEEHTH77X/TV8 uX4OMJO6L3wTTApqmFw33hUf5FCJZXw7uKYAk811opDw5KtTd0Ry6Cbg9KeNx/dxx0Nxoy quzawcv+3mkMwUUWXB1eMSskfAvDtyJZYPGfBpRdWSyvZLDJukrT4cGmmp5Lk/4C5JMufB Fjc3d7W3K0BitaC1/Wn9Bfe8YwbKbuEBcICoZWfnL0Km8+6YPWi3bx4t+YOM8t0MZaCetM OuH4kweutrU12UqnhopbmHUDEw/BsnlMGsmHCswfnBG1Cx3BkyUBWCseugna4w== MIME-Version: 1.0 Date: Wed, 28 Dec 2022 16:00:01 +0100 From: Michael Walle To: Rob Herring Cc: Xu Liang , Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Krzysztof Kozlowski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next v1 3/4] dt-bindings: net: phy: add MaxLinear GPY2xx bindings In-Reply-To: <20221205212924.GA2638223-robh@kernel.org> References: <20221202151204.3318592-1-michael@walle.cc> <20221202151204.3318592-4-michael@walle.cc> <20221205212924.GA2638223-robh@kernel.org> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org >> + >> + Affected PHYs (as far as known) are GPY215B and GPY215C. >> + type: boolean >> + >> +dependencies: >> + maxlinear,use-broken-interrupts: [ interrupts ] Btw. I'd presume that the tools will also allow interrupts-extended, but that doesn't seem to be the case. Do I need some kind of anyOf here? >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + ethernet { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ethernet-phy@0 { >> + reg = <0>; >> + interrupts-extended = <&intc 0>; >> + maxlinear,use-broken-interrupts; > > This is never actually checked by be schema because there is nothing to > match on. If you want custom properties, then you need a compatible. I can add an unwanted compatible here, or skip the example altogether. But what puzzles me is that this schema pulls in the ethernet-phy.yaml. The latter then has a custom select statement on the $nodename and even a comment: # The dt-schema tools will generate a select statement first by using # the compatible, and second by using the node name if any. In our # case, the node name is the one we want to match on, while the # compatible is optional. Why doesn't that work? -michael