From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bastian Germann <bage@debian.org>,
Wilken Gottwalt <wilken.gottwalt@posteo.net>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <andersson@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/5] arm64: dts: allwinner: a64: Add hwspinlock node
Date: Thu, 16 Feb 2023 09:36:58 +0100 [thread overview]
Message-ID: <f720eaf9-01d0-0e57-f6bf-9aade00aafb8@linaro.org> (raw)
In-Reply-To: <20230215203711.6293-6-bage@debian.org>
On 15/02/2023 21:37, Bastian Germann wrote:
> Add the hwspinlock to A64 which is already implemented for A31.
>
> Signed-off-by: Bastian Germann <bage@debian.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index 77b5349f6087..f2ecc21f06ed 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -851,6 +851,17 @@ wdt0: watchdog@1c20ca0 {
> clocks = <&osc24M>;
> };
>
> + hwspinlock: hwlock@1c18000 {
> + compatible = "allwinner,sun50i-a64-hwspinlock",
> + "allwinner,sun6i-a31-hwspinlock";
> + reg = <0x01c18000 0x1000>;
> + clocks = <&ccu CLK_BUS_SPINLOCK>;
> + clock-names = "ahb";
Please drop.
> + resets = <&ccu RST_BUS_SPINLOCK>;
> + reset-names = "ahb";
Please drop.
Fix the driver instead.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-02-16 8:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 20:37 [PATCH v2 0/5] Enable hwlock on Allwinner A64 Bastian Germann
2023-02-15 20:37 ` [PATCH v2 1/5] dt-bindings: hwlock: sun6i: Add missing #hwlock-cells Bastian Germann
2023-02-15 20:37 ` [PATCH v2 2/5] dt-bindings: hwlock: sun6i: Add #hwlock-cells to example Bastian Germann
2023-02-15 20:40 ` Andre Przywara
2023-02-15 20:43 ` Bastian Germann
2023-02-15 23:09 ` Andre Przywara
2023-02-16 8:39 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 3/5] dt-bindings: hwlock: sun6i: Add missing names Bastian Germann
2023-02-15 20:45 ` Andre Przywara
2023-02-15 20:49 ` Bastian Germann
2023-02-16 8:36 ` Krzysztof Kozlowski
2023-02-16 8:54 ` Wilken Gottwalt
2023-02-15 20:37 ` [PATCH v2 4/5] dt-bindings: hwlock: sun6i: Add a64 compatible string Bastian Germann
2023-02-15 20:49 ` Andre Przywara
2023-02-15 21:31 ` Rob Herring
2023-02-16 8:38 ` Krzysztof Kozlowski
2023-02-15 20:37 ` [PATCH v2 5/5] arm64: dts: allwinner: a64: Add hwspinlock node Bastian Germann
2023-02-15 20:50 ` Andre Przywara
2023-02-16 8:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f720eaf9-01d0-0e57-f6bf-9aade00aafb8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=bage@debian.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).