* [PATCH] dt-bindings: clock: imx8m: add interrupts property
@ 2023-03-01 2:01 Peng Fan (OSS)
2023-03-01 2:31 ` Jacky Bai
2023-03-02 8:38 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Peng Fan (OSS) @ 2023-03-01 2:01 UTC (permalink / raw)
To: abelvesa, abel.vesa, mturquette, sboyd, shawnguo, s.hauer, kernel,
festevam, robh+dt, krzysztof.kozlowski+dt
Cc: linux-imx, linux-clk, linux-arm-kernel, linux-kernel, devicetree,
Peng Fan
From: Peng Fan <peng.fan@nxp.com>
Since the CCM module could trigger interrupt, so add interrupts property
for i.MX8M.
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
index 0dbc1433fede..ac7ad8459c79 100644
--- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
+++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
@@ -39,6 +39,10 @@ properties:
ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h
for the full list of i.MX8M clock IDs.
+ interrupts:
+ minItems: 1
+ maxItems: 2
+
required:
- compatible
- reg
--
2.37.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property
2023-03-01 2:01 [PATCH] dt-bindings: clock: imx8m: add interrupts property Peng Fan (OSS)
@ 2023-03-01 2:31 ` Jacky Bai
2023-03-01 2:34 ` Peng Fan
2023-03-02 8:38 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Jacky Bai @ 2023-03-01 2:31 UTC (permalink / raw)
To: Peng Fan (OSS), abelvesa@kernel.org, abel.vesa@linaro.org,
mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org
Cc: dl-linux-imx, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Peng Fan
> Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Since the CCM module could trigger interrupt, so add interrupts property for
> i.MX8M.
>
Any chance that these interrupt will be used? More likely such interrupt are useless and has no details
about how to use it in RM, just piece of words in the interrupt table.
BR
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> index 0dbc1433fede..ac7ad8459c79 100644
> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> @@ -39,6 +39,10 @@ properties:
> ID in its "clocks" phandle cell. See
> include/dt-bindings/clock/imx8m-clock.h
> for the full list of i.MX8M clock IDs.
>
> + interrupts:
> + minItems: 1
> + maxItems: 2
> +
> required:
> - compatible
> - reg
> --
> 2.37.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property
2023-03-01 2:31 ` Jacky Bai
@ 2023-03-01 2:34 ` Peng Fan
2023-03-01 2:35 ` Jacky Bai
0 siblings, 1 reply; 5+ messages in thread
From: Peng Fan @ 2023-03-01 2:34 UTC (permalink / raw)
To: Jacky Bai, Peng Fan (OSS), abelvesa@kernel.org,
abel.vesa@linaro.org, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: dl-linux-imx, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
> Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property
>
> > Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Since the CCM module could trigger interrupt, so add interrupts
> > property for i.MX8M.
> >
>
> Any chance that these interrupt will be used? More likely such interrupt are
> useless and has no details about how to use it in RM, just piece of words in
> the interrupt table.
This is to clear the System-Ready check warning. This is to describe
the hardware. Since device tree already has it, and the hardware
indeed supports interrupt, so let's add it.
Thanks,
Peng.
>
> BR
>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > index 0dbc1433fede..ac7ad8459c79 100644
> > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > @@ -39,6 +39,10 @@ properties:
> > ID in its "clocks" phandle cell. See
> > include/dt-bindings/clock/imx8m-clock.h
> > for the full list of i.MX8M clock IDs.
> >
> > + interrupts:
> > + minItems: 1
> > + maxItems: 2
> > +
> > required:
> > - compatible
> > - reg
> > --
> > 2.37.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property
2023-03-01 2:34 ` Peng Fan
@ 2023-03-01 2:35 ` Jacky Bai
0 siblings, 0 replies; 5+ messages in thread
From: Jacky Bai @ 2023-03-01 2:35 UTC (permalink / raw)
To: Peng Fan, Peng Fan (OSS), abelvesa@kernel.org,
abel.vesa@linaro.org, mturquette@baylibre.com, sboyd@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: dl-linux-imx, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
> Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts property
>
> > Subject: RE: [PATCH] dt-bindings: clock: imx8m: add interrupts
> > property
> >
> > > Subject: [PATCH] dt-bindings: clock: imx8m: add interrupts property
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Since the CCM module could trigger interrupt, so add interrupts
> > > property for i.MX8M.
> > >
> >
> > Any chance that these interrupt will be used? More likely such
> > interrupt are useless and has no details about how to use it in RM,
> > just piece of words in the interrupt table.
>
> This is to clear the System-Ready check warning. This is to describe the
> hardware. Since device tree already has it, and the hardware indeed supports
> interrupt, so let's add it.
>
Ok, got it, thx.
BR
> Thanks,
> Peng.
> >
> > BR
> >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > > b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > > index 0dbc1433fede..ac7ad8459c79 100644
> > > --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > > +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> > > @@ -39,6 +39,10 @@ properties:
> > > ID in its "clocks" phandle cell. See
> > > include/dt-bindings/clock/imx8m-clock.h
> > > for the full list of i.MX8M clock IDs.
> > >
> > > + interrupts:
> > > + minItems: 1
> > > + maxItems: 2
> > > +
> > > required:
> > > - compatible
> > > - reg
> > > --
> > > 2.37.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: clock: imx8m: add interrupts property
2023-03-01 2:01 [PATCH] dt-bindings: clock: imx8m: add interrupts property Peng Fan (OSS)
2023-03-01 2:31 ` Jacky Bai
@ 2023-03-02 8:38 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-02 8:38 UTC (permalink / raw)
To: Peng Fan (OSS), abelvesa, abel.vesa, mturquette, sboyd, shawnguo,
s.hauer, kernel, festevam, robh+dt, krzysztof.kozlowski+dt
Cc: linux-imx, linux-clk, linux-arm-kernel, linux-kernel, devicetree,
Peng Fan
On 01/03/2023 03:01, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Since the CCM module could trigger interrupt, so add interrupts property
> for i.MX8M.
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/clock/imx8m-clock.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> index 0dbc1433fede..ac7ad8459c79 100644
> --- a/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx8m-clock.yaml
> @@ -39,6 +39,10 @@ properties:
> ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx8m-clock.h
> for the full list of i.MX8M clock IDs.
>
> + interrupts:
> + minItems: 1
> + maxItems: 2
You should describe the interrupts. Why they are variable in number?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-03-02 8:38 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-01 2:01 [PATCH] dt-bindings: clock: imx8m: add interrupts property Peng Fan (OSS)
2023-03-01 2:31 ` Jacky Bai
2023-03-01 2:34 ` Peng Fan
2023-03-01 2:35 ` Jacky Bai
2023-03-02 8:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).