devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml
Date: Tue, 8 Nov 2022 12:05:19 +0100	[thread overview]
Message-ID: <f72aeaa0-0c0a-86d9-0b9b-db3810c35fad@linaro.org> (raw)
In-Reply-To: <20221024164225.3236654-6-dmitry.baryshkov@linaro.org>

On 24/10/2022 18:42, Dmitry Baryshkov wrote:
> Move properties common to all MDSS DT nodes to the mdss-common.yaml.
> 
> This extends qcom,msm8998-mdss schema to allow interconnect nodes, which
> will be added later, once msm8998 gains interconnect support.


(...)

> +    minItems: 1
> +    items:
> +      - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
> +      - description: Interconnect path from mdp1 port to the data bus
> +
> +  interconnect-names:
> +    minItems: 1
> +    items:
> +      - const: mdp0-mem
> +      - const: mdp1-mem
> +
> +  resets:
> +    items:
> +      - description: MDSS_CORE reset
> +
> +required:
> +  - compatible

For consistency this should not be required here, but in schema actually
defining it.

> +  - reg
> +  - reg-names
> +  - power-domains
> +  - clocks
> +  - interrupts
> +  - interrupt-controller
> +  - iommus
> +  - ranges

Keep the same order as in list of top-level properties.

> +
> +additionalProperties: true

Best regards,
Krzysztof


  reply	other threads:[~2022-11-08 11:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-24 16:42 [PATCH v9 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 01/12] dt-bindings: display/msm: split qcom,mdss bindings Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 02/12] dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 03/12] dt-bindings: display/msm: add interconnects property to qcom,mdss-smd845 Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 04/12] dt-bindings: display/msm: move common DPU properties to dpu-common.yaml Dmitry Baryshkov
2022-11-08 11:03   ` Krzysztof Kozlowski
2022-10-24 16:42 ` [PATCH v9 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Dmitry Baryshkov
2022-11-08 11:05   ` Krzysztof Kozlowski [this message]
2022-11-10 21:45     ` Dmitry Baryshkov
2022-11-11  7:56       ` Krzysztof Kozlowski
2022-10-24 16:42 ` [PATCH v9 06/12] dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 07/12] dt-bindings: display/msm: split dpu-sc7280 " Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 08/12] dt-bindings: display/msm: split dpu-sdm845 " Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 09/12] dt-bindings: display/msm: split dpu-msm8998 " Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 10/12] dt-bindings: display/msm: split dpu-qcm2290 " Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 11/12] dt-bindings: display/msm: add missing device nodes to mdss-* schemas Dmitry Baryshkov
2022-10-24 16:42 ` [PATCH v9 12/12] dt-bindings: display/msm: add support for the display on SM8250 Dmitry Baryshkov
2022-11-04 12:21 ` [PATCH v9 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Rob Herring
2022-11-04 13:05   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f72aeaa0-0c0a-86d9-0b9b-db3810c35fad@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).