Re: [PATCH v4 07/15] mfd: bcm2835-pm: Add support for BCM2711

[Stefan Wahren <stefan.wahren@i2se.com>]

Am 13.02.22 um 23:56 schrieb Peter Robinson:
> From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> In BCM2711 the new RPiVid ASB took over V3D. The old ASB is still present
> with the ISP and H264 bits, and V3D is in the same place in the new ASB
> as the old one.
>
> As per the devicetree bindings, BCM2711 will provide both the old and
> new ASB resources, so get both of them and pass them into
> 'bcm2835-power,' which will take care of selecting which one to use
> accordingly.
>
> Since the RPiVid ASB's resources were being provided prior to formalizing
> the bindings[1], also support the old firmwares that didn't use
> 'reg-names.'
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>
> [1] See: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
>
> ---
> Changes since v2: 
>  - Correct names again!
>                         
> Changes since v1:
>  - Use reg-names
>  - Correct ASB names
>
>  drivers/mfd/bcm2835-pm.c       | 25 +++++++++++++++++++++++--
>  include/linux/mfd/bcm2835-pm.h |  1 +
>  2 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
> index 36fede92775c..a06e9cf19b64 100644
> --- a/drivers/mfd/bcm2835-pm.c
> +++ b/drivers/mfd/bcm2835-pm.c
> @@ -6,6 +6,7 @@
>   * the WDT and power drivers.
>   */
>  
> +#include <linux/bits.h>
>  #include <linux/delay.h>
>  #include <linux/io.h>
>  #include <linux/mfd/bcm2835-pm.h>
> @@ -17,6 +18,9 @@
>  #include <linux/types.h>
>  #include <linux/watchdog.h>
>  
> +#define BCM2835		BIT(1)
> +#define BCM2711		BIT(2)
> +
Unfortunately, i don't remember the decision to use bits here. It's just
unexpected, no strong opinion.