From: Andrew Lunn <andrew@lunn.ch>
To: "Jens Emil Schulz Østergaard" <jensemil.schulzostergaard@microchip.com>
Cc: UNGLinuxDriver@microchip.com, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Woojung Huh <woojung.huh@microchip.com>,
Russell King <linux@armlinux.org.uk>,
Steen Hegelund <Steen.Hegelund@microchip.com>,
Daniel Machon <daniel.machon@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH net-next v12 2/9] dt-bindings: net: lan9645x: add LAN9645X switch bindings
Date: Tue, 8 Sep 2026 14:59:25 +0200 [thread overview]
Message-ID: <f745c884-ecfd-4dbd-ae33-6b713f8ab73d@lunn.ch> (raw)
In-Reply-To: <20260908-dsa_lan9645x_switch_driver_base-v12-2-2d6aa59350cd@microchip.com>
> rx/tx-internal-delay-ps is used to model a direct MAC to MAC fixed link,
> using RGMII, where exactly one of them must supply the delay.
> Documentation/networking/phy.rst describes plain rgmii as the mode where
> the MAC or the PCB adds the delay rather than the PHY.
This is not correct. phy-mode 'rgmii' in DT means the PCB adds the
delay.
If the value is not 'rgmii', then the MAC/PHY pair need to decided on
which adds the delay, and by convention, it is normally the PHY.
Where it gets interesting is MAC to MAC, which you do see in
switches. Using rx/tx-internal-delay-ps makes a lot of sense in this
setting.
The binding itself looks O.K, its just this commit message text which
is wrong.
Andrew
next prev parent reply other threads:[~2026-09-08 12:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:39 [PATCH net-next v12 0/9] net: dsa: add DSA support for the LAN9645x switch chip family Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 1/9] net: dsa: add tag driver for LAN9645X Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 2/9] dt-bindings: net: lan9645x: add LAN9645X switch bindings Jens Emil Schulz Østergaard
2026-09-08 12:59 ` Andrew Lunn [this message]
2026-09-10 14:42 ` Jens Emil Schulz Ostergaard
2026-09-08 7:39 ` [PATCH net-next v12 3/9] net: dsa: lan9645x: add autogenerated register macros Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 4/9] net: dsa: lan9645x: add basic dsa driver for LAN9645X Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 5/9] net: dsa: lan9645x: add vlan support Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 6/9] net: dsa: lan9645x: add mac table integration Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 7/9] net: dsa: lan9645x: add mdb management Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 8/9] net: dsa: lan9645x: add bridge support Jens Emil Schulz Østergaard
2026-09-08 7:39 ` [PATCH net-next v12 9/9] net: dsa: lan9645x: add port statistics Jens Emil Schulz Østergaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f745c884-ecfd-4dbd-ae33-6b713f8ab73d@lunn.ch \
--to=andrew@lunn.ch \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=geert+renesas@glider.be \
--cc=horms@kernel.org \
--cc=jensemil.schulzostergaard@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox