From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97683C7EE25 for ; Mon, 5 Jun 2023 18:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229580AbjFESx2 (ORCPT ); Mon, 5 Jun 2023 14:53:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbjFESx1 (ORCPT ); Mon, 5 Jun 2023 14:53:27 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23E71F1 for ; Mon, 5 Jun 2023 11:53:25 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4f60a27c4a2so6116766e87.2 for ; Mon, 05 Jun 2023 11:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685991203; x=1688583203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q9rzG8UD/ldrMcAHE1T1BvaSz6ylxNrtU5fahC9y+bI=; b=VcDYifDHedypBZZ1STGBiZySLcfYg6Ha4zn3yorgcINosc89BKZJdtIMuJgtZECZkD suMzOHUU8ehqsA0Wpa877CG9/FLtsx74VctyzYiySmhcge98ZeZAkaYO2TzTcRJJ5FOx cpWaZc0VzEceKgfQdqF4ylRl9WlG6KgRUuzTZHuh16casmjilzBAsKW4SHVhjNmT/pbK G2juGHH2dKJoiwejOcnK+ge+gnwLkVkoZQVtaTPIJxGiE0UPF6ATOf6XdtT5NxPtxc5k bFJfsLGSSyHFL3Bh0HRrOGEyoqLcWOnDB+t8JTwbsGdV0JOdvAI0Eje5ZVV9nhIAZ+GA l7sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685991203; x=1688583203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q9rzG8UD/ldrMcAHE1T1BvaSz6ylxNrtU5fahC9y+bI=; b=e6S8NcaI14l/64BKfzvZmsDU+B+kEa5GQTGYKrTZ2vmV/zefyOzNhx9HnP+efEl6kp ad1p4mcJJwfv1fOX6nvrpSaAivH7PSJZ4VmCgdYvbaO9iLJC5NFsHIFRyU98CIdrQJ7i TRbO1nInakTJPmONdQFBJv1Q9aVqw/jFqjXH3IqZ+XIhRPTVRH9k9kZWFgC6SG7m1Y9k /hWs+fVkdciZ08dGlPnuh94IO8C25c0aWBp4hSZByloBPseoCXvwrVgKpbpjkCxZKeeN 1X/cLXc1svk03RQrWx6N4QZGLwvA6OBV3mX77OBn1fDrP0mXyNXCNhQJ+4AlrkbxUIf7 etGQ== X-Gm-Message-State: AC+VfDzvUom2pEYbi7HZr/98lRXPNRu+q+87gwRcfhFisS13MfAijO2l eIJdeAoSdVZ764/tOhIMdB1Gwg== X-Google-Smtp-Source: ACHHUZ5rjHaJj9TnfKZQcvYFsyp47ETkS5pDK6TXhDJrno9DBi7/s8YUHv5LhjP9bPqJ0YP85Jy5HA== X-Received: by 2002:a05:6512:11eb:b0:4f5:1ca1:30ce with SMTP id p11-20020a05651211eb00b004f51ca130cemr5825409lfs.47.1685991203383; Mon, 05 Jun 2023 11:53:23 -0700 (PDT) Received: from [192.168.1.101] (abyj96.neoplus.adsl.tpnet.pl. [83.9.29.96]) by smtp.gmail.com with ESMTPSA id n7-20020a195507000000b004f1482d9db6sm1197914lfe.155.2023.06.05.11.53.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 11:53:23 -0700 (PDT) Message-ID: Date: Mon, 5 Jun 2023 20:53:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 08/14] soc: qcom: smem: Add qcom_smem_is_available() Content-Language: en-US To: Stephan Gerhold , Bjorn Andersson Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mathieu Poirier , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20230531-rpm-rproc-v1-0-e0a3b6de1f14@gerhold.net> <20230531-rpm-rproc-v1-8-e0a3b6de1f14@gerhold.net> From: Konrad Dybcio In-Reply-To: <20230531-rpm-rproc-v1-8-e0a3b6de1f14@gerhold.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5.06.2023 09:08, Stephan Gerhold wrote: > Avoid having to look up a dummy item from SMEM to detect if it is > already available or if we need to defer probing. > > Signed-off-by: Stephan Gerhold > --- > drivers/soc/qcom/smem.c | 9 +++++++++ > include/linux/soc/qcom/smem.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c > index b0d59e815c3b..3d93a6681494 100644 > --- a/drivers/soc/qcom/smem.c > +++ b/drivers/soc/qcom/smem.c > @@ -359,6 +359,15 @@ static struct qcom_smem *__smem; > /* Timeout (ms) for the trylock of remote spinlocks */ > #define HWSPINLOCK_TIMEOUT 1000 > > +/** > + * qcom_smem_is_available() - Checks if SMEM is available > + */ Shouldn't kerneldoc explicitly say "returns x if y else z"? Modulo that: Reviewed-by: Konrad Dybcio Konrad > +bool qcom_smem_is_available(void) > +{ > + return !!__smem; > +} > +EXPORT_SYMBOL(qcom_smem_is_available); > + > static int qcom_smem_alloc_private(struct qcom_smem *smem, > struct smem_partition *part, > unsigned item, > diff --git a/include/linux/soc/qcom/smem.h b/include/linux/soc/qcom/smem.h > index 223db6a9c733..a36a3b9d4929 100644 > --- a/include/linux/soc/qcom/smem.h > +++ b/include/linux/soc/qcom/smem.h > @@ -4,6 +4,7 @@ > > #define QCOM_SMEM_HOST_ANY -1 > > +bool qcom_smem_is_available(void); > int qcom_smem_alloc(unsigned host, unsigned item, size_t size); > void *qcom_smem_get(unsigned host, unsigned item, size_t *size); > >