From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Brian Norris <briannorris@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Chen-Yu Tsai <wenst@chromium.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add gru-scarlet sku{2,4} variants
Date: Thu, 18 Aug 2022 13:01:55 +0300 [thread overview]
Message-ID: <f776de47-615e-d38d-8512-3e5391d6650a@linaro.org> (raw)
In-Reply-To: <20220817123350.1.Ibb15bab32dbfa0d89f86321c4eae7adbc8d7ad4a@changeid>
On 17/08/2022 22:33, Brian Norris wrote:
> The Gru-Scarlet family includes a variety of SKU identifiers, using
> parts of a 3-bit space {0..7}. SKU2 and SKU4 devices (under a few
> different manufacturer names) also use the Innolux display.
>
> For reference, the original vendor tree source:
>
> CHROMIUM: arm64: dts: rockchip: add sku{0,2,4} compatibility
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f6ed665c9e2eb37fb2680debbb36ec9fb0e8fb97
>
> CHROMIUM: arm64: dts: rockchip: scarlet: add SKU0 device tree
> https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9987c8776f4b087d135d761e59f7fa6cc83fc7fc
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
>
> .../devicetree/bindings/arm/rockchip.yaml | 27 ++++++++++++++++++-
> 1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 7811ba64149c..dcae534e3971 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -363,30 +363,55 @@ properties:
> - const: google,gru
> - const: rockchip,rk3399
>
> - - description: Google Scarlet - Innolux display (Acer Chromebook Tab 10)
> + - description: |
> + Google Scarlet - Innolux display (Acer Chromebook Tab 10 and more)
> items:
> + - const: google,scarlet-rev15-sku2
> + - const: google,scarlet-rev15-sku4
This does not match the sources you linked in commit msg, so I am
confused what the links are supposed to prove.
Is this matching at least your DTS (dtbs_check passes)?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-18 10:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 19:33 [PATCH 1/2] dt-bindings: arm: rockchip: Add gru-scarlet sku{2,4} variants Brian Norris
2022-08-17 19:33 ` [PATCH 2/2] arm64: dts: rockchip: Support " Brian Norris
2022-08-18 10:01 ` Krzysztof Kozlowski [this message]
2022-08-22 18:57 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add " Brian Norris
2022-09-14 22:44 ` Brian Norris
2022-09-15 13:49 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f776de47-615e-d38d-8512-3e5391d6650a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).