From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39A70C00140 for ; Thu, 18 Aug 2022 10:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241107AbiHRKCC (ORCPT ); Thu, 18 Aug 2022 06:02:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240265AbiHRKCA (ORCPT ); Thu, 18 Aug 2022 06:02:00 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 317D790811 for ; Thu, 18 Aug 2022 03:01:59 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id z20so1238502ljq.3 for ; Thu, 18 Aug 2022 03:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=EPxzHwYhFlft26MSmbXxer1pCM7eMFS2V0bDjoXyAJU=; b=eEyiXUfctANEiiWIrg9Y5EqIuZU09pRr7ZymPkvek4Ap91RbdKI7jw15XsDiehwsmK HnYwSQDCa/kUdgXXYdEwax3exEU5TXaQFQGgokYN+jlp8rKPFuBY00u+/52gfWnWSHJB XRHDi5P6qO3L3T3EmrLE8tlFymLjIxwLa/2W+InzaIVjmaHNlmVmlcGQgu+mOg9FNfIB CuqfKF+pWfgaZ+0cJywgNgJdl7LFHk5F8YfvFmzMcC1iezVCRj63UgfRF0ieftEAtVz9 c0xRG2l0LPXmx/8VDfuna7mFKDRScPF9E/bdIZ3fomoS62togRzGjWCxBVGibXPC28+F RKFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=EPxzHwYhFlft26MSmbXxer1pCM7eMFS2V0bDjoXyAJU=; b=mEjk+mLHTcOHsiNRdL9t5VtTkIKjXQ0ZOSOy2DqbojyaPDyXP7M9ZUwVFktTN6otyL ycBLJTmg2WR5Eq6jqMQBr39/trLSYwY7a/DOX4Q2LW0nxTS3BVvlE+9dgqyUrGKakuc5 XXfvAgWGzSwWczBcZF93I/vEtM9zXC+BlpetZ7Y94zyzSbHDFR9ryJ5SgAZZFB1xdPvt FM46+7Gc23IAttyzDpjiZeLn5MOIhSy8jGDg5OCflXLiPt60PepE7YfGY3/mJo+5Wp2I 6bQuPKC7TF9bhQm2Z4Lm2YaWKzoWuVw9put9z3Qch+4clwFMvFvqJy6vr/gmn9XH6gi5 l32g== X-Gm-Message-State: ACgBeo3rIqCuKbZYXh3f7AQN84vpn4ejQS8F62SWXKHFBfdAJmaMS+wL 6zpJUgWUGHSGe4YIysf+H1CPFA== X-Google-Smtp-Source: AA6agR4Co2CPb5XN9X5svZynx70dgbm9JfH6RnGUadXts1hBLz65YPN73Tt641xJ42PHeMEA2pv3rw== X-Received: by 2002:a2e:86cd:0:b0:260:55e:db13 with SMTP id n13-20020a2e86cd000000b00260055edb13mr629600ljj.146.1660816917505; Thu, 18 Aug 2022 03:01:57 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:53ab:2635:d4f2:d6d5? (d15l54z9nf469l8226z-4.rev.dnainternet.fi. [2001:14bb:ae:539c:53ab:2635:d4f2:d6d5]) by smtp.gmail.com with ESMTPSA id b9-20020a056512070900b0048b37d29261sm165372lfs.67.2022.08.18.03.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 03:01:56 -0700 (PDT) Message-ID: Date: Thu, 18 Aug 2022 13:01:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] dt-bindings: arm: rockchip: Add gru-scarlet sku{2,4} variants Content-Language: en-US To: Brian Norris , Heiko Stuebner , Krzysztof Kozlowski , Rob Herring Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Chen-Yu Tsai , devicetree@vger.kernel.org References: <20220817123350.1.Ibb15bab32dbfa0d89f86321c4eae7adbc8d7ad4a@changeid> From: Krzysztof Kozlowski In-Reply-To: <20220817123350.1.Ibb15bab32dbfa0d89f86321c4eae7adbc8d7ad4a@changeid> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/08/2022 22:33, Brian Norris wrote: > The Gru-Scarlet family includes a variety of SKU identifiers, using > parts of a 3-bit space {0..7}. SKU2 and SKU4 devices (under a few > different manufacturer names) also use the Innolux display. > > For reference, the original vendor tree source: > > CHROMIUM: arm64: dts: rockchip: add sku{0,2,4} compatibility > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/f6ed665c9e2eb37fb2680debbb36ec9fb0e8fb97 > > CHROMIUM: arm64: dts: rockchip: scarlet: add SKU0 device tree > https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9987c8776f4b087d135d761e59f7fa6cc83fc7fc > > Signed-off-by: Brian Norris > --- > > .../devicetree/bindings/arm/rockchip.yaml | 27 ++++++++++++++++++- > 1 file changed, 26 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 7811ba64149c..dcae534e3971 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -363,30 +363,55 @@ properties: > - const: google,gru > - const: rockchip,rk3399 > > - - description: Google Scarlet - Innolux display (Acer Chromebook Tab 10) > + - description: | > + Google Scarlet - Innolux display (Acer Chromebook Tab 10 and more) > items: > + - const: google,scarlet-rev15-sku2 > + - const: google,scarlet-rev15-sku4 This does not match the sources you linked in commit msg, so I am confused what the links are supposed to prove. Is this matching at least your DTS (dtbs_check passes)? Best regards, Krzysztof