From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E7E180; Tue, 19 Sep 2023 00:23:48 +0000 (UTC) Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C6C107; Mon, 18 Sep 2023 17:23:45 -0700 (PDT) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38INSgM7019894; Tue, 19 Sep 2023 00:23:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=ZzAyxflayBdGB5NOfX/tkFpQl2JCuDSFOECx7lyWW4w=; b=hLuqgdvLPsiVtXcgftB/4FfYgoInPmmD2++eoGa0tCWFhUg+QJSixCv4nEb4WIPOTyu2 IElYIgXhGufTorMRnwuJlMLGY/UZ832/zaGSaZoa17feqRCjq7FD7O8K9qp6pu2c6yt1 uX+HoTq9w+l2OVjbsciJITOFqMcBK3I0Uu2Z4aiy93Z9wilmqiaJk+XPli2vi2h2+O30 UdK/Qs9Pu+e6sKrRd/gK+rWw7EpM9TRwl+1Q68Y2rn6KvvfS0v5/pGcmZZ3ya73SJOuy /SDBeyN5wmcjYKmXcUGrqUO2JpQ6bPIdsKtjuXrIkXjQvGaMmuXT2zAVSGJ1Lng3GS9H xQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t53ybc9f6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 00:23:22 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38J0NLYE009462 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 00:23:21 GMT Received: from [10.110.39.29] (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Mon, 18 Sep 2023 17:23:20 -0700 Message-ID: Date: Mon, 18 Sep 2023 17:23:16 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition Content-Language: en-US To: Rob Herring CC: Konrad Dybcio , , , , , , , , , , , , , , , , , , References: <20230916001026.315-1-quic_wcheng@quicinc.com> <20230916001026.315-14-quic_wcheng@quicinc.com> <6e66d821-1275-4830-a898-bb82c333dcc5@linaro.org> <20230918201919.GA1694628-robh@kernel.org> From: Wesley Cheng In-Reply-To: <20230918201919.GA1694628-robh@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 9MWiJGmzLM4Bj6yRSS5de11vRTYHJIHr X-Proofpoint-ORIG-GUID: 9MWiJGmzLM4Bj6yRSS5de11vRTYHJIHr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-18_11,2023-09-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 suspectscore=0 adultscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=599 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2309190001 X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Hi Rob, On 9/18/2023 1:19 PM, Rob Herring wrote: > On Fri, Sep 15, 2023 at 05:43:45PM -0700, Wesley Cheng wrote: >> Hi Konrad, >> >> On 9/15/2023 5:35 PM, Konrad Dybcio wrote: >>> On 16.09.2023 02:10, Wesley Cheng wrote: >>>> Add a new definition for specifying how many XHCI secondary interrupters >>>> can be allocated. XHCI in general can potentially support up to 1024 >>>> interrupters, which some uses may want to limit depending on how many >>>> users utilize the interrupters. >>>> >>>> Signed-off-by: Wesley Cheng >>>> --- >>> Any reason for a DWC3-specific property? Why not just >>> use the XHCI-common one from patch 14 and error out if >>> a value of more than 8 is found? >>> > > I'm pretty sure I said use the common one already... > Yes, you mentioned that in the last rev. >> >> Not every XHCI plat user is going to be DWC3. In case DWC3 is used, the >> DWC3 host driver is the one that populates and adds the XHCI plat device (no >> separate device node for XHCI), so that requires the DWC3 host to also >> populate properties for the XHCI device. (dwc3_host_init()) > > This binding references usb-xhci.yaml already, so any property from > there is allowed. Linux needs to handle that regardless of what the > driver structure/division looks like. > Ok, understood. I will remove the need to have another DWC3 property and just use the XHCI one directly. Checks are already in place in the DWC3 parser to limit the interrupters if it exceeds 8. Thanks Wesley Cheng