From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A53CC4332F for ; Thu, 15 Dec 2022 08:19:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229498AbiLOITs (ORCPT ); Thu, 15 Dec 2022 03:19:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229653AbiLOITm (ORCPT ); Thu, 15 Dec 2022 03:19:42 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD361A39A for ; Thu, 15 Dec 2022 00:19:41 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id g14so9148302ljh.10 for ; Thu, 15 Dec 2022 00:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VSN2/dLk93fIRVrCh8N+0AmorCRCNEabm5sVB7MbO9A=; b=XdVfWnxMN7fe1l0Uox7bvSuAbgsX4/G1RES/z7paJzDhpv428QfCL/0kIogX908QlD aGv/khZLcysVMdTLJCBcB6/ZYVo4oC554CLmDd5jO+2AvHpepXsYktFm4twIxnb3ytOB OKeH1f2/6KKVjFbIorzW3y29nVCxQW8/uQ1zHrzLEZXcIJJrhLR38FaqCcqiO4Zglg8y 1Adiu65jQjbdHisY8kdg8TB7nZJR6sgZOZm9tgq4UpNVwW4XJa1nzV3Y5KwmwZbNeISt ztHQ8DZy4Sj4mZFL6Mw1+irWMEnH/QauYMHEErHbM7+JnGuxbpUhAQ2c/Q8M/vLy7f0v wZsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VSN2/dLk93fIRVrCh8N+0AmorCRCNEabm5sVB7MbO9A=; b=RKqriEYA8Jf8Tg9HjlX0h04N1WFo8MUXxsZbs8A5WCW4RwO3HArAXVsNfhgRtooGSV aLIWPiHZe+dapGXpMyups9EdqHZ5J5VLvG6rs04MNZTXBx8i8207VRfBHyv773CO39Ly nIzk7KMvVAWTw/6B1bKE0rOl4mwc32h8/S3qBHauriULmHplf23q3L9b6zM2A5iDf+Ft 17NgQkOhX5rLA7O+ls35cf/pZ6rzJnw7kTgt1ZOC5O8e6AlGXG/XtY1B9TA58k8c6/Au FfvBih0qgAzgs3URqyJUrDwe9Gv6LY6StNUpo78Ajn8tzI/Y15c4KytPSkomcOidDy4K ValA== X-Gm-Message-State: ANoB5plHiYIyR/3QnGZX4cSxwZinOltTbDucf1oXsm6oPUFKIHgBYA6x +qVgMOsIR2Hl5TbnImjmHk1JiA== X-Google-Smtp-Source: AA0mqf7eZY/U6gUBEczTfy7RT19UpsBoMLFLoSgY1p+EcMD9LW0qs3VPqpFnkdT6sSo2Jsp8NA7oog== X-Received: by 2002:a05:651c:908:b0:26f:db35:ec37 with SMTP id e8-20020a05651c090800b0026fdb35ec37mr6562339ljq.17.1671092379312; Thu, 15 Dec 2022 00:19:39 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u16-20020a2eb810000000b00277041268absm781179ljo.78.2022.12.15.00.19.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Dec 2022 00:19:38 -0800 (PST) Message-ID: Date: Thu, 15 Dec 2022 09:19:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sm6115: Add USB SS qmp phy node To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Cc: agross@kernel.org, bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, konrad.dybcio@linaro.org, andersson@kernel.org References: <20221214203124.564537-1-bhupesh.sharma@linaro.org> <20221214203124.564537-4-bhupesh.sharma@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20221214203124.564537-4-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/12/2022 21:31, Bhupesh Sharma wrote: > Add USB superspeed qmp phy node to dtsi. > Make sure that the oneplus board dts (which includes the > sm4250.dtsi) continues to work as intended. > > Signed-off-by: Bhupesh Sharma > --- > .../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++ > arch/arm64/boot/dts/qcom/sm6115.dtsi | 38 ++++++++++++++++++- > 2 files changed, 39 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > index 3f39f25e0721e..4f0d65574448b 100644 > --- a/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > +++ b/arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dts > @@ -232,6 +232,9 @@ &usb { > &usb_dwc3 { > maximum-speed = "high-speed"; > dr_mode = "peripheral"; > + > + phys = <&usb_hsphy>; > + phy-names = "usb2-phy"; > }; > > &usb_hsphy { > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > index e4ce135264f3d..15f311dcd289f 100644 > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > @@ -579,6 +579,40 @@ usb_hsphy: phy@1613000 { > status = "disabled"; > }; > > + usb_qmpphy: phy@1615000 { > + compatible = "qcom,sm6115-qmp-usb3-phy"; > + reg = <0x01615000 0x200>; > + clocks = <&gcc GCC_USB3_PRIM_PHY_COM_AUX_CLK>, > + <&gcc GCC_USB3_PRIM_CLKREF_CLK>, > + <&gcc GCC_AHB2PHY_USB_CLK>; > + clock-names = "com_aux", > + "ref", > + "cfg_ahb"; > + resets = <&gcc GCC_USB3_PHY_PRIM_SP0_BCR>, > + <&gcc GCC_USB3PHY_PHY_PRIM_SP0_BCR>; > + reset-names = "phy", "phy_phy"; > + status = "disabled"; > + #clock-cells = <1>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + usb_ssphy: phy@1615200 { > + reg = <0x01615200 0x200>, > + <0x01615400 0x200>, > + <0x01615c00 0x400>, > + <0x01615600 0x200>, > + <0x01615800 0x200>, > + <0x01615a00 0x100>; > + #phy-cells = <0>; > + #clock-cells = <1>; > + clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > + clock-names = "pipe0"; > + clock-output-names = "usb3_phy_pipe_clk_src"; > + }; > + }; > + > + Still two blank lines. Best regards, Krzysztof