From: "Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
"Tianping Fang (方天平)" <Tianping.Fang@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks
Date: Fri, 7 Apr 2023 08:03:46 +0000 [thread overview]
Message-ID: <f79700441eddb291d97ee84d89e56e3537c3e0f0.camel@mediatek.com> (raw)
In-Reply-To: <20230404134350.GA3782583-robh@kernel.org>
On Tue, 2023-04-04 at 08:43 -0500, Rob Herring wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On Mon, Apr 03, 2023 at 10:52:29AM +0800, Chunfeng Yun wrote:
> > Add optional clock 'xhci_ck' and 'frmcnt_ck';
> > Add optional property "assigned-clock" and "assigned-clock-
> > parents";
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mediatek,mtu3.yaml | 12
> > ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > index d2655173e108..50c15f2ce14d 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.yaml
> > @@ -66,6 +66,8 @@ properties:
> > - description: Reference clock used by low power mode etc
> > - description: Mcu bus clock for register access
> > - description: DMA bus clock for data transfer
> > + - description: DRD controller clock
> > + - description: Frame count clock
> >
> > clock-names:
> > minItems: 1
> > @@ -74,6 +76,16 @@ properties:
> > - const: ref_ck
> > - const: mcu_ck
> > - const: dma_ck
> > + - const: xhci_ck
> > + - const: frmcnt_ck
> > +
> > + assigned-clocks:
> > + minItems: 1
> > + maxItems: 6
> > +
> > + assigned-clock-parents:
> > + minItems: 1
> > + maxItems: 6
>
> You don't need to include assigned-clocks properties. They are
> implicitly allowed (when clocks is present).
Got it, will modify it, thanks a lot
>
> Rob
next prev parent reply other threads:[~2023-04-07 8:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 2:52 [PATCH 1/7] usb: mtu3: give back request when rx error happens Chunfeng Yun
2023-04-03 2:52 ` [PATCH 2/7] usb: mtu3: use boolean return value Chunfeng Yun
2023-04-03 12:31 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 3/7] usb: mtu3: fix KE at qmu transfer done irq handler Chunfeng Yun
2023-04-03 12:31 ` AngeloGioacchino Del Regno
2023-04-07 7:59 ` Chunfeng Yun (云春峰)
2023-04-07 9:08 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 4/7] usb: mtu3: unlock @mtu->lock just before giving back request Chunfeng Yun
2023-04-03 12:31 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 5/7] usb: mtu3: expose role-switch control to userspace Chunfeng Yun
2023-04-03 12:34 ` AngeloGioacchino Del Regno
2023-04-03 2:52 ` [PATCH 6/7] dt-bindings: usb: mtu3: add two optional clocks Chunfeng Yun
2023-04-04 13:43 ` Rob Herring
2023-04-07 8:03 ` Chunfeng Yun (云春峰) [this message]
2023-04-03 2:52 ` [PATCH 7/7] usb: mtu3: add optional clock xhci_ck and frmcnt_ck Chunfeng Yun
2023-04-03 12:34 ` AngeloGioacchino Del Regno
2023-04-07 8:12 ` Chunfeng Yun (云春峰)
2023-04-03 12:31 ` [PATCH 1/7] usb: mtu3: give back request when rx error happens AngeloGioacchino Del Regno
2023-04-07 7:24 ` Chunfeng Yun (云春峰)
2023-04-17 1:07 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f79700441eddb291d97ee84d89e56e3537c3e0f0.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=Eddie.Hung@mediatek.com \
--cc=Tianping.Fang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).