From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D3CA45F48 for ; Thu, 21 Sep 2023 17:24:02 +0000 (UTC) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 636A945628; Thu, 21 Sep 2023 10:23:34 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 38LHNExm092944; Thu, 21 Sep 2023 12:23:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1695316994; bh=M2urefFnMrpaE3NGHp7ET4+oPQS3ILeoSpVkIqVTMmo=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=XUxukriC9Jnz/EgqmTQ1QvwHTAM0yTZ9n4QWkHit4ojgROexIgmBXpwvkyx3MnFLF JXVH4ZJrixSXp4AchXLe/ZLSD0Xcd1KH7gSA9CK00XB8GVt9aTsqO2PT992QxmjKov Xtim9GRL1I47/ahiJx0HcQPNiKCunmqkM7Pg8RQo= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 38LHNER3038267 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 Sep 2023 12:23:14 -0500 Received: from DFLE110.ent.ti.com (10.64.6.31) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 21 Sep 2023 12:23:13 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 21 Sep 2023 12:23:13 -0500 Received: from [10.250.38.120] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 38LHNDS9061180; Thu, 21 Sep 2023 12:23:13 -0500 Message-ID: Date: Thu, 21 Sep 2023 12:23:12 -0500 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] arm64: dts: ti: am642-evm: Add overlay for NAND expansion card Content-Language: en-US To: Roger Quadros , Nishanth Menon CC: , , , , , , , , Siddharth Vadapalli References: <20230920133450.54226-1-rogerq@kernel.org> <20230920133450.54226-3-rogerq@kernel.org> <20230920135802.3ej2wcuaruqjidel@uncouth> <20230920164424.rrjvm6nvtv4ysyrw@unreal> <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> From: Andrew Davis In-Reply-To: <6f2b38f8-1962-46f2-a095-b1eaf99ed407@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 9/21/23 6:37 AM, Roger Quadros wrote: > On 20/09/2023 20:06, Andrew Davis wrote: >> On 9/20/23 11:44 AM, Nishanth Menon wrote: >>> On 18:18-20230920, Roger Quadros wrote: >>>> >>>> >>>> On 20/09/2023 16:58, Nishanth Menon wrote: >>>>> On 16:34-20230920, Roger Quadros wrote: >>>>>> The NAND expansion card plugs in over the HSE (High Speed Expansion) >>>>>> connector. Add support for it. >>>>>> >>>>>> Signed-off-by: Roger Quadros >>>>>> --- >>>>>>   arch/arm64/boot/dts/ti/Makefile               |   1 + >>>>>>   arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso | 140 ++++++++++++++++++ >>>>>>   2 files changed, 141 insertions(+) >>>>>>   create mode 100644 arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile >>>>>> index 06d6f264f292..ece74085a6be 100644 >>>>>> --- a/arch/arm64/boot/dts/ti/Makefile >>>>>> +++ b/arch/arm64/boot/dts/ti/Makefile >>>>>> @@ -29,6 +29,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb >>>>>>     # Boards with AM64x SoC >>>>>>   dtb-$(CONFIG_ARCH_K3) += k3-am642-evm.dtb >>>>>> +dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtbo >>>>>>   dtb-$(CONFIG_ARCH_K3) += k3-am642-phyboard-electra-rdk.dtb >>>>>>   dtb-$(CONFIG_ARCH_K3) += k3-am642-sk.dtb >>>>>>   dtb-$(CONFIG_ARCH_K3) += k3-am642-tqma64xxl-mbax4xxl.dtb >>>>> >>>>> Also see https://lore.kernel.org/all/20230911165610.GA1362932-robh@kernel.org/ >>>>> >>>>> you may not get the dtbo installed when doing make dtbs_install >>>>> >>>>> [...] >>>>> >>>> >>>> $ v8make dtbs_install INSTALL_DTBS_PATH=/tmp >>>>    INSTALL /tmp/ti/k3-am625-beagleplay.dtb >>>>    INSTALL /tmp/ti/k3-am625-phyboard-lyra-rdk.dtb >>>>    INSTALL /tmp/ti/k3-am625-sk.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dahlia.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-nonwifi-dev.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-nonwifi-yavia.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-wifi-dahlia.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-wifi-dev.dtb >>>>    INSTALL /tmp/ti/k3-am625-verdin-wifi-yavia.dtb >>>>    INSTALL /tmp/ti/k3-am62-lp-sk.dtb >>>>    INSTALL /tmp/ti/k3-am62x-sk-hdmi-audio.dtbo >>>>    INSTALL /tmp/ti/k3-am62a7-sk.dtb >>>>    INSTALL /tmp/ti/k3-am62p5-sk.dtb >>>>    INSTALL /tmp/ti/k3-am642-evm.dtb >>>>    INSTALL /tmp/ti/k3-am642-evm-nand.dtbo >>>> ^^^^ >>>>    INSTALL /tmp/ti/k3-am642-phyboard-electra-rdk.dtb >>>>    INSTALL /tmp/ti/k3-am642-sk.dtb >>>> >>>> >>>> What did I miss? >>> >>> I missed it, actually. See Rob's comment: >>> https://lore.kernel.org/all/CAL_Jsq+GR3hP6hFvFn2z5aXvSXnh9butD3aKZ-y_XJgx0_YPTw@mail.gmail.com/ >>> >>> Having orphan dtbo is apparently frowned upon >>> >> >> And if you apply these overlays to the base DTB then it gets >> symbols added automatically, no need for your patch [1/2] here. >> > > Is this OK? > > k3-am642-evm-nand-dtbs := k3-am642-evm.dtb k3-am642-evm-nand.dtbo > dtb-$(CONFIG_ARCH_K3) += k3-am642-evm-nand.dtb > > So patch 1 is not required in this case but we have an > extra dtb file which is not really required. > While I agree we will end up with several pre-overlayed DTB files that are arguably not required as they could be later built/applied, until we find a better way to check at build time these overlays need applied to something as a test. > I have 2 more issues to point out > > 1) > With existing examples e.g. J7200 EVM > wouldn't k3-j7200-evm.dtb include the k3-j7200-evm-quad-port-eth-exp.dtbo? > Is this what we really want? > > likewise for k3-j721e-evm.dtb and k3-am654-gp-evm.dtb > Yes, that is the idea, the base-board.dtb is just the raw main board, but the "EVM" when you buy it comes with the quad-port daughtercard attached. That is what we consider the "EVM" and the DTB names match that. > 2) > Another issue (unrelated to this change) is the below warning: > > arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #address-cells value > arch/arm64/boot/dts/ti/k3-am642-evm-nand.dtso:65.8-140.3: Warning (avoid_default_addr_size): /fragment@3/__overlay__: Relying on default #size-cells value > > This is because we use the 'ranges' property in the gpmc0 node > and the compiler doesn't know the #address/size-cells of the > parent node. > > Is there a trick to specify it in the dtso file? > Hmm, seems like a tricky one. Do you really need to do the ranges here? Could you use the default `ranges;` for gpmc0? Then do the range translation down inside the nand node to keep the partition addresses sane. Andrew