Re: [PATCH v1 1/3] ASoC: dt-bindings: nau8822: convert to the dtschema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 23/12/2022 18:04, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Convert nau8822 devicetree binding to dtschema.
> Change file name to match dtschema naming.
> 
> Cc: David Lin <CTLIN0@nuvoton.com>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  .../devicetree/bindings/sound/nau8822.txt     | 16 --------
>  .../bindings/sound/nuvoton,nau8822.yaml       | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/nau8822.txt b/Documentation/devicetree/bindings/sound/nau8822.txt
> deleted file mode 100644
> index a471d162d4e5..000000000000
> --- a/Documentation/devicetree/bindings/sound/nau8822.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -NAU8822 audio CODEC
> -
> -This device supports I2C only.
> -
> -Required properties:
> -
> -  - compatible : "nuvoton,nau8822"
> -
> -  - reg : the I2C address of the device.
> -
> -Example:
> -
> -codec: nau8822@1a {
> -	compatible = "nuvoton,nau8822";
> -	reg = <0x1a>;
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> new file mode 100644
> index 000000000000..10464170a98f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nuvoton,nau8822.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NAU8822 audio CODEC
> +
> +description: |
> +  24 bit stereo audio codec with speaker driver.
> +  This device supports I2C/SPI. Currently, only I2C bus is supported.

I would skip the last sentence - bindings are independent of OS, so the
sentence might be not true in different systems/versions.

> +
> +maintainers:
> +  - David Lin <CTLIN0@nuvoton.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,nau8822
> +
> +  reg:
> +    maxItems: 1
> +
> +additionalProperties: false

Please put "additionalProperties" after "required:".

With above (or even without these):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof