[PATCH v1 0/3] ASoC: nau8822: add speaker Bridge Tied Output

[PATCH v1 0/3] ASoC: nau8822: add speaker Bridge Tied Output

[Francesco Dolcini]

From: Francesco Dolcini <francesco.dolcini@toradex.com>

Add support for BTL (Bridge Tied Load) configuration to NAU8822 audio codec,
since this requires adding a new property to the binding convert it from
txt to yaml first.

Emanuele Ghidoli (3):
  ASoC: dt-bindings: nau8822: convert to the dtschema
  ASoC: dt-bindings: nau8822: add nuvoton,spk-btl property to dtschema
  ASoC: nau8822: add speaker Bridge Tied Output configuration

 .../devicetree/bindings/sound/nau8822.txt     | 16 -------
 .../bindings/sound/nuvoton,nau8822.yaml       | 46 +++++++++++++++++++
 sound/soc/codecs/nau8822.c                    |  9 ++++
 sound/soc/codecs/nau8822.h                    |  9 ++++
 4 files changed, 64 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml

-- 
2.25.1

[PATCH v1 1/3] ASoC: dt-bindings: nau8822: convert to the dtschema

[Francesco Dolcini]

From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

Convert nau8822 devicetree binding to dtschema.
Change file name to match dtschema naming.

Cc: David Lin <CTLIN0@nuvoton.com>
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../devicetree/bindings/sound/nau8822.txt     | 16 --------
 .../bindings/sound/nuvoton,nau8822.yaml       | 40 +++++++++++++++++++
 2 files changed, 40 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
 create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml

diff --git a/Documentation/devicetree/bindings/sound/nau8822.txt b/Documentation/devicetree/bindings/sound/nau8822.txt
deleted file mode 100644
index a471d162d4e5..000000000000
--- a/Documentation/devicetree/bindings/sound/nau8822.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-NAU8822 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-  - compatible : "nuvoton,nau8822"
-
-  - reg : the I2C address of the device.
-
-Example:
-
-codec: nau8822@1a {
-	compatible = "nuvoton,nau8822";
-	reg = <0x1a>;
-};
diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
new file mode 100644
index 000000000000..10464170a98f
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nuvoton,nau8822.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NAU8822 audio CODEC
+
+description: |
+  24 bit stereo audio codec with speaker driver.
+  This device supports I2C/SPI. Currently, only I2C bus is supported.
+
+maintainers:
+  - David Lin <CTLIN0@nuvoton.com>
+
+properties:
+  compatible:
+    enum:
+      - nuvoton,nau8822
+
+  reg:
+    maxItems: 1
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            compatible = "nuvoton,nau8822";
+            reg = <0x1a>;
+        };
+    };
-- 
2.25.1

Re: [PATCH v1 1/3] ASoC: dt-bindings: nau8822: convert to the dtschema

[Rob Herring]

On Fri, 23 Dec 2022 18:04:02 +0100, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Convert nau8822 devicetree binding to dtschema.
> Change file name to match dtschema naming.
> 
> Cc: David Lin <CTLIN0@nuvoton.com>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  .../devicetree/bindings/sound/nau8822.txt     | 16 --------
>  .../bindings/sound/nuvoton,nau8822.yaml       | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> 

Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221223170404.210603-2-francesco@dolcini.it


audio-codec@1a: '#sound-dai-cells', 'AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
	arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
	arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb

Re: [PATCH v1 1/3] ASoC: dt-bindings: nau8822: convert to the dtschema

[Francesco Dolcini]

Il 23 dicembre 2022 20:26:02 CET, Rob Herring <robh@kernel.org> ha scritto:
>
>On Fri, 23 Dec 2022 18:04:02 +0100, Francesco Dolcini wrote:
>> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>> 
>> Convert nau8822 devicetree binding to dtschema.
>> Change file name to match dtschema naming.
>> 
>> Cc: David Lin <CTLIN0@nuvoton.com>
>> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>> ---
>>  .../devicetree/bindings/sound/nau8822.txt     | 16 --------
>>  .../bindings/sound/nuvoton,nau8822.yaml       | 40 +++++++++++++++++++
>>  2 files changed, 40 insertions(+), 16 deletions(-)
>>  delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
>>  create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
>> 
>
>Running 'make dtbs_check' with the schema in this patch gives the
>following warnings. Consider if they are expected or the schema is
>incorrect. These may not be new warnings.
>

Expected, those DTS files needs to be fixed, I'll have a separate patch for those.



>Note that it is not yet a requirement to have 0 warnings for dtbs_check.
>This will change in the future.
>
>Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221223170404.210603-2-francesco@dolcini.it
>
>
>audio-codec@1a: '#sound-dai-cells', 'AVDD-supply', 'CPVDD-supply', 'DBVDD-supply', 'DCVDD-supply', 'MICVDD-supply', 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+'
>	arch/arm64/boot/dts/freescale/imx8mm-verdin-nonwifi-dev.dtb
>	arch/arm64/boot/dts/freescale/imx8mm-verdin-wifi-dev.dtb
>

Re: [PATCH v1 1/3] ASoC: dt-bindings: nau8822: convert to the dtschema

[Krzysztof Kozlowski]

On 23/12/2022 18:04, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Convert nau8822 devicetree binding to dtschema.
> Change file name to match dtschema naming.
> 
> Cc: David Lin <CTLIN0@nuvoton.com>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  .../devicetree/bindings/sound/nau8822.txt     | 16 --------
>  .../bindings/sound/nuvoton,nau8822.yaml       | 40 +++++++++++++++++++
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/nau8822.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> 
> diff --git a/Documentation/devicetree/bindings/sound/nau8822.txt b/Documentation/devicetree/bindings/sound/nau8822.txt
> deleted file mode 100644
> index a471d162d4e5..000000000000
> --- a/Documentation/devicetree/bindings/sound/nau8822.txt
> +++ /dev/null
> @@ -1,16 +0,0 @@
> -NAU8822 audio CODEC
> -
> -This device supports I2C only.
> -
> -Required properties:
> -
> -  - compatible : "nuvoton,nau8822"
> -
> -  - reg : the I2C address of the device.
> -
> -Example:
> -
> -codec: nau8822@1a {
> -	compatible = "nuvoton,nau8822";
> -	reg = <0x1a>;
> -};
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> new file mode 100644
> index 000000000000..10464170a98f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/nuvoton,nau8822.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NAU8822 audio CODEC
> +
> +description: |
> +  24 bit stereo audio codec with speaker driver.
> +  This device supports I2C/SPI. Currently, only I2C bus is supported.

I would skip the last sentence - bindings are independent of OS, so the
sentence might be not true in different systems/versions.

> +
> +maintainers:
> +  - David Lin <CTLIN0@nuvoton.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - nuvoton,nau8822
> +
> +  reg:
> +    maxItems: 1
> +
> +additionalProperties: false

Please put "additionalProperties" after "required:".

With above (or even without these):

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH v1 2/3] ASoC: dt-bindings: nau8822: add nuvoton,spk-btl property to dtschema

[Francesco Dolcini]

From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

Add nuvoton,spk-btl to configure the two loudspeaker outputs
as Bridge Tied Load

Cc: David Lin <CTLIN0@nuvoton.com>
Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 .../devicetree/bindings/sound/nuvoton,nau8822.yaml          | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
index 10464170a98f..700c57698133 100644
--- a/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
+++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8822.yaml
@@ -21,6 +21,12 @@ properties:
   reg:
     maxItems: 1
 
+  nuvoton,spk-btl:
+    description:
+      If set, configure the two loudspeaker outputs as a Bridge Tied Load output
+      to drive a high power external loudspeaker.
+    $ref: /schemas/types.yaml#/definitions/flag
+
 additionalProperties: false
 
 required:
-- 
2.25.1

Re: [PATCH v1 2/3] ASoC: dt-bindings: nau8822: add nuvoton,spk-btl property to dtschema

[Krzysztof Kozlowski]

On 23/12/2022 18:04, Francesco Dolcini wrote:
> From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> 
> Add nuvoton,spk-btl to configure the two loudspeaker outputs
> as Bridge Tied Load
> 
> Cc: David Lin <CTLIN0@nuvoton.com>
> Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH v1 3/3] ASoC: nau8822: add speaker Bridge Tied Output configuration

[Francesco Dolcini]

From: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>

Allow configuring the two loudspeaker outputs as a
single Bridge Tied Load output getting higher output power.

Signed-off-by: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 sound/soc/codecs/nau8822.c | 9 +++++++++
 sound/soc/codecs/nau8822.h | 9 +++++++++
 2 files changed, 18 insertions(+)

diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c
index 1aef281a9972..d5006d8de639 100644
--- a/sound/soc/codecs/nau8822.c
+++ b/sound/soc/codecs/nau8822.c
@@ -1056,6 +1056,7 @@ static const int update_reg[] = {
 static int nau8822_probe(struct snd_soc_component *component)
 {
 	int i;
+	struct device_node *of_node = component->dev->of_node;
 
 	/*
 	 * Set the update bit in all registers, that have one. This way all
@@ -1066,6 +1067,14 @@ static int nau8822_probe(struct snd_soc_component *component)
 		snd_soc_component_update_bits(component,
 			update_reg[i], 0x100, 0x100);
 
+	/* Check property to configure the two loudspeaker outputs as
+	 * a single Bridge Tied Load output
+	 */
+	if (of_property_read_bool(of_node, "nuvoton,spk-btl"))
+		snd_soc_component_update_bits(component,
+					      NAU8822_REG_RIGHT_SPEAKER_CONTROL,
+					      NAU8822_RSUBBYP, NAU8822_RSUBBYP);
+
 	return 0;
 }
 
diff --git a/sound/soc/codecs/nau8822.h b/sound/soc/codecs/nau8822.h
index 547ec057f853..646f6bb64bc5 100644
--- a/sound/soc/codecs/nau8822.h
+++ b/sound/soc/codecs/nau8822.h
@@ -187,6 +187,15 @@
 /* NAU8822_REG_PLL_K3 (0x27) */
 #define NAU8822_PLLK3_MASK			0x1FF
 
+/* NAU8822_REG_RIGHT_SPEAKER_CONTROL (0x2B) */
+#define NAU8822_RMIXMUT				0x20
+#define NAU8822_RSUBBYP				0x10
+
+#define NAU8822_RAUXRSUBG_SFT			1
+#define NAU8822_RAUXRSUBG_MASK			0x0E
+
+#define NAU8822_RAUXSMUT			0x01
+
 /* System Clock Source */
 enum {
 	NAU8822_CLK_MCLK,
-- 
2.25.1

Re: [PATCH v1 0/3] ASoC: nau8822: add speaker Bridge Tied Output

[Mark Brown]

On Fri, 23 Dec 2022 18:04:01 +0100, Francesco Dolcini wrote:
> Add support for BTL (Bridge Tied Load) configuration to NAU8822 audio codec,
> since this requires adding a new property to the binding convert it from
> txt to yaml first.
> 
> Emanuele Ghidoli (3):
>   ASoC: dt-bindings: nau8822: convert to the dtschema
>   ASoC: dt-bindings: nau8822: add nuvoton,spk-btl property to dtschema
>   ASoC: nau8822: add speaker Bridge Tied Output configuration
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: dt-bindings: nau8822: convert to the dtschema
      commit: 76fa6279eff931b43482f0bef5d65cdcf325de87
[2/3] ASoC: dt-bindings: nau8822: add nuvoton,spk-btl property to dtschema
      (no commit info)
[3/3] ASoC: nau8822: add speaker Bridge Tied Output configuration
      commit: 968b42069fe5dab362b623c6b8a1565709a12f5b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark