From: Nitin Yadav <n-yadav@ti.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <nm@ti.com>,
<vigneshr@ti.com>, <rogerq@ti.com>
Cc: <kristo@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<catalin.marinas@arm.com>, <will@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support
Date: Thu, 14 Sep 2023 14:56:29 +0530 [thread overview]
Message-ID: <f7bebc22-d494-f54d-5543-db75f5714a52@ti.com> (raw)
In-Reply-To: <32c82fa2-f8b9-d22d-f0ac-f8d6e48df39d@linaro.org>
Hi Krzysztof,
On 14/09/23 11:57, Krzysztof Kozlowski wrote:
> On 13/09/2023 13:47, Nitin Yadav wrote:
>> Add support for AM62Q NAND card: X8 NAND EXPANSION
>> BOARD card (PROC143E1) for AM62x LP SK board.
>>
>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 29 ++++++++++++++++++++++++
>> arch/arm64/boot/dts/ti/k3-am62.dtsi | 2 ++
>> 2 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> index 284b90c94da8..e93e79d8083f 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
>> @@ -955,4 +955,33 @@ mcasp2: audio-controller@2b20000 {
>> power-domains = <&k3_pds 192 TI_SCI_PD_EXCLUSIVE>;
>> status = "disabled";
>> };
>> + gpmc0: memory-controller@3b000000 {
>> + status = "disabled";
>
> status is never first in DTSI. Really, where did you see such code?
Thank for pointing out, Will send a revised version.
>
>> + compatible = "ti,am64-gpmc";
>> + power-domains = <&k3_pds 80 TI_SCI_PD_EXCLUSIVE>;
>
> First is compatible, second is reg/reg-names/ranges.
>
>
> Best regards,
> Krzysztof
>
--
Regards,
Nitin
next prev parent reply other threads:[~2023-09-14 9:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 11:47 [PATCH 0/3] Add support for GPMC NAND Nitin Yadav
2023-09-13 11:47 ` [PATCH 1/3] arm64: dts: ti: Add GPMC NAND support Nitin Yadav
2023-09-14 6:27 ` Krzysztof Kozlowski
2023-09-14 9:26 ` Nitin Yadav [this message]
2023-09-14 16:04 ` Nishanth Menon
2023-09-15 9:23 ` Nitin Yadav
2023-09-15 12:22 ` Nishanth Menon
2023-09-15 11:16 ` Roger Quadros
2023-09-13 11:47 ` [PATCH 2/3] arm64: dts: ti: Add GPMC NAND overlay Nitin Yadav
2023-09-13 11:47 ` [PATCH 3/3] arm64: defconfig: Enable GPMC NAND support Nitin Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7bebc22-d494-f54d-5543-db75f5714a52@ti.com \
--to=n-yadav@ti.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=vigneshr@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).