From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 854B6C433EF for ; Mon, 4 Jul 2022 09:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232935AbiGDJyI (ORCPT ); Mon, 4 Jul 2022 05:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229961AbiGDJyI (ORCPT ); Mon, 4 Jul 2022 05:54:08 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411ABD12F; Mon, 4 Jul 2022 02:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656928447; x=1688464447; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=lSh2EbbxhUgUat8Nrxc/d9fNoMjhwQg9R6qR3jGL+Ug=; b=etdLVxMjDFb/UKPjtQGcTIFJFAjSwOPkNzXL8uLd++krQc0HvSKUpAVL WaSf//U9/U223LyZcJ0gMTpv6au4MAdy2wgxb0SQbya7bKqrNR9l82DKO Ae5ZyD02T1Bq6IOXT7C5ZLND3zBgs6bxnu/WOkHad1Gh6ltRnx59I8xHt eSFb1XwNwW0YGJtqHRof36MocKARPSJcoLsIbzg1mCIQWh4PpUSW9NPTW rjS3+So51Dv+0UUT0OKKboYPO0CCSY7kajBmoJQJfQE0WKD+DLleUHSqY dgYc0c9hh+h/NjVr1+MBPDIzZKHy3EeX+pNHj7fxnyf/fsKxNjDB1LXw4 A==; X-IronPort-AV: E=McAfee;i="6400,9594,10397"; a="263511023" X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="263511023" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:54:07 -0700 X-IronPort-AV: E=Sophos;i="5.92,243,1650956400"; d="scan'208";a="649512912" Received: from bclindho-mobl.ger.corp.intel.com ([10.252.49.27]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jul 2022 02:54:01 -0700 Date: Mon, 4 Jul 2022 12:53:58 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Lino Sanfilippo cc: Andy Shevchenko , Greg Kroah-Hartman , Jiri Slaby , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Vladimir Zapolskiy , linux-arm Mailing List , devicetree , "open list:SERIAL DRIVERS" , Linux Kernel Mailing List , Lukas Wunner , p.rosenberger@kunbus.com, Lino Sanfilippo Subject: Re: [PATCH v2 7/9] serial: ar933x: Fix check for RS485 support In-Reply-To: Message-ID: References: <20220703170039.2058202-1-LinoSanfilippo@gmx.de> <20220703170039.2058202-8-LinoSanfilippo@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 4 Jul 2022, Lino Sanfilippo wrote: > On 03.07.22 20:39, Andy Shevchenko wrote: > > On Sun, Jul 3, 2022 at 7:02 PM Lino Sanfilippo wrote: > >> > >> From: Lino Sanfilippo > >> > >> Without an RTS GPIO RS485 is not possible so disable the support > >> regardless of whether RS485 is enabled at boottime or not. Also remove the > > > > boot time > > > >> now superfluous check for the RTS GPIO in ar933x_config_rs485(). > >> > >> Fixes: e849145e1fdd ("serial: ar933x: Fill in rs485_supported") > > > > Is it an independent fix? If so, it should be the first patch in the > > series, otherwise if it's dependent on something from previous patches > > you need to mark all of them as a fix. > > > > The fix is independent, patch 8 depends on the fix however. I was not > aware of this fixes-first rule for series with patches that are independent > from each other. I will change the order accordingly in the next version of the series. While at it, you could separate just the fix to own patch and the ->rs485_config() cleanup to own patch (or move it all to patch 8). Not that this fix is expected to go anywhere else besides tty-next. -- i.