From: Randy Dunlap <rdunlap@infradead.org>
To: Tim Harvey <tharvey@gateworks.com>,
Lee Jones <lee.jones@linaro.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Jones <rjones@gateworks.com>
Subject: Re: [PATCH v6 3/3] hwmon: add Gateworks System Controller support
Date: Tue, 17 Mar 2020 10:03:53 -0700 [thread overview]
Message-ID: <f7ccbdb4-917a-2dd7-bf6b-8c82b87bc167@infradead.org> (raw)
In-Reply-To: <1584464453-28200-4-git-send-email-tharvey@gateworks.com>
On 3/17/20 10:00 AM, Tim Harvey wrote:
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 23dfe84..99dae13 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -494,6 +494,15 @@ config SENSORS_F75375S
> This driver can also be built as a module. If so, the module
> will be called f75375s.
>
> +config SENSORS_GSC
> + tristate "Gateworks System Controller ADC"
> + depends on MFD_GATEWORKS_GSC
> + help
> + Support for the Gateworks System Controller A/D converters.
Hi Tim,
Those 4 lines above should be using tabs for indentation.
+ 2 spaces on the final "Support" line.
> +
> + To compile this driver as a module, choose M here:
> + the module will be called gsc-hwmon.
> +
> config SENSORS_MC13783_ADC
> tristate "Freescale MC13783/MC13892 ADC"
> depends on MFD_MC13XXX
--
~Randy
next prev parent reply other threads:[~2020-03-17 17:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 17:00 [PATCH v6 0/3] Add support for the Gateworks System Controller Tim Harvey
2020-03-17 17:00 ` [PATCH v6 1/3] dt-bindings: mfd: Add Gateworks System Controller bindings Tim Harvey
2020-03-20 3:15 ` Rob Herring
2020-03-17 17:00 ` [PATCH v6 2/3] mfd: add Gateworks System Controller core driver Tim Harvey
2020-03-17 17:00 ` [PATCH v6 3/3] hwmon: add Gateworks System Controller support Tim Harvey
2020-03-17 17:03 ` Randy Dunlap [this message]
2020-03-17 17:07 ` Tim Harvey
2020-03-17 17:18 ` Guenter Roeck
2020-03-17 17:44 ` Tim Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7ccbdb4-917a-2dd7-bf6b-8c82b87bc167@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rjones@gateworks.com \
--cc=robh+dt@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).