From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2A11C433EF for ; Thu, 14 Jul 2022 10:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbiGNKmW (ORCPT ); Thu, 14 Jul 2022 06:42:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238428AbiGNKmS (ORCPT ); Thu, 14 Jul 2022 06:42:18 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23AC854C95 for ; Thu, 14 Jul 2022 03:42:15 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id a10so1684482ljj.5 for ; Thu, 14 Jul 2022 03:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=s8VpnwHhFZWAVYlNIpH9kdWPTbLI6uI4nckrgHC8pmM=; b=w/T9awmLctnifdlcq+QcujLO7NnFl5WH8vXOpLTcy4qrV5vlHZnKOR1CMzdQcuaPgQ HBNJFHC7ZV4d9G3OVwfea+iRJf1w0kWXl93CD0JyTwukccUZiFkgBkdzc0ae6gfWFV6P A/E+Leq2hzYRI9/3vg2gWrmAhRoDRxMxLI5f1FonpBWVeVR8+Wqi323+boh/VD06g9Jo pMBw3mYS33cAygwv9iKCsymMQ7jhOrgY5anq3GrH5CBqAonr8SoRUm6syMTN2OMAj7Ti tOLkmLcwPFgpEfy6zdwhs0jzCl3TGJvV2Emgv/ZT5DwSDg75YoXnyVwqqE2syaIBVpTj WPxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s8VpnwHhFZWAVYlNIpH9kdWPTbLI6uI4nckrgHC8pmM=; b=CapDpEHTsfI1M3UmFnIlgG/Rio7tyzBOW0+7oD2eTaKQe7f68013UrJdQU2lH7Oh8i qohVBWL+pXsh8pIXMF5STaN4Y37pvVGwXNpvXO5L3Ayrcar5DOiLX0zmhFRzDQEJX0pm wvD4aj5xXfkIJ10kvLgUaLucCRVxD/S+rHrbFfYJZ+nQz1qgjcYqOsRoTmxt2VCTeJYw YtM4ByEEqbCcG15oxeg2+i/Z+HV2SbojZ2qxAD8BMcbiKykUxLiIiUqNaxIn8tRxlCfm 8jFAso6MtN3pV/8Ihyh6gRL3XOs77M475bxDHrwD35W9O8SlUUmgMY/KkuqLMb/ZyWW7 o5Gg== X-Gm-Message-State: AJIora9n4TvxJdDZtOCIvcJxZ8KykV2cHElDfg3dfI8renid9K/cP0tW SL9Po+ENkVujYs47Ga8fVpN27w== X-Google-Smtp-Source: AGRyM1vDS7gTXDdroBeSqdLza2aD+ghoINa7WVmkHLbyGd09X2av2JkhdGocs3fMe6JT2umowMWNuw== X-Received: by 2002:a2e:8719:0:b0:25d:7650:6c06 with SMTP id m25-20020a2e8719000000b0025d76506c06mr4159705lji.330.1657795333568; Thu, 14 Jul 2022 03:42:13 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id p22-20020a2eba16000000b0025d87966100sm209373lja.140.2022.07.14.03.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Jul 2022 03:42:13 -0700 (PDT) Message-ID: Date: Thu, 14 Jul 2022 12:42:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 03/30] dt-bindings: phy: qcom,qmp: drop redundant descriptions Content-Language: en-US To: Johan Hovold Cc: Johan Hovold , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220707134725.3512-1-johan+linaro@kernel.org> <20220707134725.3512-4-johan+linaro@kernel.org> <26916d41-f398-8527-96f4-9a28f4f4e789@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/07/2022 12:00, Johan Hovold wrote: > On Thu, Jul 14, 2022 at 11:07:21AM +0200, Krzysztof Kozlowski wrote: >> On 07/07/2022 15:46, Johan Hovold wrote: >>> Drop the redundant supply and clock descriptions which did not add much >>> information beyond what can be inferred from the corresponding resource >>> names. >>> >>> Signed-off-by: Johan Hovold >> >> >> (...) >> >>> - const: ref >>> - const: refgen >>> resets: >>> - items: >>> - - description: reset of phy block. >>> + maxItems: 1 >>> reset-names: >>> items: >>> - const: phy >>> @@ -376,11 +334,7 @@ allOf: >>> then: >>> properties: >>> clocks: >>> - items: >>> - - description: Phy aux clock. >>> - - description: 19.2 MHz ref clk source. >>> - - description: 19.2 MHz ref clk. >> >> Here and in other places - I think you loose information, because the >> frequency is not mentioned in clock name. > > Right, but it is also arguable redundant information for the binding > (similar for the vdda-pll voltage). True. > > I can add a comment after the name if you prefer that? Ah, skip it. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof