From: "Arnd Bergmann" <arnd@arndb.de>
To: "Stanley Chang" <stanley_chang@realtek.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: "Vinod Koul" <vkoul@kernel.org>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Ray Chi" <raychi@google.com>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Eugeniu Rosca" <erosca@de.adit-jv.com>,
"Michael Grzeschik" <m.grzeschik@pengutronix.de>,
"Matthias Kaehlcke" <mka@chromium.org>,
"Flavio Suligoi" <f.suligoi@asem.it>,
"Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Bhuvanesh Surachari" <Bhuvanesh_Surachari@mentor.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY
Date: Fri, 19 May 2023 13:01:34 +0200 [thread overview]
Message-ID: <f7edea0c-dbfe-4c16-8134-0656411a837d@app.fastmail.com> (raw)
In-Reply-To: <0ee8a26205a041cab9a787ec29201a9f@realtek.com>
On Fri, May 19, 2023, at 12:58, Stanley Chang[昌育德] wrote:
>>
>> I'm pretty sure that drivers/usb/phy/ is deprecated now...
>>
>> New drivers should be written for the generic PHY subsystem in
>> drivers/phy/.
Indeed, I missed that in my review.
> Thanks for your reminder.
> Will drivers/usb/phy be removed?
> Is it not allowed to add new drivers?
>
> In our application, driver/phy is not suitable.
> We need to notify the phy driver when the USB hub port status changes.
> However, generic PHY drivers are designed for various device's PHY.
> And it seems inappropriate to add this function. So we choose to use
> driver/usb/phy.
If you run into something that works in the old usbphy layer
but can't be done in drivers/phy, I think the better solution
would be to change the drivers/phy/ code to add this.
Arnd
next prev parent reply other threads:[~2023-05-19 11:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 4:58 [PATCH v1 1/3] usb: phy: add usb phy notify port status API Stanley Chang
2023-05-19 4:58 ` [PATCH v1 2/3] usb: phy: Add driver for the Realtek SoC USB 2.0/3.0 PHY Stanley Chang
2023-05-19 6:28 ` Arnd Bergmann
2023-05-19 10:40 ` Stanley Chang[昌育德]
2023-05-19 8:16 ` Paul Cercueil
2023-05-19 10:58 ` Stanley Chang[昌育德]
2023-05-19 11:01 ` Arnd Bergmann [this message]
2023-05-19 17:40 ` Vinod Koul
2023-05-20 5:18 ` Stanley Chang[昌育德]
2023-05-20 5:10 ` Stanley Chang[昌育德]
2023-05-20 9:04 ` kernel test robot
2023-05-19 4:58 ` [PATCH v1 3/3] dt-bindings: phy: realtek: Add the doc about " Stanley Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7edea0c-dbfe-4c16-8134-0656411a837d@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Bhuvanesh_Surachari@mentor.com \
--cc=bagasdotme@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=erosca@de.adit-jv.com \
--cc=f.suligoi@asem.it \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=mathias.nyman@linux.intel.com \
--cc=mka@chromium.org \
--cc=paul@crapouillou.net \
--cc=raychi@google.com \
--cc=robh+dt@kernel.org \
--cc=stanley_chang@realtek.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).