From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA0A2C4332F for ; Wed, 2 Nov 2022 16:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231665AbiKBQah (ORCPT ); Wed, 2 Nov 2022 12:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbiKBQaL (ORCPT ); Wed, 2 Nov 2022 12:30:11 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC6B117E13 for ; Wed, 2 Nov 2022 09:26:18 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id t1so7305360wmi.4 for ; Wed, 02 Nov 2022 09:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=zv7Fq5k50QWQLxnPbss2vXizhHRaHgo0CLWyEMOtNXY=; b=XLT+2bOf52xM6JdQqN+Tbi3UN/LLLCaptLMtL5KvSTYPvI/lUr4ONN2+m47aatNmUE rdrtReOAY4RmLpenQiqcMEofRRUhxktec1oIjlF4j6H6wmkxi5XEDnpOZ9QGJaSBxv+F LhWZTjMyJ0KzHsT2tice4ZplDy8smvhGjPpxQ+xekviGu2gOZfr+P+dYshaOnkeqsqVi uLKwI/Sm12ueV22i0iRvO64/ABCyk4cZb6c2neFCEhma60LYtaOmfJBEUoWMY7xkEKJ/ WLGsayqA2AIVW/hhoObdJU0oqJ/+fBkdyyFvsfYKhIOtXxaDfx5ozca5oUxePLiG0MUO U5Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zv7Fq5k50QWQLxnPbss2vXizhHRaHgo0CLWyEMOtNXY=; b=iU9TRjJE/JUjD+vjCLeGB0tOcxYEzY1afHGWKW64eOiGQYhqBNUy6pPFpuhgJYipdB 5u5hVP4i36HKvu8vnPvq3ka8IZ2saV0p3O2n1yeWhYQRBZNBBrR5klPqtSefsq0pyh30 WYXAMFDoBd9YUWnV2G647IZ0xsy8ZqwqT4+lomzkdxttZxNTDpFyh04rRqIZm5/8olSd qZliD9utvUTApO/MmE4iS0WsCze8yt15L7Vy3pCIs1DB019Ri+1+dDkz4DJQls/0D50X H2ahVTo5zxc/rgRbcs5hf3VkfONtGY2HobHLP0i6msKZK8I5p9rB8SxpetHDM3UAq5IH e0DQ== X-Gm-Message-State: ACrzQf1k74I+duUC0JHOhYX4BFPQaovjqlM3yqsqzZEuoHC7FuGM/4BQ /bZkNHlfy4rAZpvDdSlKBXGIyA== X-Google-Smtp-Source: AMsMyM58DL/hkAn4DnGcSmAn4Lnobs2eqhlbRBLy1/I33qod5riKNI2cBWPxvRt82gxskj2IR0PZIw== X-Received: by 2002:a05:600c:4ed1:b0:3cf:86ab:3a0f with SMTP id g17-20020a05600c4ed100b003cf86ab3a0fmr2853053wmq.106.1667406377451; Wed, 02 Nov 2022 09:26:17 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:3541:e8cb:4c8c:e204? ([2a01:e0a:982:cbb0:3541:e8cb:4c8c:e204]) by smtp.gmail.com with ESMTPSA id v7-20020a05600c444700b003c70191f267sm2844571wmn.39.2022.11.02.09.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 09:26:17 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 17:26:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 1/4] dt-bindings: reset: document Odroid Go Ultra power-off Content-Language: en-US To: Rob Herring Cc: Martin Blumenstingl , Krzysztof Kozlowski , Kevin Hilman , Sebastian Reichel , Jerome Brunet , linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org References: <20221031-b4-odroid-go-ultra-initial-v1-0-42e3dbea86d5@linaro.org> <20221031-b4-odroid-go-ultra-initial-v1-1-42e3dbea86d5@linaro.org> <20221102162344.GA3993882-robh@kernel.org> Organization: Linaro Developer Services In-Reply-To: <20221102162344.GA3993882-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On 02/11/2022 17:23, Rob Herring wrote: > On Mon, Oct 31, 2022 at 05:47:25PM +0100, Neil Armstrong wrote: >> The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> to its two PMICs in order, this represents the poweroff scheme needed to complet >> a clean poeroff of the system. >> >> Signed-off-by: Neil Armstrong >> --- >> .../reset/hardkernel,odroid-go-ultra-poweroff.yaml | 42 ++++++++++++++++++++++ >> 1 file changed, 42 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> new file mode 100644 >> index 000000000000..65e42258717c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml >> @@ -0,0 +1,42 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/power/reset/hardkernel,odroid-go-ultra-poweroff.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hardkernel Odroid Go Ultra poweroff >> + >> +maintainers: >> + - Neil Armstrong >> + >> +description: >> + The Hardkernel Odroid Go Ultra poweroff scheme requires requesting a poweroff >> + to its two PMICs in order, this represents the poweroff scheme needed to complete >> + a clean poeroff of the system. > > You don't really need a node for this. Test against the top level > compatible and then find the PMIC nodes by their compatible strings. Hmm ok, indeed would be simpler. Neil > >> + >> +properties: >> + compatible: >> + const: hardkernel,odroid-go-ultra-poweroff >> + >> + hardkernel,rk817-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK817 PMIC node >> + >> + hardkernel,rk818-pmic: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Phandle to the RK818 PMIC node >> + >> +required: >> + - compatible >> + - hardkernel,rk817-pmic >> + - hardkernel,rk818-pmic >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + poweroff { >> + compatible = "hardkernel,odroid-go-ultra-poweroff"; >> + hardkernel,rk817-pmic = <&rk817>; >> + hardkernel,rk818-pmic = <&rk818>; >> + }; >> >> -- >> b4 0.10.1 >>